gnome: fix typo in vapigen option metadatadir#9806
Merged
dcbaker merged 1 commit intomesonbuild:masterfrom Jan 10, 2022
Merged
Conversation
This typo was introduced in 9ef36fa and can cause a build failure, because --metadatdir is not a valid vapigen option.
eli-schwartz
approved these changes
Jan 10, 2022
Member
eli-schwartz
left a comment
eli-schwartz
left a comment
There was a problem hiding this comment.
Ooof, thanks for the catch.
Codecov Report
@@ Coverage Diff @@
## master #9806 +/- ##
==========================================
- Coverage 67.35% 67.35% -0.01%
==========================================
Files 400 400
Lines 85469 85469
Branches 18832 18832
==========================================
- Hits 57570 57569 -1
- Misses 23390 23391 +1
Partials 4509 4509
Continue to review full report at Codecov.
|
dcbaker
approved these changes
Jan 10, 2022
Member
dcbaker
left a comment
dcbaker
left a comment
There was a problem hiding this comment.
oops. Clearly our testing of the gnome module leaves something to be desired...
Member
|
that mypy error will rebase out, it's fixed in the main branch and not related to this PR. |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Jan 11, 2022
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 13, 2022
nirbheek
added a commit
that referenced
this pull request
Jan 14, 2022
nirbheek
added a commit
that referenced
this pull request
Jan 14, 2022
Dudemanguy
pushed a commit
to Dudemanguy/meson
that referenced
this pull request
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This typo was introduced in 9ef36fa - #9594 and can cause a build failure, because --metadatdir is not a valid vapigen option. This can be seen for example in the fontmanager or AppStream builds, so this fix should ideally be part of 0.60.1.
@eli-schwartz @dcbaker