fix broken module tests which caused gtkdoc-check to traceback on assert#9807
Merged
eli-schwartz merged 1 commit intomesonbuild:masterfrom Jan 11, 2022
Merged
Conversation
eli-schwartz
force-pushed
the
gtkdoc-check-true
branch
from
6a453ad to
84faf76
Compare
dcbaker
approved these changes
Jan 10, 2022
Codecov Report
@@ Coverage Diff @@
## master #9807 +/- ##
==========================================
- Coverage 67.39% 64.35% -3.04%
==========================================
Files 400 200 -200
Lines 85439 42679 -42760
Branches 18832 9321 -9511
==========================================
- Hits 57583 27468 -30115
+ Misses 23334 13006 -10328
+ Partials 4522 2205 -2317 Continue to review full report at Codecov.
|
paper42
approved these changes
Jan 10, 2022
Contributor
paper42
left a comment
paper42
left a comment
There was a problem hiding this comment.
I can confirm this fixes the glib build for us,
eli-schwartz
force-pushed
the
gtkdoc-check-true
branch
from
84faf76 to
394581f
Compare
Regression in commit 566c2c9. The interpreter details are a bit of black magic. Functions expect tuples, but they receive lists and then the type-checking decorators convert those to tuples. So, directly manhandling a self._interpreter.func_*() but passing it the tuple it nominally expected, actually explodes in your face by way of failing an assert, then dumping 'ERROR: Unhandled python exception'. Fixes use of gnome.gtkdoc(..., check: true), for example when building glib.
eli-schwartz
force-pushed
the
gtkdoc-check-true
branch
from
394581f to
81fbcd1
Compare
13 tasks
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 13, 2022
gobject_typesfile html_assets mesonbuild#9807
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 13, 2022
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 14, 2022
check: true is needed for an actual regression test, but that requires a pedantically correct gtk-doc configuration, which I attempted to do and failed. So let's just put check: false so we get *some* coverage. Related to mesonbuild#9807
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 14, 2022
gobject_typesfile html_assets mesonbuild#9807
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 14, 2022
check: true is needed for an actual regression test, but that requires a pedantically correct gtk-doc configuration, which I attempted to do and failed. So let's just put check: false so we get *some* coverage. Related to mesonbuild#9807
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 14, 2022
gobject_typesfile html_assets mesonbuild#9807
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 14, 2022
check: true is needed for an actual regression test, but that requires a pedantically correct gtk-doc configuration, which I attempted to do and failed. So let's just put check: false so we get *some* coverage. Related to mesonbuild#9807
nirbheek
added a commit
to nirbheek/meson
that referenced
this pull request
Jan 14, 2022
check: true is needed for an actual regression test, but that requires a pedantically correct gtk-doc configuration, which I attempted to do and failed. So let's just put check: false so we get *some* coverage: just that typed_kwargs accepts the argument. Related to mesonbuild#9807
nirbheek
added a commit
that referenced
this pull request
Jan 14, 2022
gobject_typesfile html_assets #9807
nirbheek
added a commit
that referenced
this pull request
Jan 14, 2022
check: true is needed for an actual regression test, but that requires a pedantically correct gtk-doc configuration, which I attempted to do and failed. So let's just put check: false so we get *some* coverage: just that typed_kwargs accepts the argument. Related to #9807
nirbheek
added a commit
that referenced
this pull request
Jan 14, 2022
gobject_typesfile html_assets #9807
nirbheek
added a commit
that referenced
this pull request
Jan 14, 2022
check: true is needed for an actual regression test, but that requires a pedantically correct gtk-doc configuration, which I attempted to do and failed. So let's just put check: false so we get *some* coverage: just that typed_kwargs accepts the argument. Related to #9807
Dudemanguy
pushed a commit
to Dudemanguy/meson
that referenced
this pull request
Jan 21, 2022
gobject_typesfile html_assets mesonbuild#9807
Dudemanguy
pushed a commit
to Dudemanguy/meson
that referenced
this pull request
Jan 21, 2022
check: true is needed for an actual regression test, but that requires a pedantically correct gtk-doc configuration, which I attempted to do and failed. So let's just put check: false so we get *some* coverage: just that typed_kwargs accepts the argument. Related to mesonbuild#9807
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression in commit 566c2c9.
The interpreter details are a bit of black magic. Functions expect tuples, but they receive lists and then the type-checking decorators convert those to tuples.
So, directly manhandling a
self._interpreter.func_*()but passing it the tuple it nominally expected, actually explodes in your face by way of failing an assert, then dumping 'ERROR: Unhandled python exception'.Fixes use of
gnome.gtkdoc(..., check: true), for example when building glib./cc @paper42