refactor: changes attribute keys in OTEL plugin to follow semantic conventions

[roroghost17]

Summary

Aligns Bifrost's tracing attribute emissions with the OpenTelemetry GenAI semantic conventions spec. Bifrost-internal concepts (routing, governance, retry counters, etc.) were previously emitted under the gen_ai.* namespace, which pollutes the OTel spec namespace. This PR introduces a parallel bifrost.* namespace as the canonical home for those attributes and adds spec-compliant mappings for provider names, operation names, token usage keys, tool execution attributes, and more.

Legacy gen_ai.* emissions are retained in parallel (tagged // legacy:) to avoid breaking existing dashboards, with a clear migration path to drop them once consumers have moved over.

Changes

• Added core/schemas/otelconv.go with OTelOperationName and OTelProviderName helpers that map Bifrost-internal types to OTel GenAI spec values (e.g. Bedrock → aws.bedrock, ChatCompletionRequest → chat).
• Introduced a full set of bifrost.* attribute constants (AttrBifrostProviderName, AttrBifrostVirtualKeyID, AttrBifrostRetries, etc.) as the canonical namespace for Bifrost-internal span attributes.
• Added new OTel spec-aligned attribute constants: AttrOperationName, AttrChoiceCount, AttrEmbeddingsDimensionCount, AttrEncodingFormats, AttrUsageCacheReadInputTokens, AttrUsageCacheCreationInputTokens, AttrErrorTypeSpec, and tool execution attributes (AttrToolName, AttrToolCallID, AttrToolCallArguments, AttrToolCallResult, AttrToolType).
• Updated executeRequestWithRetries in bifrost.go to emit both legacy and canonical attributes, use OTelProviderName/OTelOperationName, and format the root span name as "{operation} {model}" per the GenAI semconv.
• Updated PopulateRequestAttributes, PopulateErrorAttributes, PopulateContextAttributes, and all response/request attribute helpers in llmspan.go to emit both legacy and spec-aligned keys in parallel.
• Fixed AttrStopSequences to emit a proper []string slice instead of a comma-joined string; the joined form is preserved under AttrBifrostStopSequencesJoined for back-compat.
• Added gen_ai.usage.input_tokens / gen_ai.usage.output_tokens alongside the deprecated prompt_tokens / completion_tokens keys across chat, text completion, and embedding response helpers.
• Added OTel GenAI tool execution attributes to MCP execute-tool spans in pluginpipeline.go, including tool name, call ID, arguments, and result (captured via named returns).
• Updated the OTel plugin converter to emit bifrost.request.id alongside the legacy gen_ai.request_id.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

go test ./core/... ./framework/tracing/... ./plugins/otel/...

Validate that spans emitted by executeRequestWithRetries contain both the legacy gen_ai.* attributes and the new bifrost.* / spec-aligned counterparts. Confirm MCP execute-tool spans include gen_ai.tool.name, gen_ai.tool.call.id, gen_ai.tool.call.arguments, and gen_ai.tool.call.result. Verify gen_ai.provider.name now emits the spec-canonical form (e.g. aws.bedrock) while bifrost.provider.name retains the short Bifrost name.

Breaking changes

• Yes
• No

All previously emitted attributes are still present. New attributes are additive. The only behavioral difference is that gen_ai.provider.name now emits the OTel canonical form rather than the Bifrost short name; the short name is preserved under bifrost.provider.name.

Security considerations

No auth, secrets, PII, or sandboxing changes. Span attributes may now include tool call arguments and results on MCP tool spans — operators should ensure their observability backend's data retention policies are appropriate for that data.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cbaa8c6b-b220-45c7-9db8-86be0fd0bb96

📥 Commits

Reviewing files that changed from the base of the PR and between e1bee15 and b92a081.

📒 Files selected for processing (6)

• core/bifrost.go
• core/mcp/pluginpipeline.go
• core/schemas/otelconv.go
• core/schemas/trace.go
• framework/tracing/llmspan.go
• plugins/otel/converter.go

---

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Enhanced observability and tracing infrastructure to follow OpenTelemetry GenAI conventions.
  • Expanded telemetry collection for LLM operations, including improved retry tracking, provider identity recording, and tool execution monitoring.
  • Standardized trace attributes across the system while maintaining backward compatibility with legacy formats.

Walkthrough

This PR expands Bifrost tracing to emit OpenTelemetry GenAI spec-compliant attributes alongside legacy attributes for backward compatibility. New OTel conversion helpers and attribute schema definitions enable core request handling, MCP tool spans, and request/response attribute population to emit both spec-style (gen_ai.*) and bifrost-namespaced (bifrost.*) attributes while preserving existing dashboard keys.

Changes

OTel Tracing Attribute Alignment

Layer / File(s)	Summary
OTel conversion helpers and attribute schema definitions core/schemas/otelconv.go, core/schemas/trace.go	New OTelOperationName and OTelProviderName functions map Bifrost enums to OTel strings. Schema expands to define spec-style keys (gen_ai.operation.name, gen_ai.request.choice.count, gen_ai.usage.cache_read.input_tokens), tool execution keys (gen_ai.tool.*), bifrost-namespaced keys (bifrost.provider.name, bifrost.request.id, etc.), and legacy dashboard keys (request.type, retry.count, error.type).
Core bifrost request tracing with OTel conventions core/bifrost.go	Per-attempt spans now use OTelOperationName(requestType) for naming and conditional span kinds (SpanKindLLMCall for attempt-0, SpanKindRetry for retries). Attributes expanded to emit provider (OTel + bifrost raw), operation, legacy request type/retry count, selected key and governance metadata, fallback index, and retry counts with both spec and bifrost-prefixed keys.
MCP tool execution span attributes core/mcp/pluginpipeline.go	runWithPluginPipeline uses named returns to enable deferred logic that emits tool-specific attributes (tool type/name, arguments, tool-call ID) and optionally serializes tool-call result for execute-tool spans; span status set from finalError.
Request and response attribute population for all request types framework/tracing/llmspan.go	PopulateRequestAttributes, PopulateErrorAttributes, and PopulateContextAttributes emit both OTel spec-style and bifrost-namespaced attributes alongside legacy attributes across chat completion, text completion, embeddings, and responses API spans. Stop sequences emit both preserved string slice and bifrost-joined format; token usage emits both legacy (prompt/completion) and spec (input/output/cache) keys; embedding params include embeddings.dimension.count and encoding_formats.
OTel exporter bifrost attribute export plugins/otel/converter.go	Root span export now appends both legacy AttrRequestID and bifrost-specific AttrBifrostRequestID attributes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• maximhq/bifrost#3730: Modifies core/bifrost.go span/attempt attribute emission; closely related to tracing/attribute changes here.

Suggested reviewers

• akshaydeo
• danpiths

Poem

🐰 Traces now shine in OTel's bright light,
Bifrost attributes dance left and right,
Legacy friends stay close by our side,
While spec-compliant fields take their stride,
One trace, two names, all specs unified! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately reflects the main refactoring effort to align Bifrost's tracing attributes with OpenTelemetry semantic conventions.
Description check	✅ Passed	The PR description comprehensively covers all required template sections including summary, changes, type, affected areas, testing steps, breaking changes, and checklist items.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 05-22-refactor_changes_attribute_keys_in_otel_plugin_to_follow_semantic_conventions

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[roroghost17]

• refactor: changes attribute keys in OTEL plugin to follow semantic conventions #3732 👈 (View in Graphite)
• docs: adds docs for OTEL on OSS features list and examples #3731
• feat: starts forwarding x-bf-eh to OTEL #3730
• fix: search content and video getting dropped from Bedrock requests #3729
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@core/bifrost.go`:
- Around line 5271-5274: The key-selection span is setting the provider
attribute using string(providerKey) which mismatches the canonical
representation used elsewhere; update the call that sets
schemas.AttrProviderName in the key-selection flow (where
keyTracer.SetAttribute(keyHandle, schemas.AttrProviderName, string(providerKey))
is used) to use the canonical helper schemas.OTelProviderName(providerKey)
instead so the same attribute key (schemas.AttrProviderName) emits the same
mapped value across spans (reference symbols: keyTracer.SetAttribute, keyHandle,
providerKey, schemas.AttrProviderName, schemas.OTelProviderName).

In `@core/mcp/pluginpipeline.go`:
- Around line 78-90: The defer currently always calls tracer.EndSpan(spanHandle,
schemas.SpanStatusOk, "") which hides failures; change it to inspect the
named-return finalError and end the span with an error status/message when
finalError != nil (e.g., use schemas.SpanStatusError and finalError.Error())
while preserving the existing tool-result attribute logic (finalResponse, req,
schemas.AttrToolCallResult, tracer.SetAttribute) before calling tracer.EndSpan;
ensure spanHandle and tracer are still nil-checked as before.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 788d971c-dc5d-4220-ada7-06a498039413

📥 Commits

Reviewing files that changed from the base of the PR and between 3ae04af and ad9565a.

📒 Files selected for processing (6)

• core/bifrost.go
• core/mcp/pluginpipeline.go
• core/schemas/otelconv.go
• core/schemas/trace.go
• framework/tracing/llmspan.go
• plugins/otel/converter.go

[greptile-apps]

Confidence Score: 5/5

Safe to merge — all changes are additive attribute emissions with no modification to request routing, provider logic, or auth paths.

Every previously emitted attribute is preserved verbatim; the new bifrost.* and spec-aligned keys are purely additive. The named-return refactor in pluginpipeline.go is straightforward and the deferred span status logic is correct. The only gap is that chat completions' N parameter still doesn't surface AttrChoiceCount, but that is a pre-existing omission rather than a regression.

framework/tracing/llmspan.go — PopulateChatRequestAttributes is the one place where the new AttrChoiceCount key was not applied despite the chat params struct supporting N.

Important Files Changed

Filename	Overview
core/bifrost.go	Updates fallback, stream-fallback, and executeRequestWithRetries spans: provider name now uses OTelProviderName(), bifrost.* mirrors added for all legacy gen_ai.* context attributes, and the root LLM call span is renamed to "{operation} {model}" per the OTel GenAI semconv.
core/mcp/pluginpipeline.go	Converts function to named returns to capture tool call result/error in defer; correctly adds tool execution OTel attributes (name, call ID, arguments, result) on execute-tool spans; the *string nil-pointer case from the previous review is handled explicitly.
core/schemas/otelconv.go	New file mapping Bifrost request/provider types to OTel GenAI spec values; well-structured with a clear default fallback for unknown types.
core/schemas/trace.go	Introduces bifrost.* namespace constants and new spec-aligned gen_ai.* keys; legacy keys annotated clearly for future removal.
framework/tracing/llmspan.go	Emits bifrost.* and spec-aligned keys in parallel with legacy gen_ai.* keys across all request/response helpers; AttrChoiceCount correctly added to text completions but omitted from chat completions which also supports N.
plugins/otel/converter.go	Adds bifrost.request.id alongside legacy gen_ai.request_id on root spans; minimal, correct change.

_{Reviews (4): Last reviewed commit: "refactor: changes attribute keys in OTEL..." | Re-trigger Greptile}

[akshaydeo]

Merge activity

• May 25, 3:35 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 25, 3:39 PM UTC: Graphite rebased this pull request as part of a merge.
• May 25, 3:39 PM UTC: @akshaydeo merged this pull request with Graphite.

The base branch was changed.