fix: preserve large numeric IDs in search params by skipping JSON parse for plain strings

[impoiler]

Summary

Prevents large numeric IDs (e.g., 64-bit integers) from losing precision when parsed from URL search parameters. Previously, all search values were passed through JSON.parse, which coerces large numbers to JavaScript's Number type and silently truncates them. This fix ensures only structured JSON values (objects and arrays) are parsed, while plain strings and numbers are left as-is.

Changes

• Introduced a safeJsonParse function that only calls JSON.parse on values beginning with { or [, leaving all other values as raw strings to avoid numeric precision loss.
• Configured the router to use parseSearchWith(safeJsonParse) instead of the default search parser.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

Navigate to a route that includes a large numeric ID (greater than Number.MAX_SAFE_INTEGER) in the URL search parameters and verify the ID is preserved exactly without truncation.

cd ui
pnpm i || npm i
pnpm build || npm run build

Screenshots/Recordings

N/A

Breaking changes

• Yes
• No

Related issues

N/A

Security considerations

No security implications. This change only affects client-side URL search parameter parsing.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c9913ad0-829e-4716-8f39-8810f1b5b16c

📥 Commits

Reviewing files that changed from the base of the PR and between b19776f and c63a749.

📒 Files selected for processing (2)

• framework/logstore/matviews.go
• ui/app/main.tsx

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Router search handling now safely parses structured JSON (objects/arrays) while preserving non-JSON primitives, reducing parsing errors and keeping URL params stable.
  • User filter display now falls back to user ID when a user name is missing or empty, ensuring consistent display and filtering.

Walkthrough

Adds a guarded safeJsonParse and configures TanStack Router with parseSearchWith(safeJsonParse) to only JSON-parse objects/arrays from the URL search; updates mv_filter_users to set name to COALESCE(NULLIF(user_name, ''), user_id).

Changes

Search parameter parsing safeguard

Layer / File(s)	Summary
Safe JSON parsing for search parameters ui/app/main.tsx	Adds safeJsonParse which JSON-parses only values starting with { or [ and wires it into router initialization via parseSearch: parseSearchWith(safeJsonParse), preserving primitive search values.

Materialized view updates

Layer / File(s)	Summary
Use COALESCE(NULLIF(user_name, ''), user_id) for user display name framework/logstore/matviews.go	mv_filter_users now sets name to COALESCE(NULLIF(user_name, ''), user_id) so empty or null user_name falls back to user_id in the view.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• akshaydeo

Poem

I nibble through query strings with care,
Braces, brackets — I only parse what's there,
Plain words I leave on their merry way,
While names that vanish get IDs today,
Hops and bytes, a rabbit's tidy care 🐰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing numeric ID precision loss by avoiding JSON parsing on plain strings in search params.
Description check	✅ Passed	The description covers all critical sections: it explains the problem, details the solution, specifies the change type and affected areas, provides testing instructions, and addresses breaking changes and security considerations.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 05-22-fix_preserve_large_number_precision_in_query_params_for_filters

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[impoiler]

• fix: preserve large numeric IDs in search params by skipping JSON parse for plain strings #3692 👈 (View in Graphite)
• fix: use user_name instead of user_id for user filter display name #3691
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ui/app/main.tsx`:
- Around line 12-18: safeJsonParse currently calls JSON.parse for values
starting with "{" or "[" which will throw on malformed JSON and can break route
parsing via parseSearchWith(safeJsonParse); wrap the JSON.parse call in a
try/catch inside safeJsonParse, return the original value (the raw string) on
parse errors, and keep successful parsed objects/arrays returned as before so
navigation doesn't crash on bad URLs.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 192e34e1-2e42-44f7-b6a8-47739edae912

📥 Commits

Reviewing files that changed from the base of the PR and between eee42c2 and 3758a45.

📒 Files selected for processing (1)

• ui/app/main.tsx

[greptile-apps]

Confidence Score: 4/5

Safe to merge the UI change; the Go matview fix needs a mechanism to rebuild the existing view on upgrade.

The ui/app/main.tsx change is low-risk and self-contained. The mv_filter_users DDL change is the right fix logically, but CREATE MATERIALIZED VIEW IF NOT EXISTS means the updated COALESCE expression is never applied to an already-existing view — existing users won't see the behaviour change until the view is rebuilt manually or a drop mechanism is added.

framework/logstore/matviews.go — the selectExpr change needs a way to force-rebuild the existing mv_filter_users view on upgrade.

Important Files Changed

Filename	Overview
framework/logstore/matviews.go	Changes mv_filter_users selectExpr to COALESCE(NULLIF(user_name,''),user_id) AS name, but CREATE MATERIALIZED VIEW IF NOT EXISTS prevents the new DDL from being applied on existing deployments.
ui/app/main.tsx	Adds safeJsonParse to skip JSON.parse for non-object/array search strings, preventing precision loss for large integer IDs passed as plain URL parameters.

_{Reviews (3): Last reviewed commit: "fix: preserve large number precision in ..." | Re-trigger Greptile}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@framework/logstore/matviews.go`:
- Line 223: The SELECT expression uses COALESCE(user_name, user_id) which treats
empty strings as valid values; update the selectExpr so empty user_name strings
are treated as NULL before coalescing (e.g., use NULLIF or an equivalent) so the
name column falls back to user_id; locate the selectExpr string in matviews.go
and replace COALESCE(user_name, user_id) with COALESCE(NULLIF(user_name, ''),
user_id) (keeping the aliases "user_id AS id" and "AS name" unchanged).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f14e7403-a025-4453-8b72-efddd2b75078

📥 Commits

Reviewing files that changed from the base of the PR and between f2e2c91 and b19776f.

📒 Files selected for processing (2)

• framework/logstore/matviews.go
• ui/app/main.tsx

[akshaydeo]

Merge activity

• May 22, 11:07 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 22, 11:07 AM UTC: @akshaydeo merged this pull request with Graphite.