fix: exclude empty model entries from model rankings matview queries

[impoiler]

Summary

Filters out entries with empty model values from model rankings queries to prevent blank/unknown models from appearing in rankings results.

Changes

• Added WHERE model != '' filter to both the current period and previous period queries in getModelRankingsFromMatView, ensuring that rows with no model identifier are excluded from aggregation and ranking calculations.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

Verify that model rankings no longer include entries with an empty model name. Query the mv_logs_hourly materialized view directly to confirm rows with model = '' exist, then check that the rankings endpoint/response omits them.

go test ./framework/logstore/...

Breaking changes

• Yes
• No

Related issues

Security considerations

None.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e6dacb4d-ef51-4d15-a377-6295945967d3

📥 Commits

Reviewing files that changed from the base of the PR and between 8d24199 and 1b44092.

📒 Files selected for processing (1)

• framework/logstore/matviews.go

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved model ranking accuracy by excluding blank or empty model entries from ranking and trend calculations. This prevents empty model groups from appearing in leaderboards and from skewing comparisons between current and previous periods, yielding more reliable historical trends and cleaner results.

Walkthrough

The getModelRankingsFromMatView function now excludes empty model values from both current-period and previous-period mv_logs_hourly queries by adding model IS NOT NULL AND model != '' predicates.

Model filtering in ranking queries

Layer / File(s)	Summary
Filter empty models from ranking matview queries framework/logstore/matviews.go	Both the current-period and previous-period mv_logs_hourly matview queries add model IS NOT NULL AND model != '' predicates to exclude empty-model aggregates from model/provider rankings and trend calculations.

🎯 2 (Simple) | ⏱️ ~5 minutes

🐰 A filter here, a filter there,
Empty models vanish in the air!
Rankings now pristine and clean,
Only valid models on the screen! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: excluding empty model entries from model rankings matview queries.
Description check	✅ Passed	The description covers all required sections with sufficient detail: summary explains the problem, changes detail the specific fix, type of change is marked, affected areas are identified, testing instructions are provided, and breaking changes are clarified.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 05-26-fix_model_ranking_data_query

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[impoiler]

• fix: recreate mv_filter_users matview to exclude rows with empty user_name #3764
• refactor: export ResolvePeriod function for external use #3763
• refactor: propagate errors from GetAvailable* methods instead of silently returning empty slices #3759
• fix: exclude empty model entries from model rankings matview queries #3758 👈 (View in Graphite)
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Confidence Score: 5/5

Safe to merge — the two-line addition is a straightforward filter with no side-effects on unrelated query paths.

The change adds a well-formed NULL-safe filter (IS NOT NULL AND != '') to both subqueries, matching the established pattern elsewhere in the codebase. The scope is narrow and the logic is easy to verify.

No files require special attention.

Important Files Changed

Filename	Overview
framework/logstore/matviews.go	Adds model IS NOT NULL AND model != '' filter to both current-period and previous-period queries in getModelRankingsFromMatView, correctly excluding blank and NULL model entries from rankings.

_{Reviews (3): Last reviewed commit: "fix: model ranking data query" | Re-trigger Greptile}

[akshaydeo]

Merge activity

• May 26, 5:44 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 26, 5:45 PM UTC: @akshaydeo merged this pull request with Graphite.