feat: adds multiple teams / customers / bus to connectors - #4875
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adds six new exported trace attribute constants for pluralized governance context (team IDs/names, customer IDs/names, business unit IDs/names) and updates ChangesGovernance Tracer Attributes
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
Merge activity
|
* upstream/dev: feat: adds multiple teams / customers / bus to connectors (maximhq#4875) fix: small latency return fixes (maximhq#4876) Added missing OpenAI responses methods for lifecycle related tasks (maximhq#3125) feat: latency info on errors (maximhq#4867) feat: add `user_name`, `team_ids`, `team_names`, `customer_ids`, `customer_names`, `business_unit_ids`, `business_unit_names` to log list select columns (maximhq#4866) feat: add multi-value attribution cell with plural fallback for logs columns (maximhq#4865)

Summary
Adds support for multi-value governance attributes (team IDs/names, customer IDs/names, business unit IDs/names) as trace span attributes, complementing the existing single-value variants.
Changes
bifrost.team.ids,bifrost.team.names,bifrost.customer.ids,bifrost.customer.names,bifrost.business_unit.ids, andbifrost.business_unit.namesBifrostContextKeyGovernanceTeamIDs,BifrostContextKeyGovernanceTeamNames,BifrostContextKeyGovernanceCustomerIDs,BifrostContextKeyGovernanceCustomerNames,BifrostContextKeyGovernanceBusinessUnitIDs,BifrostContextKeyGovernanceBusinessUnitNames) to set these attributes on trace spans during request executionType of change
Affected areas
How to test
Populate the new plural governance context keys on a request context and verify the resulting trace span contains the expected multi-value attributes.
go test ./...Breaking changes
Related issues
Security considerations
The new attributes propagate governance-scoped identifiers (team, customer, business unit) into trace spans. Ensure these values are not considered sensitive in your observability backend, or that appropriate access controls are in place on trace data.
Checklist
docs/contributing/README.mdand followed the guidelines