Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NodeJS 8, Angular 6, electron 2.0.2, RxJS 6.1 #182

Merged
merged 6 commits into from
May 25, 2018

Conversation

leo6104
Copy link
Contributor

@leo6104 leo6104 commented May 18, 2018

Changes

  • Upgrade to angular 6.0.2 (using ng update @angular/cli command two times)
  • Remove 'rxjs' blocklist from tslint.json, import all members from 'rxjs'
  • Upgrade to Electron 2.0.2 with bigger favicon (512x512)
  • Change README.md
  • Travis CI runs with NodeJS 8 system. (Angular cli 6 supports only 8.9 >=)
  • add lint, e2e, test process to Travis CI
  • remove hooks, use fileReplacements logic in angular.json
  • Cleanup npm scripts with -- parameter patterns.

Tests

  • npm run ng:serve works!
  • npm run build works!
  • npm run test works!
  • Test with windows
  • Test with mac

Since Angular 6 supports webpack 4 without node-js built-ins (angular/angular-cli#9827 (comment)), ng serve shows some warning messages.

WARNING in ./node_modules/zone.js/dist/zone-mix.js
Module not found: Error: Can't resolve 'crypto' in '/Users/sangmin/Desktop/Github/angular-electron/node_modules/zone.js/dist'

WARNING in ./node_modules/zone.js/dist/zone-mix.js
Module not found: Error: Can't resolve 'fs' in '/Users/sangmin/Desktop/Github/angular-electron/node_modules/zone.js/dist'

WARNING in ./node_modules/zone.js/dist/zone-mix.js
Module not found: Error: Can't resolve 'timers' in '/Users/sangmin/Desktop/Github/angular-electron/node_modules/zone.js/dist'

But, with electron serving, it works well :)

@leo6104 leo6104 changed the title Update to angular 6.0.2, electron 2.0.1, rxjs 6.1 Update to NodeJS 8, Angular 6, electron 2.0.1, RxJS 6.1 May 18, 2018
@leifwells
Copy link

I am not a PR approver on this project, just a user. I wanted to give this PR a spin since it puts Angular 6 + Electron 2 together. Everything appears to be working with this PR, except that when I ran npm test I got the following error:

angular-electron leifwells$ ng test
 10% building modules 1/1 modules 0 active(node:61074) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
18 05 2018 19:47:07.226:INFO [karma]: Karma v2.0.2 server started at http://0.0.0.0:9876/
18 05 2018 19:47:07.228:INFO [launcher]: Launching browser Chrome with unlimited concurrency
18 05 2018 19:47:07.232:INFO [launcher]: Starting browser Chrome
18 05 2018 19:47:14.227:INFO [Chrome 66.0.3359 (Mac OS X 10.13.4)]: Connected on socket bMIwFgwifkky8WvNAAAA with id 62972712
Chrome 66.0.3359 (Mac OS X 10.13.4): Executed 0 of 0 SUCCESS (0 secs / 0 Chrome 66.0.3359 (Mac OS X 10.13.4): Executed 0 of 0 ERROR (0.001 secs / 0 secs)

Not a lot information or clues to debug on from this error and I expect there is something out of date or missing on my computer, but wanted to mention it here.

@leo6104
Copy link
Contributor Author

leo6104 commented May 19, 2018

@leifwells Nice catch :) I found the root cause is the warning messages i mentioned in above.
The warning messages came from import 'zone.js/dist/zone-mix'; in polyfills.ts.
So, i modify angular.json to use polyfills-test.ts instead of polyfills.ts when karma test run.

Now, added npm run lint/test/e2e process in Travis CI.
Please check @maximegris :)

@leifwells
Copy link

I can confirm that these updates have resolved my issue mentioned above.

@leo6104 leo6104 mentioned this pull request May 22, 2018
@leo6104 leo6104 changed the title Update to NodeJS 8, Angular 6, electron 2.0.1, RxJS 6.1 Update to NodeJS 8, Angular 6, electron 2.0.2, RxJS 6.1 May 23, 2018
@maximegris maximegris mentioned this pull request May 25, 2018
@maximegris
Copy link
Owner

Hi,

Great works !
Can you please fix the conflict, I'll merge the PR as soon as possible ;)

@leo6104
Copy link
Contributor Author

leo6104 commented May 25, 2018

@maximegris Thanks :) I fix the conflicts!

@maximegris maximegris merged commit 16f5b25 into maximegris:master May 25, 2018
@maximegris
Copy link
Owner

Done !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants