refactor(hooks): replace hooks to ng-cli fileReplacements logic

maximegris · May 19, 2018 · b7d3001 · b7d3001
1 parent 7fbc68c
commit b7d3001
Show file tree

Hide file tree

Showing 13 changed files with 35 additions and 317 deletions.
diff --git a/angular.json b/angular.json
@@ -30,6 +30,23 @@
             "scripts": []
           },
           "configurations": {
+            "dev": {
+              "optimization": false,
+              "outputHashing": "all",
+              "sourceMap": true,
+              "extractCss": true,
+              "namedChunks": false,
+              "aot": false,
+              "extractLicenses": true,
+              "vendorChunk": false,
+              "buildOptimizer": false,
+              "fileReplacements": [
+                {
+                  "replace": "src/environments/environment.ts",
+                  "with": "src/environments/environment.dev.ts"
+                }
+              ]
+            },
             "production": {
               "optimization": true,
               "outputHashing": "all",
@@ -40,7 +57,12 @@
               "extractLicenses": true,
               "vendorChunk": false,
               "buildOptimizer": true,
-              "fileReplacements": []
+              "fileReplacements": [
+                {
+                  "replace": "src/environments/environment.ts",
+                  "with": "src/environments/environment.prod.ts"
+                }
+              ]
             }
           }
         },
@@ -50,6 +72,9 @@
             "browserTarget": "angular-electron:build"
           },
           "configurations": {
+            "dev": {
+              "browserTarget": "angular-electron:build:dev"
+            },
             "production": {
               "browserTarget": "angular-electron:build:production"
             }

diff --git a/hooks/environments/README.md b/hooks/environments/README.md
diff --git a/hooks/environments/app.config.ts.tpl b/hooks/environments/app.config.ts.tpl
diff --git a/hooks/environments/set_profile.js b/hooks/environments/set_profile.js
diff --git a/hooks/src/app/app.config.ts b/hooks/src/app/app.config.ts
diff --git a/hooks/src/app/appconfig.ts b/hooks/src/app/appconfig.ts
diff --git a/package.json b/package.json
@@ -19,9 +19,10 @@
   "scripts": {
     "postinstall": "npx electron-builder install-app-deps",
     "ng": "ng",
-    "start": "node hooks/environments/set_profile.js && npm-run-all -p ng:serve electron:serve",
-    "build": "node hooks/environments/set_profile.js && ng build && npm run electron:tsc",
-    "build:prod": "node hooks/environments/set_profile.js && ng build -c production && npm run electron:tsc",
+    "start": "npm-run-all -p ng:serve electron:serve",
+    "build": "npm run electron:tsc && ng build",
+    "build:dev": "npm run build -- -c dev",
+    "build:prod": "npm run build -- -c production",
     "ng:serve": "ng serve -o",
     "electron:tsc": "tsc main.ts",
     "electron:serve": "wait-on http-get://localhost:4200/ && npm run electron:tsc && electron . --serve",

diff --git a/src/app/app.component.ts b/src/app/app.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 import { ElectronService } from './providers/electron.service';
 import { TranslateService } from '@ngx-translate/core';
-import { AppConfig } from './app.config';
+import { AppConfig } from '../environments/environment';
 
 @Component({
   selector: 'app-root',

diff --git a/src/app/app.config.ts b/src/app/app.config.ts
diff --git a/src/environments/environment.dev.ts b/src/environments/environment.dev.ts
@@ -3,7 +3,7 @@
 // `ng build --env=prod` then `index.prod.ts` will be used instead.
 // The list of which env maps to which file can be found in `.angular-cli.json`.
 
-export const CONF_DEV = {
+export const AppConfig = {
   production: false,
   environment: 'DEV'
 };
diff --git a/src/environments/environment.prod.ts b/src/environments/environment.prod.ts
@@ -1,4 +1,4 @@
-export const CONF_PROD = {
+export const AppConfig = {
   production: true,
   environment: 'PROD'
 };