Electron2 update #177
Closed
Electron2 update #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2018 11:09
|
Hi, Thanks! Sorry for the late answer. There were several PRs about Angluar&Electron. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron v2.0.0 is out for 19 hours already, it's time to chase the bleeding edge
https://github.com/electron/electron/releases/tag/v2.0.0
Had to create a 512x512 icon and replace the 256x256 (without changing the filename) because the compiler would complain when building:
favicon.256x256.png must be at least 512x512I wasn't able to figure out how to simply refer to a new file with a new filename when building the app.
The app built successfully on a Mac. If you'd like I can confirm whether it builds on a PC too.