Add OpenAI-compatible TTS provider

[matthewhand]

OpenAI-compatible TTS provider

Draft against matthewhand/OpenMausBot main.

ElevenLabs or an OpenAI-compatible /v1/audio/speech server (Kokoro, LiteLLM, OpenAI).

Finished

• Per-provider keys, voice ids, and model (openaiKey / openaiVoice / openaiModel).
• Per-bot openaiVoice is stored separately from bot.voice. Speak / Call / auto-speak / Settings use botVoiceId(provider, bot) so a leftover ElevenLabs id is never sent to Kokoro.
• Verify and speak send the saved model + response_format: mp3.
• Voice list: /audio/voices then /voices. OpenAI host fallback is alloy/echo/…, not Kokoro af_heart.
• Custom voice id field. openaiKeyConfigured + Clear.
• README is not ElevenLabs-only.

Tests

pnpm exec vitest run server/tts/tts.test.ts server/tts/speech-text.test.ts server/config.test.ts src/lib/tts-provider.test.ts

[amazon-q-developer]

Review Summary

This PR successfully adds OpenAI-compatible TTS provider support alongside ElevenLabs. The routing logic is well-structured with proper backward compatibility.

Critical Issues Found

Security (5 findings)

• Unvalidated baseUrl parameter creates SSRF vulnerability in three functions (verifyKey, listVoices, synthesize). URLs must be validated before being used in fetch calls to prevent potential exploitation.

Logic Errors (2 findings)

• Voice ID handling in listVoices can produce invalid empty voice IDs
• Voice filtering doesn't properly handle whitespace-only IDs

All identified issues have blocking severity and must be fixed before merge.

---

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

[amazon-q-developer]

🛑 Logic Error: Empty voice IDs can pass through the mapping. When all properties (v.voice_id, v.id) are missing or empty, line 76 creates id: String(""), which is an empty string. Line 80's filter checks v.id for truthiness, but empty strings are falsy, so they would be filtered out. However, if any property exists but is an empty string, it could pass through, creating invalid voices.

Suggested change

	id: String(v.voice_id ?? v.id ?? ""),
	id: String(v.voice_id ?? v.id ?? "").trim(),

[amazon-q-developer]

🛑 Logic Error: The filter checks v.id but should explicitly check for non-empty strings. Currently, whitespace-only IDs would pass through since .trim() is not applied before filtering, potentially causing issues when voices are used.

Suggested change

	.filter((v: Voice) => v.id);
	.filter((v: Voice) => v.id.trim().length > 0);

[amazon-q-developer]

🛑 Security Vulnerability: Unvalidated user input (baseUrl) is used directly in URL construction without sanitization. Malicious URLs could potentially exploit the fetch API or trigger SSRF attacks. Validate the URL format before use.¹

Suggested change

	const url = `${baseUrl.replace(/\/$/, "")}/audio/speech`;
	const parsedUrl = new URL(baseUrl);
	if (!['http:', 'https:'].includes(parsedUrl.protocol)) {
	throw new Error('Invalid URL protocol');
	}
	const url = `${parsedUrl.origin}${parsedUrl.pathname.replace(/\/$/, "")}/audio/speech`;

Footnotes

1. CWE-918: Server-Side Request Forgery (SSRF) - https://cwe.mitre.org/data/definitions/918.html ↩

[amazon-q-developer]

🛑 Security Vulnerability: Unvalidated baseUrl used directly in URL construction. This pattern is repeated across multiple functions and creates SSRF risk. Apply the same URL validation as suggested for the verifyKey function.¹

Suggested change

	const url = `${baseUrl.replace(/\/$/, "")}/voices`;
	const parsedUrl = new URL(baseUrl);
	if (!['http:', 'https:'].includes(parsedUrl.protocol)) {
	throw new Error('Invalid URL protocol');
	}
	const url = `${parsedUrl.origin}${parsedUrl.pathname.replace(/\/$/, "")}/voices`;

Footnotes

1. CWE-918: Server-Side Request Forgery (SSRF) - https://cwe.mitre.org/data/definitions/918.html ↩

[amazon-q-developer]

🛑 Security Vulnerability: Unvalidated baseUrl creates SSRF risk in the synthesize endpoint. Apply URL validation as suggested for other functions.¹

Suggested change

	const url = `${baseUrl.replace(/\/$/, "")}/audio/speech`;
	const parsedUrl = new URL(baseUrl);
	if (!['http:', 'https:'].includes(parsedUrl.protocol)) {
	throw new Error('Invalid URL protocol');
	}
	const url = `${parsedUrl.origin}${parsedUrl.pathname.replace(/\/$/, "")}/audio/speech`;

Footnotes

1. CWE-918: Server-Side Request Forgery (SSRF) - https://cwe.mitre.org/data/definitions/918.html ↩