feat(routines): report runs in source conversations - #562
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (18)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughRoutine runs now retain source conversation provenance, synchronize redacted lifecycle cards, route notifications and unread state to the source conversation, expose latest run details, and render status cards in bot and group transcripts. ChangesRoutine lifecycle reporting
Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: 🟡 Moderate · up to Runs now publish lifecycle cards into source conversations, but some transitions can show a status before the underlying routine state is durably saved, leaving users with misleading run information after an interruption or save failure. Updates also depend on each producer applying redaction correctly. Merge should wait for explicit owner acceptance or follow-up on these bounded correctness and data-handling risks. Sequence Diagram(s)sequenceDiagram
participant RoutineManager
participant ServerIndex
participant MessageStore
participant ChatView
participant NotificationSystem
RoutineManager->>ServerIndex: emit routine run change
ServerIndex->>MessageStore: upsert routine.run card in source conversation
ServerIndex->>NotificationSystem: send source-thread notification
MessageStore->>ChatView: deliver routine.run message
ChatView->>RoutineManager: open execution thread when task exists
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the implementation and verification, but it does not follow the required template. It omits the explicit Why section, Screenshots section for the UI changes, and Checklist items.
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Safety and behavior
Calendar/API callers cannot forge a source conversation. Lifecycle content is bounded and redacted before persistence. Replayed terminal events and marking failures seen do not re-mark the source unread.
Verification
Summary by CodeRabbit
New Features
Bug Fixes