fix(routines): flat schedule schema + coercion so chat proposals survive provider schema conversion

[milind-soni]

What changed

propose_routine's schedule schema and input handling in the agents MCP proxy. Harness dialect and server are untouched.

• Flat schema, no oneOf/const/format. The schedule was a oneOf of two const-discriminated branches — exactly the JSON-Schema composition keywords several agent CLIs flatten or drop when converting MCP tools into their provider's function-call format (codex-rs only began preserving oneOf in June 2026, codex-rs/tools/src/json_schema.rs #24118; its large-schema compaction still prunes compositions; other drivers simplify harder). A model that never saw the branches guesses shapes forever. The schema is now one flat object (type: once|weekly|daily + at/time/weekdays) with the rules in descriptions.
• Coercion for what models actually send (normalizeScheduleInput): "daily" → weekly-on-all-7-days on the wire; JSON-string schedules parsed; weekday names case-folded, short names (mon…sun) expanded.
• Guiding errors instead of walls: sub-day intervals are named as unsupported with the closest alternatives spelled out; weekly without weekdays points at "daily"; unknown types list the three supported shapes with examples. Same for propose_routine_action update changes.

Why

Field report hours after 0.1.38 shipped #540: a bot (gpt-5.6-sol) failed agents_propose_routine on every attempt — tried a 30-min interval, concluded "only weekly is supported, best I can do is daily", sent type:"daily", failed six more times, then told the user "the routine proposal tool is returning errors every time — it's not accepting any input."

I reproduced the full pipeline against a live server (real proxy → real /api/internal/routine-requests): valid payloads work — the field failures are all model-shaped inputs, and the old replies never taught the model the correct shape:

payload	before	after
valid weekly	✅ card	✅ card (byte-identical dialect)
type:"daily"	❌ Invalid discriminator value. Expected 'once' | 'weekly'	✅ card (weekly × 7 days)
schedule as JSON string	❌ needs name/instructions/schedule	✅ card
["Mon","FRI"]	❌ (short names) / ✅ caps only	✅ card
30-min interval	❌ Invalid discriminator value…	❌ with instructions naming the limit + closest shapes
weekly w/o weekdays	❌ expected array, received undefined	❌ with use {"type":"daily"} guidance

How it was verified

• npx vitest run server/drivers/agents-proxy.test.ts — 20 pass. New: flat-schema assertion (regexp-guards against any composition keyword reappearing in the tool surface), daily-alias wire shape, case/short weekday folding, string-schedule parsing, guided errors that never reach the harness. Existing weekly/once passthrough tests unchanged.
• Mutation check: disabling the daily alias fails the new tests; restoring passes.
• Live end-to-end (dev server on a scratch data dir + real proxy): the table above is from that run.
• pnpm typecheck clean. Lint: this file has 35 pre-existing anti-slop findings on main; the additions follow the file's existing no-deps typeof-boundary style (6 more of the same rules; lint is not a CI gate — flagging for transparency).

Note for reviewers

The same conversion fragility applies to any future MCP tool schema: avoid oneOf/anyOf/const in tool inputs — flat objects + description-enforced rules + instructive errors survive every driver. Might be worth a line in CONTRIBUTING.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Improved routine scheduling support for one-time, weekly, and daily routines.
  • Daily schedules are automatically interpreted across all seven days.
  • Weekday names are normalized consistently, including abbreviated and capitalized forms.
  • Schedule details provided as JSON text are now recognized automatically.

• Bug Fixes

  • Unsupported or incomplete schedules now return clearer guidance before a routine is submitted.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
openmausbot-docs	Ready	Preview	Aug 28, 2026 10:34am

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7430d4a8-500a-4615-a5e7-f2d8ab545bfa

📥 Commits

Reviewing files that changed from the base of the PR and between 7983055 and 9476dfe.

📒 Files selected for processing (2)

• server/drivers/agents-proxy.test.ts
• server/drivers/agents-proxy.ts

---

📝 Walkthrough

Walkthrough

The routine schedule schema now uses a flat type enum. Schedule inputs are parsed, normalized, and validated before harness calls. Unsupported schedules return guidance through both proposal and update paths.

Changes

Routine schedule handling

Layer / File(s)	Summary
Schedule contract and normalization server/drivers/agents-proxy.ts, server/drivers/agents-proxy.test.ts	The schedule schema accepts once, weekly, and daily. The normalizer parses JSON strings, validates schedule fields, normalizes weekdays, and expands daily schedules to all weekdays.
Routine tool integration server/drivers/agents-proxy.ts, server/drivers/agents-proxy.test.ts	Routine proposal and update paths return schedule errors before harness calls. Tests cover normalized requests and unsupported schedules.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant MCPTool
  participant routineFields
  participant normalizeScheduleInput
  participant Harness

  MCPTool->>routineFields: Submit routine schedule
  routineFields->>normalizeScheduleInput: Normalize schedule
  normalizeScheduleInput-->>routineFields: Normalized schedule or error
  alt Valid schedule
    routineFields->>Harness: Send normalized routine
  else Unsupported schedule
    routineFields-->>MCPTool: Return guidance error
  end

Loading

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/routine-propose-contract

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}