fix(chief): create specialists from channels - #554
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe create-bot endpoint now accepts Chief-owned channel threads in addition to direct task threads. An HTTP test verifies successful operator creation and 403 responses for unauthorized senders and channels. ChangesChief operator creation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to Chiefs can now create bots from authorized channel conversations while current membership and Chief-only checks remain enforced. The change is mergeable with owner awareness that the service endpoint should eventually bind caller credentials to bot identity to reduce potential identity-substitution risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains what changed, why it changed, and how it was verified. It also lists regression coverage and validation commands. It omits the repository checklist and uses equivalent headings instead of the template headings, but the required change context is complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
create_botfrom channel conversations and channel task threadsWhy
The agents MCP is mounted for channel turns, but the internal creation route only accepted the Chief’s private task threads. That made the advertised tool fail with
403 source thread does not belong to senderwhenever it was called from a channel.Validation
pnpm vitest run server/index.test.ts— 107 passedpnpm typecheckgit diff --checkSummary by CodeRabbit
New Features
Bug Fixes