feat(cloud): select NEXT backend at runtime in Rust by teamleaderleo · Pull Request #35133 · manaflow-ai/cmux

teamleaderleo · 2026-11-04T08:29:37Z

NEXT Cloud backend iteration currently requires separate app builds, and the native app and daemon choose deployments independently. This adds one Rust deployment table and a persisted per-bundle cmux cloud env get|set local|dev|preview-N|staging|prod --json selection. DEV defaults to dev, NEXT nightly defaults to prod, and Release/RC are locked to prod.

Leo: "let's also get our iteration loop good for the whole working on cloud type thing".

The CLI validates the app bundle before asking it to apply a saved change. The following app-wiring PR consumes this JSON and implements that apply method; an older app saves it and reports that a manual restart is needed. The helper waits for the exact app process to exit before reopening its bundle. Auth namespace revisions rotate only on an actual environment change, including when returning to an earlier environment. Preview share tokens retain their development issuer. NEXT nightly sharing now follows the selected deployment (prod by default), matching its API token issuer. Empty CMUX_SHARE_ROOM_URL still disables sharing. Classic deployment fallback behavior is preserved.

The state-root baseline declares this crate as the sole resolver for the validated per-bundle selection path. The table, persistence tests and CLI adapter stay in this seam so no second endpoint table is needed in the app.

Observed / Not run

Initial fleet snapshot: 6 environment tests and 1 platform issuer test passed; CLI compiled. Run: https://github.com/manaflow-ai/cmux/actions/runs/41798882125 (288.184 seconds client wall time).
Exact committed d6618f4: fleet crate, CLI library, platform and host wire tests passed: https://github.com/manaflow-ai/cmux/actions/runs/41799975958 (279.587 seconds client wall time). Final head ab798cd: 6 environment, 3 CLI library, and 1 platform test passed; host crates compiled (wire filter selected no tests). Run: https://github.com/manaflow-ai/cmux/actions/runs/41801055904 (450.597 seconds client wall time).
Independent Claude Opus 5.5 medium review: SHIP at ab798cd; no follow-ups.
Static pre-push checks passed.
App integration and actual staging chat read-back follow in the app-wiring seam.

🤖 Generated with Codex

Agent session: agent session

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7f47f1f7d409b2d65458

github-actions · 2026-11-04T08:29:51Z

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review ab798cd: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35133 -f ref=lane/cloud-runtime-environment -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: red check: Base-red classifier (per test) (+1 more) is not red on the base 3b4cd35; do not merge until green; see lane-rules

Shipped in:

cmux NEXT nightly 1.0.0-nightly.4182499138501 (e0aa712b3b)
cmux NEXT nightly 1.0.0-nightly.4184087390301 (08052d331e)
cmux NEXT nightly 1.0.0-nightly.4184224384601 (a3abfc4160)
cmux NEXT nightly 1.0.0-nightly.4184409870901 (78ee0e108e)

blacksmith-sh · 2026-11-04T08:37:21Z

Found 7 test failures on Blacksmith runners:

Failures

Test	View Logs
`EXEMPT names nightly.yml job launch-smoke-nightly, which no longer exists (launches the` `app in the release-pool DMG beside signer-dmg; builds nothing, no Xcode)/` `EXEMPT names nightly.yml job launch-smoke-nightly, which no longer exists (launches the` `app in the release-pool DMG beside signer-dmg; builds nothing, no Xcode)`	View Logs
`nightly cmux-tui resolve/nightly cmux-tui resolve`	View Logs
`test_every_depth_fetch_checks_for_a_shallow_checkout (main.NoShallowDevFetchTests.t` `est_every_depth_fetch_checks_for_a_shallow_checkout)/` `test_every_depth_fetch_checks_for_a_shallow_checkout (main.NoShallowDevFetchTests.t` `est_every_depth_fetch_checks_for_a_shallow_checkout)`	View Logs
`test_fork_pull_requests_into_manaflow_ai_never_reach_an_owned_runner_label (main.Fo` `rkRunnerRoutingTests.test_fork_pull_requests_into_manaflow_ai_never_reach_an_owned_runn` `er_label)/` `test_fork_pull_requests_into_manaflow_ai_never_reach_an_owned_runner_label (main.Fo` `rkRunnerRoutingTests.test_fork_pull_requests_into_manaflow_ai_never_reach_an_owned_runn` `er_label)`	View Logs
`test_next_adds_no_classic_cloud_calls (main.ClassicCloudRoutes.test_next_adds_no_cl` `assic_cloud_calls)/` `test_next_adds_no_classic_cloud_calls (main.ClassicCloudRoutes.test_next_adds_no_cl` `assic_cloud_calls)`	View Logs
`test_send_path_has_no_new_caps (main.SendPathCaps.test_send_path_has_no_new_caps)/` `test_send_path_has_no_new_caps (main.SendPathCaps.test_send_path_has_no_new_caps)`	View Logs
`the short nightly decide gate must use the pooled Linux route with a Blacksmith fallbac` `k/` `the short nightly decide gate must use the pooled Linux route with a Blacksmith fallbac` `k`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7f47f1f7d409b2d65458

teamleaderleo · 2026-11-04T08:57:52Z

Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over.

For awareness: this PR added cmux-tui/crates/cmux-cloud-environment/src/lib.rs with the cmux.com and cmux-staging origins after the classic Cloud route guard (#35040) landed, so tests/test_classic_cloud_routes.py went red on base. #35160 adds keep: allowlist entries for that file, like the ones #34982 added for cmux-cloud-config.

lawrencecchen · 2026-11-04T09:07:17Z

Lead: after this PR merged, the feat tip does not compile on macOS: crates/cmux-tui/src/cli/cloud_environment/relaunch.rs:41:45: error: type annotations needed (event.data == libc::ESRCH as _). Fix PR #35172 casts to libc::intptr_t.

lawrencecchen · 2026-11-04T09:16:12Z

Leo: this PR (2a10af8) made the feat-cmux-next Rust panic ratchet red: cmux-tui: clippy::indexing_slicing 837 > baseline 831. The 6 new rows are the serde_json Value index reads and writes in cmux-tui/src/cli/cloud_environment.rs (value["name"], value["restart_required"], value["restart_scheduled"], and three value[..] = Value::Bool(..)). #35180 changes them to get(..) and cmux_json::JsonSet::set, with the same behavior. For new code, use v.get("key") to read and v.set("key", x) to write (plans/cmux-next/rust-panic-free.md).

…psible_if, from #35133) 2a10af8 (#35133) added a nested if let / if in Resolver::set in cmux-cloud-environment/src/lib.rs, which clippy -D warnings rejects (collapsible_if). It is now one let chain, as clippy suggests: the same two conditions in the same order, the same early return. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…te guard (#35160) #35133 added cmux-tui/crates/cmux-cloud-environment/src/lib.rs with the cmux.com and cmux-staging origins after #35040 landed the guard, so tests/test_classic_cloud_routes.py is red on base. Add keep: entries like #34982's for cmux-cloud-config. Agent-Session: https://cmux.com/deeplink/agent?id=aid-86478c59962584e11925 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cmux-bot[bot] <348531757+cmux-bot[bot]@users.noreply.github.com>

…5133) (#35172) The feat tip does not compile: crates/cmux-tui/src/cli/cloud_environment/relaunch.rs:41:45: error: type annotations needed (tip watcher, STATUS 11474). #35133 (2a10af8) compares kevent.data with `libc::ESRCH as _`; the cast target is ambiguous. kevent.data is intptr_t on macOS, so cast to libc::intptr_t. No behavior change.

- cloud help lists the offered preview-share and preview-revoke verbs (#34460), with en and ja rows; help_lists_exactly_the_offered_cloud_verbs and cloud_help_lists_every_offered_cloud_action were red. - quick_start_commands_parse skips the BACKEND section's cmux cloud env lines, as it skips the secret and client-session sections: #35133 put them beside SECRETS as a usage pattern (env set local|dev|...), not as quick-start commands, and cloud_environment.rs tests that grammar. The third red, clippy collapsible_if in cmux-cloud-environment (#35133), is in landq entries 0ea80ae (a964) and cf0afc5 (a968). Red on tip: cmuxterm-hq run 41803875674.

… indexing_slicing 841 > 831) (#35180) * base red: cloud env reads and writes its JSON reply with get and set (panic ratchet, from #35133) cmux-tui clippy::indexing_slicing went 831 to 837 at 2a10af8 (#35133): cli/cloud_environment.rs read value["name"], value["restart_required"] and value["restart_scheduled"] and wrote three keys with value[..] = x. The reads now use get(..) (a missing key reads as before: no name prints unknown, no flag is false); the writes use cmux_json::JsonSet::set on the serialized Selection (an object, so set inserts exactly as the index write did). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * base red: code mode reads the wrap_up tool name and box with get (panic ratchet, from #34360) 9642629 (#34360) added three cmux-tui clippy::indexing_slicing rows in cli/mcp/code_mode.rs: t["name"] == WRAP_UP in descriptors and two answered["value"] reads in exec_mode. They now use get(..): a tool with no string name does not match (as Null != WRAP_UP did), and the box is kept only when the call's value is an object, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * base red: cloud environment set collapses its nested if (clippy collapsible_if, from #35133) 2a10af8 (#35133) added a nested if let / if in Resolver::set in cmux-cloud-environment/src/lib.rs, which clippy -D warnings rejects (collapsible_if). It is now one let chain, as clippy suggests: the same two conditions in the same order, the same early return. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * base red: the cloud environment reader passes the bundle id without a borrow (clippy needless_borrow, from #35133) 2a10af8 (#35133) passed &bundle (a &&str) to Resolver::new in cmux-tui/src/cloud_environment.rs, which clippy -D warnings rejects (needless_borrow). It now passes bundle, a &str: the same value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * base red: link sync reads a too-large folder's stat kind and revision with get (panic ratchet, from #35138) f26eebe (#35138) added two cmux-tui clippy::indexing_slicing rows in link/sync_cli.rs (Listings::entry): stat["kind"] and stat["revision"]. The tip went 839 to 841 with them (tip watcher, 24f3425). They now read with get(..): a missing or non-string key gives the same empty kind and None revision as the Null index read did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * base red: a link sync test moves home into its FsService roots (clippy redundant_clone, from #35149) 4ce3393 (#35149) added Roots::new([home.clone()]) in cmux-tui/tests/link_sync.rs; the test does not use home after it, so clippy -D warnings rejects the clone (redundant_clone). It now moves home: the same roots. Test code only; no panic ratchet effect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

… it by its push paths (red) feat-cmux-next is to require 'clippy (changed cmux-tui packages)': #35133 and #35149 merged with it red because no check was required. A path-filtered required check never reports on other pull requests and leaves them pending, so the workflow must run on each one and skip its jobs when no push path changed.

…cloud env` lines; they parse in cloud_environment (#35557) #35133 added `cmux cloud env get` and `cmux cloud env set local|dev|preview-N|staging|prod` to cloud help's outro. This CLI runs them itself (cloud_environment.rs), like the secret and client-session lines the quick-start check already leaves out, so that check counted 12 commands for its 10 and went red on feat. It now leaves them out too, and cloud_environment's new the_help_env_lines_parse checks that both lines (every named environment of `set`) parse.

lawrencecchen · 2026-11-04T15:52:17Z

Base red from this PR: cloud help's quick-start check counted the two new cloud env lines. Fix in #35557: that check leaves them out (this CLI runs them itself), and a new cloud_environment test checks both lines parse.

(BASE RED SUITE for the cmux-next Performance Lead; nothing to do unless you disagree with the fix.)

teamleaderleo and others added 2 commits November 4, 2026 01:26

feat(cloud): resolve runtime environments per NEXT app bundle

48c1487

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7f47f1f7d409b2d65458

fix(cloud): declare selection root and isolate relaunch descriptors

d6618f4

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7f47f1f7d409b2d65458

teamleaderleo temporarily deployed to ci-routing-agent November 4, 2026 08:30 — with GitHub Actions Inactive

github-actions Bot added the risk:high Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026

Harden runtime Cloud selection recovery and relaunch

ab798cd

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7f47f1f7d409b2d65458

teamleaderleo merged commit 2a10af8 into feat-cmux-next Nov 4, 2026
176 of 197 checks passed

teamleaderleo deleted the lane/cloud-runtime-environment branch November 4, 2026 08:47

teamleaderleo mentioned this pull request Nov 4, 2026

cmux-cloud-config: NEXT Cloud's config, auth and VM agent-key rules in Rust, over the app FFI and in the cmux vm CLI (step A) #34982

Merged

teamleaderleo had a problem deploying to ci-routing-agent November 4, 2026 08:56 — with GitHub Actions Error

teamleaderleo mentioned this pull request Nov 4, 2026

ci: allowlist cmux-cloud-environment origins in the classic Cloud route guard #35160

Merged

lawrencecchen mentioned this pull request Nov 4, 2026

base red: relaunch.rs names the kevent data type (compile red from #35133) #35172

Merged

This was referenced Nov 4, 2026

cmux-tui: a workspace commit journals only the workspaces the journal does not state (#32408) #34959

Merged

base red: panic ratchet rows from #35133, #34360 and #35138 (cmux-tui indexing_slicing 841 > 831) #35180

Merged

lawrencecchen mentioned this pull request Nov 4, 2026

Agent pane: agents end a turn with a wrap_up next-step box (recap, question, answer buttons) #34360

Merged

lawrencecchen mentioned this pull request Nov 4, 2026

base red: arch app_lines from #34460 #35181

Merged

teamleaderleo mentioned this pull request Nov 4, 2026

cmux-cloud-environment: collapse nested if (clippy base red) #35222

Merged

lawrencecchen mentioned this pull request Nov 4, 2026

fix(cmux-tui-core): no frame passes a key the input port holds; only the person's keys answer before the write (R-DAEMON-STATE S1.6b) #35082

Merged

teamleaderleo mentioned this pull request Nov 4, 2026

fix(next): follow up window motion pacing and scale changes #35166

Open

lawrencecchen mentioned this pull request Nov 4, 2026

base red: fs_wire deflate over-size test panics with BrokenPipe on macOS #35306

Merged

This was referenced Nov 4, 2026

docs(ci): feat-cmux-next requires clippy (changed cmux-tui packages) #35462

Merged

base red: cloud help quick-start check leaves out the local cloud env lines; they parse in cloud_environment (from #35133) #35557

Merged

lawrencecchen mentioned this pull request Nov 5, 2026

base red: classic Cloud routes guard after #35284 #36090

Merged

Navigation Menu

Repository navigation

feat(cloud): select NEXT backend at runtime in Rust - #35133

feat(cloud): select NEXT backend at runtime in Rust#35133
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/cloud-runtime-environment

teamleaderleo commented Nov 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 4, 2026 •

edited

Loading

Uh oh!

blacksmith-sh Bot commented Nov 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

teamleaderleo commented Nov 4, 2026

Uh oh!

lawrencecchen commented Nov 4, 2026

Uh oh!

lawrencecchen commented Nov 4, 2026

Uh oh!

lawrencecchen commented Nov 4, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

teamleaderleo commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Observed / Not run

Uh oh!

github-actions Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blacksmith-sh Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failures

Uh oh!

Uh oh!

teamleaderleo commented Nov 4, 2026

Uh oh!

lawrencecchen commented Nov 4, 2026

Uh oh!

lawrencecchen commented Nov 4, 2026

Uh oh!

lawrencecchen commented Nov 4, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

teamleaderleo commented Nov 4, 2026 •

edited

Loading

github-actions Bot commented Nov 4, 2026 •

edited

Loading

blacksmith-sh Bot commented Nov 4, 2026 •

edited

Loading