Skip to content

cmux-cloud-environment: collapse nested if (clippy base red) - #35222

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/cloud-env-collapsible-if
Nov 4, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/cloud-env-collapsible-if

Conversation

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Fixes the clippy::collapsible_if base red in cmux-cloud-environment (from #35133), which fails cargo clippy -D warnings for every crate that depends on it, acpmux included.

Folds the nested if let ... { if ... } into one let-chain (edition 2024). No behaviour change.

Risk: none; a pure refactor of one condition.

Agent session: agent session

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 09e4d46: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35222 -f ref=fix/cloud-env-collapsible-if -f platform=macos -f backend_mode=local

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-sonnet-5-5): SHIP at 09e4d46
Same short-circuit order, bindings and return body; workspace edition 2024 / rust-version 1.91 allows let-chains.
Follow-ups: none

This branch had an error being deployed

1 failed and 2 inactive deployments
artifacts — 09e4d466 Deployed Nov 4, 2026 by teamleaderleo via publish to R2 #111073
sentry-dsyms — 09e4d466 Deployed Nov 4, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #111073
ci-routing-agent — 09e4d466 Deployed Nov 4, 2026 by teamleaderleo via cmux-tui tree preflight #111073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant