Skip to content

base red: relaunch.rs names the kevent data type (compile red from #35133) - #35172

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red/relaunch-esrch
Nov 4, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red/relaunch-esrch

Conversation

@lawrencecchen

Copy link
Copy Markdown
Contributor

Summary

The feat tip does not compile (tip watcher, STATUS 11474): crates/cmux-tui/src/cli/cloud_environment/relaunch.rs:41:45: error: type annotations needed. #35133 (2a10af8) compares kevent.data with libc::ESRCH as _, and the cast target is ambiguous. kevent.data is intptr_t on macOS, so the cast now names libc::intptr_t. No behavior change.

Observed / Not run

  • Ran: prepush gate, no new violations. Fleet app compile check (includes cmux-tui on macOS): job id in a comment below.
  • Not run: the relaunch path (its behavior is unchanged; one cast).

Changelog

none

…5133)

The feat tip does not compile: crates/cmux-tui/src/cli/cloud_environment/relaunch.rs:41:45:
error: type annotations needed (tip watcher, STATUS 11474). #35133 (2a10af8)
compares kevent.data with `libc::ESRCH as _`; the cast target is ambiguous. kevent.data
is intptr_t on macOS, so cast to libc::intptr_t. No behavior change.
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 05ba3d5: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35172 -f ref=base-red/relaunch-esrch -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 4, 2026
@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (claude-reviewer-35172): SHIP at 05ba3d5

  • Diff: one line in cmux-tui/crates/cmux-tui/src/cli/cloud_environment/relaunch.rs (event.data == libc::ESRCH as _ -> as libc::intptr_t). No other file changes. Parent a68b50f is on feat-cmux-next; the feat tip (4590112) still has the ambiguous as _.
  • Type: cmux-tui/Cargo.lock pins one libc, 0.2.189. In its src/unix/bsd/apple/mod.rs, struct kevent has pub data: intptr_t (intptr_t = isize), and ESRCH: c_int = 3. The cast is well typed and gives the same value as the intent (3 as isize). No behavior change.
  • Scope: the changed code is in after_exit under #[cfg(target_os = "macos")]. The non-macOS stub does not change, so no other target is affected.
  • Compile: fleet job f813810f4393ec2a71cf3590 at this head is done. Its step "cmux-tui (cargo check for macOS)" checked cmux-tui v1.0.0 and finished (Finished release profile ... in 57.39s). Both receipts (app, cmux-tui) say "ok": true.

Observed / Not run

Observed: I read the diff, Cargo.lock, the libc 0.2.189 source, and the fleet job status and log. Not run: no tests ran, and none apply to a type annotation fix.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 4, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 4, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpkp6mez_d/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmptyhl1j1s/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@lawrencecchen
lawrencecchen merged commit a40afcd into feat-cmux-next Nov 4, 2026
232 of 239 checks passed
@lawrencecchen
lawrencecchen deleted the base-red/relaunch-esrch branch November 4, 2026 09:37

This branch was previously deployed

3 inactive deployments
ci-routing-agent — 05ba3d5c Deployed Nov 4, 2026 by github-actions[bot] via cmux-next macOS placement #69522
artifacts — 05ba3d5c Deployed Nov 4, 2026 by lawrencecchen via publish tree-addressed cmux-tui #110846
sentry-dsyms — 05ba3d5c Deployed Nov 4, 2026 by lawrencecchen via upload cmux-tui dSYMs to Sentry #110846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant