Repository navigation
base red: relaunch.rs names the kevent data type (compile red from #35133) - #35172
Merged
Merged
Conversation
…5133) The feat tip does not compile: crates/cmux-tui/src/cli/cloud_environment/relaunch.rs:41:45: error: type annotations needed (tip watcher, STATUS 11474). #35133 (2a10af8) compares kevent.data with `libc::ESRCH as _`; the cast target is ambiguous. kevent.data is intptr_t on macOS, so cast to libc::intptr_t. No behavior change.
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Contributor
Author
|
Review (claude-reviewer-35172): SHIP at 05ba3d5
Observed / Not runObserved: I read the diff, Cargo.lock, the libc 0.2.189 source, and the fleet job status and log. Not run: no tests ran, and none apply to a type annotation fix. |
|
Found 6 test failures on Blacksmith runners: Failures
|
lawrencecchen
temporarily deployed
to
artifacts
November 4, 2026 09:18 — with
GitHub Actions
Inactive
lawrencecchen
temporarily deployed
to
sentry-dsyms
November 4, 2026 09:18 — with
GitHub Actions
Inactive
lawrencecchen
temporarily deployed
to
artifacts
November 4, 2026 09:33 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
The feat tip does not compile (tip watcher, STATUS 11474):
crates/cmux-tui/src/cli/cloud_environment/relaunch.rs:41:45: error: type annotations needed. #35133 (2a10af8) compareskevent.datawithlibc::ESRCH as _, and the cast target is ambiguous.kevent.dataisintptr_ton macOS, so the cast now nameslibc::intptr_t. No behavior change.Observed / Not run
Changelog
none