Repository navigation
fix(next): follow up window motion pacing and scale changes - #35166
teamleaderleo wants to merge 9 commits into
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-533a332d2819104dea9f
93d564b to
8e77438
Compare
|
Review (subagent claude-opus-5-5 medium): SHIP at 8e77438 Read the full diff (4 files, +37/-11).
Compile: the fleet compile at this head passed the app package. Its only failure was the cmux-tui crate ( Follow-ups (non-blocking):
|
…-motion-followups
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-533a332d2819104dea9f
|
Review (codex, router-review): SHIP at 04d4991 Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 1. They land as checklist items in this PR's one follow-up tracking issue in this repo ( SHIP at 04d4991 Visual verdict: no images; Leo tries the build The focused motion tests (17) and Python syntax checks pass.
Follow-ups:
|
A newer verdict blocks 00da512 (no independent SHIP at the head).
Summary
Fix forward the merged window motion work: restore synchronous content display after the same-harness A/B showed no pacing win, require the shared window-resize minimum of 20 intermediate display frames, and relayout titlebar chrome when a window moves between displays with a new backing scale.
This follows #35063 and #35064 and closes their confirmed follow-ups in #35097. The capture follow-up remains tracked in #35098.
Performance
The measured result did not establish a consistent benefit for deferred display, so this follow-up returns to the synchronized presentation path. No duplicate perf run was dispatched.
Validation
python3 -I scripts/cmux-next/tests/test_window_zoom_motion.py(17 passed)8bdabc5b1818168834ece0f6andf669c21e7814c2fa8ea9dec5Changelog
agent-identity footer --repo manaflow-ai/cmux
🤖 Generated with Codex
Agent session: agent session
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Follows the merged window motion work: restores synchronous zoom content display, enforces the shared 20-intermediate-frame window pacing floor, and relayouts titlebar chrome when a window moves between displays with a new backing scale.
display: trueso content is painted with each frame; the deferred variant showed no consistent pacing benefit and could leave a late content update behind the window motion.Written for commit 578f67e. Summary will update on new commits.