Repository navigation
Agent pane: transcript rows light only their chevron on hover; the live line's total keeps one tone - #34523
Conversation
…ve line's total keeps one tone Leo, 2026-11-03: "this thing appears/lights up on hover for no reason!?" on the "2 background updates" row brightening edge to edge under the pointer. - Activity rows (background updates, subagent, messaging, inbox) and DisclosureRow lines keep their words at rest tone under hover, press and focus; only the chevron lifts, and only on a line that is a button. - The live Thinking line (a div, no action) no longer lifts; only Worked for's button does. - "· 12m 9s total": the words around the time read at the time's dim tone. - webviews/test/transcript-row-hover-scope.test.ts guards all three. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Stale: these images are of Gallery before/after for
States
Pick other states with a Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on ae81bca to compare; do not merge until green; see lane-rules Shipped in:
|
…ne; comment order Review follow-ups on #34523: the tool rows' :focus-within lift skips activity rows (a click leaves them focused), with a lint for it; the total's comment moves back above its rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
…s lint can fail Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
|
Review (subagent claude-opus-5-5 medium, correctness): SHIP at 095228a |
…ude/background-row-hover-one-tone
…er dot; left-edge test per state Leo, 2026-11-03: "this aint aligned also the total is redundant did we remove this yet", "same here it's annoying to look at", and "this is also misaligned with the left text right now for some reason... there's sometimes weird indenting?". - The turn's clock after the dot has no word: "Ran cat x 0s · 39s", "Thinking · 1m 51s". turn.live.total leaves the catalog. - Each dot stands the count's 4px gap on both sides, and the counts read in the time's dim tone. - Gallery agent-pane.long-subagent-wait gains thinking and ran-command variants. - transcript-live-line-left-edge-browser.test.ts: in every live state the line starts on the reply's text column and its dots are evenly spaced. - The hover-scope lint splits nested selector lists and checks the live line's gap and tone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
|
Found 6 test failures on Blacksmith runners: Failures
|
…r comments drop "total" Codex review of #34523: SubagentDoneLine draws its chevron beside the button, which the button-scoped chevron rule missed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
|
Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over. From the owner of Leo's ask cluster c-3e341b3e71 (asks-router). Your cmux#34523 already covers it, so I'm not opening a duplicate PR. |
|
Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over. Leo-ask: ask-147c151a65 (cluster c-147c151a65) is this PR's work: it drops |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
…ude/background-row-hover-one-tone # Conflicts: # webviews/src/agent-session/acpmux/conversation/LongSubagentWait.gallery.ts # webviews/src/agent-session/acpmux/conversation/Thinking.tsx # webviews/src/agent-session/acpmux/conversation/conversation.css # webviews/test/transcript-live-line-state.test.tsx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (codex gpt-6-astra high, router-review): SHIP at 2f93df4
|
… lint) (#35155) #34523's test used /^button\.cv-worked/.test(lit); oxlint's prefer-string-starts-ends-with fails web lint (fast) on it. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… lint) (#35155) #34523's test used /^button\.cv-worked/.test(lit); oxlint's prefer-string-starts-ends-with fails web lint (fast) on it. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 174b2f8) Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf
* ui: compact shared tooltip placement and hierarchy Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0e9f3e645685b2cfca3a * ui: align tooltip edge and max width tokens Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0e9f3e645685b2cfca3a * fix(ui): keep tooltip width and anchor on the shared scale Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * Preserve rich hover card padding proportions Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * Align tooltip geometry assertions with scaled grid Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * fix(webviews): use startsWith in transcript row hover scope test (web lint) (#35155) #34523's test used /^button\.cv-worked/.test(lit); oxlint's prefer-string-starts-ends-with fails web lint (fast) on it. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 174b2f8) Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * Check tooltip centering inside the compact edge inset Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * Wait for the visible tooltip in gallery captures Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf --------- Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…35009) Follow-up from the Codex review of #34523: SubagentDoneLine's button is disabled with no navigation context, and its sibling chevron still lifted. Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cmux-bot[bot] <348531757+cmux-bot[bot]@users.noreply.github.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, 2026-11-03: "this thing appears/lights up on hover for no reason!?", on the transcript line "2 background updates ⌄" (with "Thinking · 12m 9s total" under it) brightening edge to edge under the pointer.
A hover highlight covers only its own control, never the whole row (design spec: leo-workspace
design/chat-transcript.md, surfacechat-transcript).What changes
TranscriptActivityRow: background updates, background turns, subagent, messaging and inbox lines): the words keep their rest tone under hover, press and focus. Only the chevron lifts, and only on a line that is a button that opens something. A plain line with nothing behind it no longer lights at all.DisclosureRowon the shared shell: subagent, inbox and subsession lines) follow the same rule: only the toggle's chevron lifts, not the line's words.div.cv-worked, no action): no longer lifts on hover. The "Worked for" button keeps its own lift.:focus-withinlift now skips.cv-agent-activity__control, so a clicked row doesn't keep its words lit while it holds focus. Activity buttons join the shared inset focus ring, so keyboard focus is still visible..cv-worked__totalnow uses the time's dim tone, so the count reads as one tone.Regressed by
48f4dfb0fa9, "unify transcript activity rows"), which added.cv-agent-activity-row:is(:hover, …) > .cv-agent-activity__control { color: var(--cv-text) }(found withgit log -S).7a04176ce8d), which added.cv-worked__totalwith no colour of its own.Guards
webviews/test/transcript-row-hover-scope.test.ts, a static CSS lint:TranscriptActivityRow.css, a state rule (:hover,:active,:focus*) that changes colour, opacity or filter may light only a chevron (.cv-agent-activity__chevronunderbutton.cv-agent-activity__control, or.cv-rotorunder.cv-disclosure__toggle).conversation.cssandTranscriptActivityRow.css, no state rule lights a.cv-workedunless it isbutton.cv-worked..cv-tool…:focus-withinrule inconversation.csslights an activity row's words..cv-worked__totalisvar(--cv-text-dim).activityTone.test.tsandTranscriptActivityRow.test.tsxwere updated to match.Risk: CSS only, confined to transcript row hover tones. Small, so it takes the light path.
Live line (folded in from Leo's later asks, 2026-11-03)
Leo: "this aint aligned also the total is redundant did we remove this yet", "same here it's annoying to look at", and "this is also misaligned with the left text right now for some reason... there's sometimes weird indenting?"
turn.live.totalis removed from the catalog (catalog numstat vs base: +2/-140, only that key plus two translator comments).8557b1002b6) already starts the live line on the reply's text column, and Leo's capture predates it.webviews/test/transcript-live-line-left-edge-browser.test.tsnow checks the left edge in every state (Thinking, a finished command, a finished step, Writing, Waiting on 3 subagents) in light and dark, along with even dot spacing. It passed on the fleet (14/14 with transcript-status-text-column).agent-pane.long-subagent-waitgainsthinkingandran-commandvariants.7a04176ce8d); the indent came from Agent chat: every status row's words on one column; session names read as words #33157, which Agent pane: the live Thinking line starts on the icon column and stays the last row #34370 undid.test/transcript-spacing-kinds.test.ts:248, is a base red that base red: webviews design tokens (What's New brief) and the transcript spacing test's after() helper #34577 already fixed; this PR doesn't touch that file.Follow-ups, not in this PR: tool-run summary lines (
.cv-tool.is-run:hover > .cv-tool__text) and the Worked for button still lift their whole words on hover. They open something, so they are outside this rule's "no action" scope; whether they should also light only their chevron is left for the surface spec.Agent session: agent session
🤖 Generated with Claude Code