Skip to content

fix(webviews): web lint, startsWith in transcript row hover scope test - #35155

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix--base-red-web-lint-startswith
Nov 4, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix--base-red-web-lint-startswith

Conversation

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Fixes the base red in cmux-next web lint / web lint (fast) (first red at 1915371): vp lint reports Prefer String#startsWith over a regex with a caret at webviews/test/transcript-row-hover-scope.test.ts:82, added by #34523. The check !/^button\.cv-worked/.test(lit) becomes !lit.startsWith("button.cv-worked"), which means the same thing.

Small fix: one line in one test file.

Agent session: agent session

🤖 Generated with Claude Code

… lint)

#34523's test used /^button\.cv-worked/.test(lit); oxlint's
prefer-string-starts-ends-with fails web lint (fast) on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review a702293: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35155 -f ref=fix--base-red-web-lint-startswith -f platform=macos -f backend_mode=local

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 4, 2026

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
nightly cmux-tui resolve/nightly cmux-tui resolve View Logs
the short nightly decide gate must use the pooled Linux route with a Blacksmith fallbac
k/
the short nightly decide gate must use the pooled Linux route with a Blacksmith fallbac
k
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus medium): SHIP at a702293

Checked: lit is a string, and !lit.startsWith("button.cv-worked") is the same test as !/^button\.cv-worked/.test(lit); no other changes. Fleet run at this head: vp lint 0 warnings and 0 errors, fmt clean, the test file passes 4/4.
Follow-ups: none

@teamleaderleo
teamleaderleo merged commit 174b2f8 into feat-cmux-next Nov 4, 2026
121 of 124 checks passed
@teamleaderleo
teamleaderleo deleted the fix--base-red-web-lint-startswith branch November 4, 2026 09:37
teamleaderleo added a commit that referenced this pull request Nov 4, 2026
… lint) (#35155)

#34523's test used /^button\.cv-worked/.test(lit); oxlint's
prefer-string-starts-ends-with fails web lint (fast) on it.

Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 174b2f8)
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf
teamleaderleo added a commit that referenced this pull request Nov 4, 2026
* ui: compact shared tooltip placement and hierarchy

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-0e9f3e645685b2cfca3a

* ui: align tooltip edge and max width tokens

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-0e9f3e645685b2cfca3a

* fix(ui): keep tooltip width and anchor on the shared scale

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf

* Preserve rich hover card padding proportions

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf

* Align tooltip geometry assertions with scaled grid

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf

* fix(webviews): use startsWith in transcript row hover scope test (web lint) (#35155)

#34523's test used /^button\.cv-worked/.test(lit); oxlint's
prefer-string-starts-ends-with fails web lint (fast) on it.

Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 174b2f8)
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf

* Check tooltip centering inside the compact edge inset

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf

* Wait for the visible tooltip in gallery captures

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf

---------

Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant