Repository navigation
fix(webviews): web lint, startsWith in transcript row hover scope test - #35155
Conversation
… lint) #34523's test used /^button\.cv-worked/.test(lit); oxlint's prefer-string-starts-ends-with fails web lint (fast) on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
Owned by an agent session · session |
|
Found 2 test failures on Blacksmith runners: Failures
|
|
Review (subagent opus medium): SHIP at a702293 Checked: |
… lint) (#35155) #34523's test used /^button\.cv-worked/.test(lit); oxlint's prefer-string-starts-ends-with fails web lint (fast) on it. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 174b2f8) Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf
* ui: compact shared tooltip placement and hierarchy Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0e9f3e645685b2cfca3a * ui: align tooltip edge and max width tokens Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0e9f3e645685b2cfca3a * fix(ui): keep tooltip width and anchor on the shared scale Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * Preserve rich hover card padding proportions Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * Align tooltip geometry assertions with scaled grid Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * fix(webviews): use startsWith in transcript row hover scope test (web lint) (#35155) #34523's test used /^button\.cv-worked/.test(lit); oxlint's prefer-string-starts-ends-with fails web lint (fast) on it. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 174b2f8) Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * Check tooltip centering inside the compact edge inset Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf * Wait for the visible tooltip in gallery captures Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf --------- Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes the base red in cmux-next web lint / web lint (fast) (first red at 1915371):
vp lintreportsPrefer String#startsWith over a regex with a caretatwebviews/test/transcript-row-hover-scope.test.ts:82, added by #34523. The check!/^button\.cv-worked/.test(lit)becomes!lit.startsWith("button.cv-worked"), which means the same thing.Small fix: one line in one test file.
Agent session: agent session
🤖 Generated with Claude Code