Repository navigation
ui: compact shared tooltip previews - #35205
Conversation
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0e9f3e645685b2cfca3a
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: Shipped in:
|
|
Found 10 test failures on Blacksmith runners: Failures
|
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-0e9f3e645685b2cfca3a
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (codex primary integration review): BLOCK at 3199e00
Review (codex primary integration): BLOCK at 3199e00
[blocking] F1 correctness outcome:pending — webviews/src/ui/titleTooltips.ts:76 still references EDGE after the constant was renamed to UI_TOOLTIP_EDGE. This fails type checking and throws when positioning title tooltips. Replace the remaining vertical-position references and verify the focused positioning tests at the new head.
Visual verdict: no captures inspected at this head. The owner is already fixing F1.
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf
|
Finding outcome: review-5766551425/F1 fixed 275dfbd |
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf
… lint) (#35155) #34523's test used /^button\.cv-worked/.test(lit); oxlint's prefer-string-starts-ends-with fails web lint (fast) on it. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 174b2f8) Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf
|
Review (subagent, correctness, Claude Opus 5.5 medium): SHIP at f7dcf6f Scope: I found no blocking correctness bugs. What I checked:
Notes that do not block:
Not verified: the webview typecheck and the react-apps-check shards were still pending when I reviewed. |
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf
|
Review (subagent, correctness, Claude Opus 5.5 medium): SHIP at 48c6df2 Delta review of f7dcf6f..48c6df2 (2 commits, 2 files, +7 -2). No production code changed: only
|
…me table (#35440) Two cmux-next checks have been red on feat-cmux-next since this morning: - Web bundle key inputs: #35205 made webviews/src/ui/tooltipTokens.ts import schemas/design-scale/design-scale.json, which the bundle key hashes but the publish workflow's push paths and cmux_next_route.py BUNDLE_INPUTS did not list. Both lists now name it. - Default cursor: #34589 added NSCursor+DebugName.swift, a DEBUG-only table that names the standard cursors (pointingHand among them) for debug.cursor. It sets no cursor; it goes on the allowlist with that reason, like DebugTerminalLinks.swift. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… build (#35450) * try-pr.sh: try a pull request the cheapest way, live when it needs no build scripts/cmux-next/try-pr.sh PR reads the PR's diff with git and sorts it with live_apply.py (the rules from the 8,315-PR live-apply study). A web-only PR goes straight to web-overlay.sh follow, so the running app hot-reloads it with no build; a CI/tests/docs PR is nothing to try; a daemon, Swift or resource change says why it needs a new binary and, with --build, requests the fleet dev build tagged pr-N. Tests: python3 -m unittest scripts/cmux-next/tests/test_live_apply.py (10 pass); dry runs on #35314 (rebuild), #35408 (no-app), #35206 and #35205 (web-live). Leo-ask: ask-ffdcb76e34 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f164a6206bf2ef9c6b7d * try-pr.sh: lockfiles, bundled scripts and web config are not no-app; honest doc numbers Review follow-ups on #35450: the extension rule now runs after the web, resource and Rust rules, the doc no longer counts swift-live as needing no binary, and --port with no value prints usage. Leo-ask: ask-ffdcb76e34 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f164a6206bf2ef9c6b7d --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo: “i think our hover previews are generally pretty ass” and “there's just tons of design systems related stuff for spacing guttters icons etc whatever like we don't yet feel "designed" yet nawmean”.
Tooltips now prefer a compact bubble above their control, with caption text, an emphasized title and a dimmer second-line description. A truncated label still appears in full, wrapping within the same 320px maximum instead of forcing the source row's width. The 4px anchor gap, viewport inset, padding and maximum width follow the shared grid and interface scale. Explicit side choices, shortcuts, rich React content, colors, glass, and existing hover delay/fade behavior remain available.
Spec: leo-workspace design/overlay-surfaces.md; mapped in .github/design-surfaces.json.
References: cmux/live/transcript-hover-preview-fork-tooltip, cmux/live/transcript-hover-preview-copy-response, claude/live/transcript-fork-from-here-tooltip.
Gallery: ui.tooltip/above-compact, below-compact, and title-detail; selected above-first title/detail. Final fleet matrix run 41815709481 captured 24 Chromium cases (dark/light, compact/comfortable, interface scales 1 and 1.25); all cases rendered with ready=1. The gallery play now waits for the tooltip to become visible before capture.
Validation:
Follow-ups: #35268 tracks unused tooltipWidth arguments, popup-document scale handling, and a long-title gallery state.
🤖 Generated with Codex
Agent session: https://cmux.com/deeplink/agent?id=aid-b605b496e2aad0871fdf