Repository navigation
Agent pane: the live line drops "total" and evens the gap around its dot - #34866
Conversation
…n each side Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-106f577270d490a8a7db
Leo, 2026-11-04: "the total is redundant", "there's no point to say total",
and on the live line's "2s · 15s total": "same here it's annoying to look at".
- Past the first step the turn's clock follows a step's own time after a dot
("Ran grep 2s · 15s"); with no own time it stands beside the label alone
("Waiting on 2 subagents 1h 24m"). turn.live.total is gone.
- .cv-worked__count's margin takes back the line's grid gap, so every "·" on a
worked or live line sits 4px from both sides (it was 10px before, 4px after).
Leo-ask: ask-5c65177e87
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-106f577270d490a8a7db
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules Shipped in:
|
|
Review (subagent claude-opus-5-5 medium): SHIP at 4357ef3 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa
…ve line's total keeps one tone (#34523) * Agent pane: transcript rows light only their chevron on hover; the live line's total keeps one tone Leo, 2026-11-03: "this thing appears/lights up on hover for no reason!?" on the "2 background updates" row brightening edge to edge under the pointer. - Activity rows (background updates, subagent, messaging, inbox) and DisclosureRow lines keep their words at rest tone under hover, press and focus; only the chevron lifts, and only on a line that is a button. - The live Thinking line (a div, no action) no longer lifts; only Worked for's button does. - "· 12m 9s total": the words around the time read at the time's dim tone. - webviews/test/transcript-row-hover-scope.test.ts guards all three. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa * Agent pane: a clicked activity row's focus keeps its words at rest tone; comment order Review follow-ups on #34523: the tool rows' :focus-within lift skips activity rows (a click leaves them focused), with a lint for it; the total's comment moves back above its rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa * Agent pane: activity row buttons take the shared focus ring; the focus lint can fail Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa * Agent pane: the live line drops "total", keeps one gap and one tone per dot; left-edge test per state Leo, 2026-11-03: "this aint aligned also the total is redundant did we remove this yet", "same here it's annoying to look at", and "this is also misaligned with the left text right now for some reason... there's sometimes weird indenting?". - The turn's clock after the dot has no word: "Ran cat x 0s · 39s", "Thinking · 1m 51s". turn.live.total leaves the catalog. - Each dot stands the count's 4px gap on both sides, and the counts read in the time's dim tone. - Gallery agent-pane.long-subagent-wait gains thinking and ran-command variants. - transcript-live-line-left-edge-browser.test.ts: in every live state the line starts on the reply's text column and its dots are evenly spaced. - The hover-scope lint splits nested selector lists and checks the live line's gap and tone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa * Agent pane: a chevron beside its line's button still lifts; translator comments drop "total" Codex review of #34523: SubagentDoneLine draws its chevron beside the button, which the button-scoped chevron rule missed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa * test: the activity row chevron assertion matches the two-selector rule Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa * comments: the live line's clock wording follows #34866 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ns back on the scale (#35471) react-apps-check and the icon-scale check were red on feat-cmux-next d4336f3: - check-icon-scale: four new off-scale icons. TaskGoalStrip's Expand 15 -> 16 (#34516), the resuming Spinner 10 -> 12 (#34286, absolutely centred, so nothing moves), ExtraFolderList's remove glyph 10 -> 12 (#33242, a close mark is 12). - drawn-height-priority: the test cut App.tsx from flushDrawn to the observer; #34911 put reportRow and placeRowNow between them, which need refs the probe lacks. It now takes flushDrawn up to its own `}, []);`. The naive-guard mutation run still fails. - transcript-long-chat-updates: #34607 made a closed "Worked for" a step row, so the prose under it sits a run gap (16) away; the test still read the bare rowMark (24). model.ts's per-row mark is now one exported `gridMark`, used by layoutConversation and by the test, so they cannot drift again. - SentMessageGroup "a finished Claude turn": #35113 folds a finished Claude turn under one "Worked for" (it landed beside #34865's test). The test now checks the run is out of sight while the fold is closed and is one send-group line once opened. - agent-pane-working-counts (browser lane, CI only): #34866 dropped "total" from the live line; the two expectations read "Read app.ts 2m 9s" now. STARTING_READS typecheck/lint red was already fixed on base by #35409. Agent-Session: https://cmux.com/deeplink/agent?id=aid-8707001042ea634e8771 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Leo, 2026-11-04, on the transcript's live line ("Ran grep 2s · 15s total" under a running turn):
next to his asks on the same line: "the total is redundant" and "there's no point to say total".
Leo-ask: ask-5c65177e87
Reference: cmux-design-references
cmux/live/transcript-tool-line-total-dot-gapDesign spec: leo-workspace design/chat-transcript.md (surface chat-transcript)
What changes
turn.live.totalstring is removed..cv-workedis a flex row with an 8px grid gap between items, and.cv-worked__countadded its own 2px, so every "·" on a worked or live line had 10px before it and 4px after. The count's margin now takes the grid gap back (calc(4px - var(--grid-gap))): 4px on each side, on the live line, "Working for" and "Worked for".Regressed by: the "total" words and their dot came from #33248 (
git log -S cv-worked__total); the lopsided gap from.cv-worked__count'smargin-left: 2pxsitting on top of.cv-worked's grid gap.Overlap: #34523 (open) colours
.cv-worked__totaldim; this keeps that class on the remaining "· 15s" segment, so the two compose.Test
bun test test/transcript-live-line-dot-gap-css.test.ts: fails on base (margin-left: 2px), passes on the head.bun test test/transcript-live-line-state.test.tsx: expectations now read without "total" (fails on base, passes on head).Observed / Not run
bun test test/transcript- test/agent-pane-turn src/agent-session/acpmux/conversation(1390 pass, 0 fail);scripts/web-lint.sh(passes; the type-aware lint and type check are left to CI on this host).Risk: CSS and copy on one component's line, small.
Changelog
Changed: the agent's live line no longer says "total", and the dot between its counts is evenly spaced.
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Removes "total" from the agent's live line and evens the gap around its separator dot. Past the first step the line now reads "Ran grep 2s · 15s" instead of "15s total", and each dot sits 4px from both sides instead of 10px before and 4px after. The
turn.live.totalstring is removed.Written for commit 4357ef3. Summary will update on new commits.