Skip to content

Agent pane: the live line drops "total" and evens the gap around its dot - #34866

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/transcript-tool-line-dot-gap
Nov 4, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/transcript-tool-line-dot-gap

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Leo, 2026-11-04, on the transcript's live line ("Ran grep 2s · 15s total" under a running turn):

same here it's annoying to look at

next to his asks on the same line: "the total is redundant" and "there's no point to say total".

Leo-ask: ask-5c65177e87
Reference: cmux-design-references cmux/live/transcript-tool-line-total-dot-gap
Design spec: leo-workspace design/chat-transcript.md (surface chat-transcript)

What changes

  • No "total". Past the turn's first step the live line still keeps a step's own time apart from the turn's clock, but it no longer says "total": "Ran grep -n x 2s · 15s", "Thinking 8s · 7m 34s". With no own time the turn's clock stands beside the label like any other line, with no dot: "Waiting on 2 subagents 1h 24m 7s", "Running bun test 13s". The turn.live.total string is removed.
  • The dot's gap. .cv-worked is a flex row with an 8px grid gap between items, and .cv-worked__count added its own 2px, so every "·" on a worked or live line had 10px before it and 4px after. The count's margin now takes the grid gap back (calc(4px - var(--grid-gap))): 4px on each side, on the live line, "Working for" and "Worked for".

Regressed by: the "total" words and their dot came from #33248 (git log -S cv-worked__total); the lopsided gap from .cv-worked__count's margin-left: 2px sitting on top of .cv-worked's grid gap.

Overlap: #34523 (open) colours .cv-worked__total dim; this keeps that class on the remaining "· 15s" segment, so the two compose.

Test

  • bun test test/transcript-live-line-dot-gap-css.test.ts: fails on base (margin-left: 2px), passes on the head.
  • bun test test/transcript-live-line-state.test.tsx: expectations now read without "total" (fails on base, passes on head).

Observed / Not run

  • Ran: the two files above plus bun test test/transcript- test/agent-pane-turn src/agent-session/acpmux/conversation (1390 pass, 0 fail); scripts/web-lint.sh (passes; the type-aware lint and type check are left to CI on this host).
  • Not run: the gallery advisory capture and a DEV build. Leo tries the build.

Risk: CSS and copy on one component's line, small.

Changelog

Changed: the agent's live line no longer says "total", and the dot between its counts is evenly spaced.

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Removes "total" from the agent's live line and evens the gap around its separator dot. Past the first step the line now reads "Ran grep 2s · 15s" instead of "15s total", and each dot sits 4px from both sides instead of 10px before and 4px after. The turn.live.total string is removed.

Written for commit 4357ef3. Summary will update on new commits.

View guided diff Turn on auto-fix

teamleaderleo and others added 2 commits November 4, 2026 05:17
Leo, 2026-11-04: "the total is redundant", "there's no point to say total",
and on the live line's "2s · 15s total": "same here it's annoying to look at".

- Past the first step the turn's clock follows a step's own time after a dot
  ("Ran grep 2s · 15s"); with no own time it stands beside the label alone
  ("Waiting on 2 subagents 1h 24m"). turn.live.total is gone.
- .cv-worked__count's margin takes back the line's grid gap, so every "·" on a
  worked or live line sits 4px from both sides (it was 10px before, 4px after).

Leo-ask: ask-5c65177e87

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-106f577270d490a8a7db
@teamleaderleo teamleaderleo added leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:normal Risk tier (docs/ci/risk-tiers.md) labels Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 4357ef3: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34866 -f ref=lane/transcript-tool-line-dot-gap -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on 4357ef36e4 (run 41778483775 attempt 1): 1 code, 1 unknown.

Job Verdict Why
web / react-apps-base-check (4) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs composer-permission-pill.test.ts codex: permission control keeps the shared capsule geometry: failed (job)
  • seen on other PRs model-pick-prompt-focus.test.ts chromium: New Tab composer: a compact menu reopened before a pick's focus lands still closes to the ...: failed (job)
  • seen on other PRs model-pick-prompt-focus.test.ts webkit: New Tab composer: a compact menu reopened before a pick's focus lands still closes to the mo...: failed (job)
  • seen on other PRs new-tab-live-resize.test.ts webkit: the cards page follows a live resize: failed (job)
  • seen on other PRs new-tab-live-resize.test.ts webkit: the threads page follows a live resize: failed (job)
  • seen on other PRs agent-pane-working-counts.test.ts the line counts the subagents and background shells still running: failed (job)
  • seen on other PRs agent-pane-working-counts.test.ts with the tray on, the line counts nothing: the tray lists the same work: failed (job)
  • seen on other PRs new-tab-live-resize.test.ts webkit: the composer page follows a live resize: failed (job)
Matched log lines
web / react-apps-base-check (4): (fail) codex: permission control keeps the shared capsule geometry [1504.39ms]

Not re-run automatically: web / react-apps-base-check (4), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-base-check (4); NEW webview test reds: test/new-tab-live-resize.test.ts > webkit: the composer page follows a live resize; test/agent-pane-working-counts.test.ts > with the tray on, the line counts nothing: the tray lists the same work; test/agent-pane-working-counts.test.ts > the line counts the subagents and background shells still running; do not merge until green; see lane-rules
red: web / react-apps-check; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at 4357ef3
Checked the render branches (own time / no own time / waiting / retry / shimmer lit time), every .cv-worked__count parent (all direct children of a .cv-worked flex row, never first), and no remaining turn.live.total reference; focused tests and pane-english pass.
Follow-ups: [follow-up] .cv-worked__count uses physical margin-left (RTL); [follow-up] leftover "total" wording in the .cv-worked__own CSS comment and two test names.

@teamleaderleo
teamleaderleo merged commit 05057fc into feat-cmux-next Nov 4, 2026
181 of 195 checks passed
@teamleaderleo
teamleaderleo deleted the lane/transcript-tool-line-dot-gap branch November 4, 2026 05:21
teamleaderleo added a commit that referenced this pull request Nov 4, 2026
teamleaderleo added a commit that referenced this pull request Nov 4, 2026
…ve line's total keeps one tone (#34523)

* Agent pane: transcript rows light only their chevron on hover; the live line's total keeps one tone

Leo, 2026-11-03: "this thing appears/lights up on hover for no reason!?" on the
"2 background updates" row brightening edge to edge under the pointer.

- Activity rows (background updates, subagent, messaging, inbox) and DisclosureRow
  lines keep their words at rest tone under hover, press and focus; only the chevron
  lifts, and only on a line that is a button.
- The live Thinking line (a div, no action) no longer lifts; only Worked for's button does.
- "· 12m 9s total": the words around the time read at the time's dim tone.
- webviews/test/transcript-row-hover-scope.test.ts guards all three.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa

* Agent pane: a clicked activity row's focus keeps its words at rest tone; comment order

Review follow-ups on #34523: the tool rows' :focus-within lift skips activity rows (a click
leaves them focused), with a lint for it; the total's comment moves back above its rule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa

* Agent pane: activity row buttons take the shared focus ring; the focus lint can fail

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa

* Agent pane: the live line drops "total", keeps one gap and one tone per dot; left-edge test per state

Leo, 2026-11-03: "this aint aligned also the total is redundant did we remove this yet",
"same here it's annoying to look at", and "this is also misaligned with the left text right
now for some reason... there's sometimes weird indenting?".

- The turn's clock after the dot has no word: "Ran cat x 0s · 39s", "Thinking · 1m 51s".
  turn.live.total leaves the catalog.
- Each dot stands the count's 4px gap on both sides, and the counts read in the time's dim tone.
- Gallery agent-pane.long-subagent-wait gains thinking and ran-command variants.
- transcript-live-line-left-edge-browser.test.ts: in every live state the line starts on the
  reply's text column and its dots are evenly spaced.
- The hover-scope lint splits nested selector lists and checks the live line's gap and tone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa

* Agent pane: a chevron beside its line's button still lifts; translator comments drop "total"

Codex review of #34523: SubagentDoneLine draws its chevron beside the button, which the
button-scoped chevron rule missed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa

* test: the activity row chevron assertion matches the two-selector rule

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa

* comments: the live line's clock wording follows #34866

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-92fa78a91e29868c5eaa

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Nov 4, 2026
…ns back on the scale (#35471)

react-apps-check and the icon-scale check were red on feat-cmux-next d4336f3:

- check-icon-scale: four new off-scale icons. TaskGoalStrip's Expand 15 -> 16 (#34516),
  the resuming Spinner 10 -> 12 (#34286, absolutely centred, so nothing moves),
  ExtraFolderList's remove glyph 10 -> 12 (#33242, a close mark is 12).
- drawn-height-priority: the test cut App.tsx from flushDrawn to the observer; #34911
  put reportRow and placeRowNow between them, which need refs the probe lacks. It now
  takes flushDrawn up to its own `}, []);`. The naive-guard mutation run still fails.
- transcript-long-chat-updates: #34607 made a closed "Worked for" a step row, so the
  prose under it sits a run gap (16) away; the test still read the bare rowMark (24).
  model.ts's per-row mark is now one exported `gridMark`, used by layoutConversation
  and by the test, so they cannot drift again.
- SentMessageGroup "a finished Claude turn": #35113 folds a finished Claude turn under
  one "Worked for" (it landed beside #34865's test). The test now checks the run is out
  of sight while the fold is closed and is one send-group line once opened.
- agent-pane-working-counts (browser lane, CI only): #34866 dropped "total" from the
  live line; the two expectations read "Read app.ts 2m 9s" now.

STARTING_READS typecheck/lint red was already fixed on base by #35409.


Agent-Session: https://cmux.com/deeplink/agent?id=aid-8707001042ea634e8771

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 4357ef36 Deployed Nov 4, 2026 by teamleaderleo via cmux-tui tree preflight #109748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant