Repository navigation
Agent pane header: no background behind the top-right icons at rest - #32687
Conversation
…he tab row too Fails on base: the shell paints --agent-page-bg behind the tab-row tools, and hover / toggled-on draw no pill. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a2f53c60d9511e7ec747
… rest The chat shell painted the page color across the pane's tab row, so the header tools sat on a band of it while the tabs beside them sat on the row (since #20933; #25638 cleared html but not the shell). The shell now paints the page color only below the row. The icon under the pointer gets the hover pill, and a toggle whose panel is open (or a button whose menu is open) gets the filled rounded square, as in Leo's reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a2f53c60d9511e7ec747
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Unclear: CI failed on
Not re-run automatically: Written by red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules Shipped in:
|
teamleaderleo
added
risk:low
github-actions
Bot
added
risk:normal
… closes native Session Info after a click in it (#32704) * test(agent-pane): a pressed header toggle requires its filled square; Esc after a click in native Session Info closes it chat-header-plain-icons (red on base since #32687 added the pressed and hover pill) now refuses a fill at rest and requires one on a pressed tool in the chat header, tab row and floating chat; the gallery's plain-icons play follows, and session-info-open[-accentless] check the open toggle's square and lit ink and nothing behind the other tools, in the default and an accentless dark theme. The bun toggle test asserts the page posted on mount and runs the old host's close script from the Swift template (a SyntaxError in its pre-#32673 form). AgentPaneNativeSessionInfoTests gains the native Esc case: red here, the panel never takes the keyboard on a click. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81 * fix(session-info): a click in the native panel gives it the keyboard, so Esc closes it The page's Esc handler closes Session Info only from its toggle or panel; after a click in the App's panel the keyboard stayed in the page (the composer, say), so Esc never reached the panel's cancelOperation. A press on a line, a button, the edge or empty glass now makes the panel first responder (no ring), as a click in the page's panel focused it; when it closes with the keyboard in it, the chat takes the keyboard back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81 * fix(agent-header): hovering an on toggle keeps its filled square; the lint splits selectors at the top level Review follow-up: the hover pill rule (0,4,0) outranked the pressed and menu-open square (0,3,0), so an on toggle under the pointer showed the lighter hover tint, which chat-header-tab-row-surface's pressed-hover case already expects not to happen. The hover pill now excludes [aria-pressed=true] and [data-popup-open]. chat-header-plain-icons splits selector lists at top-level commas (not inside :is or :not), ignores lit states inside :not(...), and asserts the hover fill excludes the pressed state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…er it again (#32971) #32687 painted the page color only below the tab row, so over window art the row read as a darker band with a hard edge instead of the transcript's soft top fade. The shell paints one page color again; the tools keep no plate. Agent-Session: https://cmux.com/deeplink/agent?id=aid-81baa1463f6190d4c5dc Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Leo (2026-11-02): "I'VE LITERALLY FING ASKED / FOR THE FING STUPID BACKGROUND ON THE FING TOP RIGHT ICONS TO BE REMOVED / FOR FING / WEEKS". Earlier (2026-10-31): "AND THE FING BACKGROUND ON THIS FING BUILD ON THESE BUTTONS STILL ISN'T F***ING REMOVESD".
What was drawing it
With the chat's tools in the pane's tab row (
chrome.tabs.rowTools, on by default), the page is transparent athtmlbut.acpmux-shellstill painted--agent-page-bgover the whole pane, the tab row included. The tabs sit on the native row; the tools (Session Info, terminal, changes, browser, files) sat on a block of the page's color that ended at the pane's ⋯. That block is the background.Regressed by: #20933 put the tools in the tab row while the shell kept its background. #25638 (
git log -S'html:has(.acpmux-shell[data-tab-row])') madehtmltransparent but left the shell's color. #28962 later removed per-button plates, which is why the complaint outlived it.Change
header.css:.acpmux-shell[data-tab-row]paints the page color only below the row (a hard-stop gradient at--acpmux-tab-row-height), so the icons sit directly on the row.Test
webviews/test/chat-header-tab-row-surface.test.ts(committed red first in 897c56f):--agent-page-bg, and below the row they must be the page color.Observed / Not run
scripts/web-lint.shpassed (fast checks; the type-aware lint is left to CI on this host).Changelog
Fixed: The agent pane header's top-right icons no longer sit on a background; only hover and an open panel's toggle are highlighted.
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the agent pane header's top-right icons showing a background band at rest, so the icons now sit directly on the tab row like the tabs beside them.
Bug Fixes
Written for commit 70642c1. Summary will update on new commits.