Repository navigation
Agent chat: header tools sit on the tab strip, with no box or line behind them - #25638
Conversation
|
|
|
|
|
Bead |
|
Review (codex gpt-6-astra xhigh, next-review): BLOCK at e41c3c7
|
|
Found 126 test failures on Blacksmith runners: Failures
...and 116 more test failures. View all on Blacksmith: run 40492505285, run 40492505250
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 106c8c9 to compare; do not merge until green; see lane-rules Gallery before/after for
States
Pick other states with a |
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Shipped in:
|
|
Shipped in:
|
…32687) * test(agent-pane): header icons have nothing behind them at rest, in the tab row too Fails on base: the shell paints --agent-page-bg behind the tab-row tools, and hover / toggled-on draw no pill. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a2f53c60d9511e7ec747 * fix(agent-pane): no background behind the header's top-right icons at rest The chat shell painted the page color across the pane's tab row, so the header tools sat on a band of it while the tabs beside them sat on the row (since #20933; #25638 cleared html but not the shell). The shell now paints the page color only below the row. The icon under the pointer gets the hover pill, and a toggle whose panel is open (or a button whose menu is open) gets the filled rounded square, as in Leo's reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a2f53c60d9511e7ec747 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…row (#32944) * test(agent-pane): the tab row paints nothing behind the header tools, as the page ships The browser test loaded src/styles.css, which the agent pane bundle never loads, and set the row's html color itself, so it passed while the shipped page painted WebTheme's html background (a chat's own color) behind the tools. It now loads only the pane's own sheets under WebTheme's html rule and reads the page's own pixels; the toggled Session Info plate stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81 * fix(agent-pane): no backing behind the header buttons in the tab row The agent page's document root paints WebTheme's page background (html{background:var(--cmux-surface-background) !important}): a chat's own color under appearance.surfaces.agentPane, or the opaque surface. The rule meant to clear it in the tab row (#25638) went into webviews/src/styles.css, which the pane's bundle never loads, so the color filled the row behind the tools, and #32039 then painted the same color behind the tabs. The row now has no backing: html is clear while the chat shares the row, the shell paints the page background below the row only, and the strip behind the tabs is clear again (only the user's own tab bar color fills it). Takes back #32039. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The agent chat header tools now share the native tab strip surface without a page-painted box or seam behind them. Leo’s words were: “the session rail session info thing, like, you literally didn't do. I mean, why is the button not toggled? Why is the button area still, like, just garbage? What is this? There's still that line of that box with the background that just always is there, and, like, you still haven't done the full-length thing.” This PR covers the “button area … garbage” and “line of that box” portion only.
The box came from the agent page root and
.acpmux-shellpainting--agent-page-bgacross the offered tab row; the line came from.acpmux-header[data-tab-row]::after’s 12px gradient. Native pane framing is disabled for agent chats, so the native pane border/corner was not the source. The fix marks the shell while the row is offered, makes the document root transparent for that state, paints the page background below the row, and removes the seam pseudo-element. Tool positions, hit targets, tabs, and other pane surfaces are unchanged.Before / after
Fleet capture evidence will be added after the Mac build for this exact head.
Risk
Low. The transparency selector is scoped to an agent shell with an active tab-row offer, and the existing page background resumes below the row. The focused regression checks the shell marker, scoped surface rule, and removed seam.
Validation
bun test webviews/test/chat-header-tab-row-surface.test.ts webviews/test/chat-header-plain-icons.test.ts(pass)bun run --cwd webviews check:fixed-waits(pass)bun run --cwd webviews check:design-tokens(pass; baseline ratchet reduced by removing the deleted 12px seam)scripts/cmux-next/prepush-gate.py(pass)check:layersremains red on the existingwebviews/src/pages/keybindings/styles.cssbackdrop-filter baseline violation; typecheck/lint cannot complete because this checkout lacks generated locale files.agent-identity footer
Need help on this PR? Tag
@codesmith-botwith what you need.