Skip to content

Agent chat: test that the transcript's top edge under the tab row is a fade, not a band - #32971

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/top-row-band
Nov 3, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/top-row-band

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Leo, 2026-11-03: "What the hell, why is there now a black bar on everything at the top row instead of a tiny blur at the top"

The band's cause was fixed at its source by #32944, which merged while this PR was open: the document root's chat colour (WebTheme's html rule) and the native strip behind the tabs (#32039) both painted under the tab row, so over window art the row read as a dark band. This PR first painted the page colour under the row as well. That would have brought back the plate behind the header tools that #32944 and Leo's 11-02 ask removed, so it now takes #32944's design and adds only the guard Leo's ask needs.

  • New browser test in chat-header-tab-row-surface.test.ts: the transcript's top edge under the row is a gradient mask, never an opaque band. The mask image is a linear-gradient. Black rows under the row read as the page colour at the edge, half faded at 9px, and full ink below the 18px fade.

Observed / Not run

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code

…er it again

#32687 painted the page color only below the tab row, so over window art the
row read as a darker band with a hard edge instead of the transcript's soft
top fade. The shell paints one page color again; the tools keep no plate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-81baa1463f6190d4c5dc
@teamleaderleo teamleaderleo added risk:low Risk tier (docs/ci/risk-tiers.md) leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel labels Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

…keep its design, keep the fade test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-81baa1463f6190d4c5dc
@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 3, 2026
@cursor

cursor Bot commented Nov 3, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review ee640d5: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32971 -f ref=lane/top-row-band -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. CI was cancelled before it finished. This PR merged before its CI finished: fix forward on main.

CI stopped on ee640d50f8 (run 41574995772 attempt 1): 1 unknown.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-check; a job it gathers ended without a verdict (web / react-apps-check (1): cancelled); do not merge until green; see lane-rules

Shipped in:

@teamleaderleo
teamleaderleo merged commit a216195 into feat-cmux-next Nov 3, 2026
67 of 68 checks passed
@teamleaderleo
teamleaderleo deleted the lane/top-row-band branch November 3, 2026 03:55
@teamleaderleo teamleaderleo changed the title Agent chat: no dark band across the top row; soft top fade again Agent chat: test that the transcript's top edge under the tab row is a fade, not a band Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus medium): SHIP at ee640d5

Visual verdict: unchanged by this diff (test only).

Checked the new pixel test against the shipped sheets: with the [data-fade-top] mask removed, red(top) and mid drop to 0 and the test fails; an opaque dark band over the row or the first 18px also fails it. The sampling is stable: viewport DPR 1, the row is a whole 40px, x=150 is clear of the 16px scrollbar lane mask, and the bounds (>200, 40..220) leave wide margins around the gradient values (~248 at the edge, ~128 at the midpoint).

Follow-ups: [follow-up] the test pins html to red, overriding #32944's html:has(.acpmux-shell[data-tab-row]){background:transparent}, so an opaque page-colored band over the row would not fail it. The existing omitBackground test in the same file covers that case, so this is a gap in this test only, not in coverage.

@github-actions github-actions Bot added risk:low Risk tier (docs/ci/risk-tiers.md) and removed risk:normal Risk tier (docs/ci/risk-tiers.md) labels Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Capture tour-glass at a21619526efa (fleet build, capture mini, text checked for private data)

Light Dark
light dark

These stills are the tour's last step: the window art is off and the chat is empty. They show the chat's tab row with no band behind its tools, but not a transcript fading under the row over window art. A tour state that shows a long chat over art is a follow-up.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — ee640d50 Deployed Nov 3, 2026 by teamleaderleo via cmux-tui tree preflight #103833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant