Repository navigation
Agent pane header: an open toggle keeps its filled square under the pointer (fix-forward #32687) - #32703
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a2f53c60d9511e7ec747
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 3, 2026 00:03 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
github-actions
Bot
added
risk:normal
Collaborator
Author
Collaborator
Author
|
Review (subagent claude-opus-5-5 medium): SHIP at 7f4d35e. All three on selectors are now 0,4,0 and come after the hover rule, so an open toggle or open menu keeps its fill under the pointer. Rest, focus-visible and disabled show no fill. Follow-ups: none. |
teamleaderleo
added
the
leo-named-fix
teamleaderleo
added a commit
that referenced
this pull request
Nov 3, 2026
…t accepts its form Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-forward for #32687, which landed at 70642c1 one commit short:
webviews/test/chat-header-tab-row-surface.test.tsis red on base in 4pressed-hovercases.Leo (2026-11-02): "FOR THE FING STUPID BACKGROUND ON THE FING TOP RIGHT ICONS TO BE REMOVED". His reference fills only the toggled-on button.
The hover pill rule (
.acpmux-header-tools .acpmux-header-tool:not(:disabled):hover, specificity 0,4,0) beat the on fill (...:is([aria-pressed=true],[data-popup-open]), 0,3,0). So a toggle whose panel is open, or a ⋯ whose menu is open, showed the hover pill instead of the filled square while the pointer was on it. The on selectors now carry:not(:disabled): they are as specific as the hover rule and come after it.Observed / Not run
bun test test/chat-header-tab-row-surface.test.ts: 28 pass, 4 fail (allpressed-hover; run 41548703069). The same command on this head is running now; its result will be posted here.Changelog
none
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the agent pane header so an open toggle keeps its filled square under the pointer instead of swapping it for the hover pill.
The "on" selectors were less specific than the hover rule, so hovering a toggle whose panel or menu was open showed the pill background. The "on" selectors now include
:not(:disabled), matching the hover rule's specificity and coming after it in the stylesheet, so the filled square stays visible while hovered.Written for commit 7f4d35e. Summary will update on new commits.