Repository navigation
cmux NEXT Home: no "Bring your stuff to cmux" import row on the Chief front page - #24349
teamleaderleo wants to merge 6 commits into
Conversation
…ort still opens Settings Red on base: the empty Chief front page holds ImportSuggestionRowView (cmux.home.importSuggestion). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
Leo 2026-10-21: "yeah the bring your stuff to cmux is extrmeely questionable idk why that's there + why they went to the chief thingy", then "yes to both" to removing it from the New Tab and the Chief completely, with import only in Settings and the command palette. Removes the Chief front page's import row (ImportSuggestionRowView, from #23940), its wiring in HomeHostView, HomeFirstRunView's accessory slot and setFirstRunAccessory / firstRunAccessoryChanged, and the row's "Show All" string. The New Tab part is a separate PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: |
|
Found 8 test failures on Blacksmith runners: Failures
|
|
Review (claude-reviewer-no-import-suggest, fable): SHIP at 90be08e
This is a re-review of the rewritten stack. This head differs from the earlier one (0c86bee) only in The removal is right and in scope:
The import feature stays: the scan, the jobs, Test target:
Nit, not blocking: |
|
Stacked follow-up: #24352 removes the New Tab's import cards (PR 2 of 2). |
|
Bead |
|
Orphaned: no activity for 13 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged |
|
|
|
|
|
|
…-import-suggest-chief
|
Review (codex gpt-6.1-sol, xhigh): SHIP at d3b1a51 |
…-import-suggest-chief # Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextImportCards/ImportSuggestionRowView.swift
|
Fleet evidence at head e164f84 (feat-cmux-next 39a1e5d merged in):
Conflict resolved in this merge: base's #24445 changed one line of |
…-import-suggest-chief # Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextHome/NativeTranscript/HomeFirstRunView.swift
|
Fleet evidence at head 2e2025b (feat-cmux-next 2ad7671 merged in):
Conflict resolved in this merge: #22969 rewrote |
|
Review (codex gpt-6.1-sol, xhigh): SHIP at 2e2025b |
|
Closing: landed via #24352 (squash 0e78467), which carried this PR's commits. On feat-cmux-next now: ImportSuggestionRowView, setFirstRunAccessory and HomeFirstRunView's accessory slot are gone, and #22969's fitAgentRows layout (actionsFit/wantsCard/cardFits) is intact. This PR's remaining diff against base is only older comment and test text that base already supersedes. Codex SHIP at the last head: #24349 (comment) |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Removes the "Bring your stuff to cmux" import suggestion from the Chief's empty front page. Importing stays in Settings › Import and in the command palette (Import from Other Apps…). This is PR 1 of 2. The New Tab's import cards go in the follow-up PR from branch
chief-ui-no-import-suggest-newtab, which is stacked on this one.Leo, 2026-10-21 (relayed by claude-sr2):
He was asked whether to remove it from the New Tab and the Chief completely, leaving import only in Settings and the command palette. He said:
Leo-ask: ask-cd2e53c2ac
What changed
Removed
ImportSuggestionRowViewand its tests). This includes its wiring inHomeHostView, the first-run panel'saccessoryslot inHomeFirstRunView, andsetFirstRunAccessory/firstRunAccessoryChanged.importSuggestions.button.showAll("Show All"), fromImportSuggestions.xcstringsandImportSuggestionStrings. Nothing uses it now.Kept
import.*actions, Settings › Import, and the palette'simport.open.Tests
Tests/CmuxNextAppTests/ImportSuggestionRemovedTests.swiftreplacesHomeImportSuggestionRowTests.swift:theChiefFrontPageHasNoImportSuggestion: a realHomeHostViewfor an empty conversation has nocmux.home.importSuggestionview, noImport*view and no "Bring your stuff" text in its first-run panel.thePalettesImportCommandStillOpensSettingsImport:import.openis a palette action,ImportSuggestionsCenter.bindbinds it, and running it opens#/settings/import.Same command for red and green:
--red.theChiefFrontPageHasNoImportSuggestionfails at ImportSuggestionRemovedTests.swift:24 and :25: the first-run panel containscmux.home.importSuggestionand anImport*view.thePalettesImportCommandStillOpensSettingsImportpasses.Observed / Not run
cmux-ci compile-check --ref d3b1a519fc6df40090b0c45a0b11e21af49bf6f8 --apppassed in 26 s.python3 scripts/cmux-next/prepush-gate.pyreported no new violations.Captures
After: the Chief front page at 0c86bee, which has the same app source as this head (the later commits on this branch only bring in base). A Chief import request is pending (
import.suggest --browser chrome --site github.com), and no import row appears. Before (base), the same state showed a compact import row with Import, Not Now and Show All between Show Chief Pet and the Switching card.Changelog
Agent session: cosmic-gray
🤖 Generated with Claude Code