Skip to content

cmux NEXT Home: no "Bring your stuff to cmux" import row on the Chief front page - #24349

Closed
teamleaderleo wants to merge 6 commits into
feat-cmux-nextfrom
chief-ui-no-import-suggest-chief
Closed

teamleaderleo wants to merge 6 commits into
feat-cmux-nextfrom
chief-ui-no-import-suggest-chief

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Removes the "Bring your stuff to cmux" import suggestion from the Chief's empty front page. Importing stays in Settings › Import and in the command palette (Import from Other Apps…). This is PR 1 of 2. The New Tab's import cards go in the follow-up PR from branch chief-ui-no-import-suggest-newtab, which is stacked on this one.

Leo, 2026-10-21 (relayed by claude-sr2):

"yeah the bring your stuff to cmux is extrmeely questionable idk why that's there + why they went to the chief thingy"

He was asked whether to remove it from the New Tab and the Chief completely, leaving import only in Settings and the command palette. He said:

"yes to both"

Leo-ask: ask-cd2e53c2ac

What changed

Removed

Kept

  • The scan, the import jobs, the import.* actions, Settings › Import, and the palette's import.open.

Tests

Tests/CmuxNextAppTests/ImportSuggestionRemovedTests.swift replaces HomeImportSuggestionRowTests.swift:

  • theChiefFrontPageHasNoImportSuggestion: a real HomeHostView for an empty conversation has no cmux.home.importSuggestion view, no Import* view and no "Bring your stuff" text in its first-run panel.
  • thePalettesImportCommandStillOpensSettingsImport: import.open is a palette action, ImportSuggestionsCenter.bind binds it, and running it opens #/settings/import.

Same command for red and green:

cmux-ci run --class light --script scripts/ci/package-test-lane.sh --ref <sha> --arg=suite --arg=Packages/macOS/CmuxNext --arg=<suites> --env CMUX_CI_XCODE_APP=/Applications/Xcode_26.6.app

Observed / Not run

  • Observed: cmux-ci compile-check --ref d3b1a519fc6df40090b0c45a0b11e21af49bf6f8 --app passed in 26 s. python3 scripts/cmux-next/prepush-gate.py reported no new violations.
  • Observed: in the real app at the source of this head, the Chief front page shows the agent rows and the Switching card with no import row (capture below).
  • Not run: the full CmuxNextAppTests suite on the fleet (PR CI runs it).

Captures

After: the Chief front page at 0c86bee, which has the same app source as this head (the later commits on this branch only bring in base). A Chief import request is pending (import.suggest --browser chrome --site github.com), and no import row appears. Before (base), the same state showed a compact import row with Import, Not Now and Show All between Show Chief Pet and the Switching card.

Light Dark
light dark

Changelog

  • Removed: the "Bring your stuff to cmux" import row on the Chief's front page. Import stays in Settings › Import and the command palette (Import from Other Apps…).

Agent session: cosmic-gray

🤖 Generated with Claude Code

teamleaderleo and others added 2 commits October 22, 2026 01:52
…ort still opens Settings

Red on base: the empty Chief front page holds ImportSuggestionRowView
(cmux.home.importSuggestion).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
Leo 2026-10-21: "yeah the bring your stuff to cmux is extrmeely
questionable idk why that's there + why they went to the chief thingy",
then "yes to both" to removing it from the New Tab and the Chief
completely, with import only in Settings and the command palette.

Removes the Chief front page's import row (ImportSuggestionRowView, from
#23940), its wiring in HomeHostView, HomeFirstRunView's accessory slot
and setFirstRunAccessory / firstRunAccessoryChanged, and the row's
"Show All" string. The New Tab part is a separate PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16057-0fea-7933-80f2-cec81447d873&host=cosmic-gray
@cursor

cursor Bot commented Oct 22, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 2e2025b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24349 -f ref=chief-ui-no-import-suggest-chief -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: red check: Checks job structure (+2 more) is not red on the base 2ad7671; do not merge until green; see lane-rules

@blacksmith-sh

blacksmith-sh Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Found 8 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpb8t14r5h/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpuk6zdqd5/summary-missing.json (live):/summary-missing.json (live): View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
test_base_passes (main.NoticesPairTests.test_base_passes)/
test_base_passes (main.NoticesPairTests.test_base_passes)
View Logs
test_targets_outside_the_app_go_to_the_mac_canary (main.SwiftCanaryFleetCoverage.te
st_targets_outside_the_app_go_to_the_mac_canary)/
test_targets_outside_the_app_go_to_the_mac_canary (main.SwiftCanaryFleetCoverage.te
st_targets_outside_the_app_go_to_the_mac_canary)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (claude-reviewer-no-import-suggest, fable): SHIP at 90be08e

yeah the bring your stuff to cmux is extrmeely questionable idk why that's there + why they went to the chief thingy

yes to both

This is a re-review of the rewritten stack. This head differs from the earlier one (0c86bee) only in ImportSuggestionRemovedTests.swift:44-45, which now passes importClassic: { _ in nil }, matching ImportCardsHost.init (ImportCardsHost.swift:23-26). That was the only blocker, and it is fixed.

The removal is right and in scope:

  • The Chief front page's import row is gone. HomeHostView no longer builds ImportSuggestionRowView or imports CmuxNextImportCards.
  • HomeFirstRunView drops accessory from its arrange, fit, spacing and width paths together.
  • setFirstRunAccessory and firstRunAccessoryChanged are removed, and ImportProgressBar went with the row.
  • No reference to any removed symbol remains in Packages, webviews, scripts, docs, tests, ci or .github.
  • ImportSuggestions.xcstrings is valid JSON and loses exactly importSuggestions.button.showAll, which nothing else names.

The import feature stays: the scan, the jobs, import.list/card/suggest/open, and Settings › Import (list(for: .settings) and settingsJSON are unchanged at this head). import.open is still a .palette descriptor (ImportActionCatalog.swift:33-36), bound in ImportCardsActions.swift:46 to openSettings(), which opens #/settings/import.

Test target:

  • Every API ImportSuggestionRemovedTests calls exists with the signature and access it uses.
  • CmuxNextActions, CmuxNextHome, CmuxNextImportCards and the CmuxHomeCore product are declared dependencies of CmuxNextAppTests.
  • At the test-first commit 843f252, the new file compiles against base, and theChiefFrontPageHasNoImportSuggestion fails on its assertion there.

Nit, not blocking: ImportCardDeck.Surface.home and ImportSuggestionsCenter.list(for: .home) have no caller left at this head. The stacked PR removes them.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Stacked follow-up: #24352 removes the New Tab's import cards (PR 2 of 2).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-jhluy created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Orphaned: no activity for 13 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged feat-cmux-next in at f700bf1. A later pass queues it for the merge hub if it is reviewed, small and red only on base reds.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next crash-class rules / cmux-next crash-class rules is red on 13 of 13 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next guards / nightly-guards / workflow-guard-tests / release-notary is red on 17 of 17 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next / cmux-next checks (god files, concurrency, crash safety, l10n) › Checks job structure is red on 17 of 17 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol, xhigh): SHIP at d3b1a51
No blocking findings.

…-import-suggest-chief

# Conflicts:
#	Packages/macOS/CmuxNext/Sources/CmuxNextImportCards/ImportSuggestionRowView.swift
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Fleet evidence at head e164f84 (feat-cmux-next 39a1e5d merged in):

  • cmux-ci compile-check --ref e164f848e414b71bb79d77e6e82d647ce0e339dc --app: passed (24 s).
  • Green (step cba0390e): ImportSuggestionRemovedTests, ImportSuggestionsCenterClassicTests and ClassicMigrationTests all passed.
  • Red, recorded earlier (step 9d82d2d6 at c85e323, the test file on base dbba284): theChiefFrontPageHasNoImportSuggestion failed at :24 and :25.

Conflict resolved in this merge: base's #24445 changed one line of ImportSuggestionRowView.swift (its tooltip theme). This PR deletes that file, so it stays deleted; nothing references it.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol, xhigh): SHIP at e164f84
No blocking findings; only a base merge since SHIP at d3b1a51.

…-import-suggest-chief

# Conflicts:
#	Packages/macOS/CmuxNext/Sources/CmuxNextHome/NativeTranscript/HomeFirstRunView.swift
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Fleet evidence at head 2e2025b (feat-cmux-next 2ad7671 merged in):

  • cmux-ci compile-check --ref 2e2025b5031cc0c909b12484753275faa8c55618 --app: passed (72 s).
  • Green (step 7d9a4e6b): ImportSuggestionRemovedTests, ImportSuggestionsCenterClassicTests and ClassicMigrationTests all passed.

Conflict resolved in this merge: #22969 rewrote HomeFirstRunView.fitAgentRows. Its logic is kept entirely; only the two lines that added the removed accessory height are dropped. Against base, this file changes only by the accessory removal.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol, xhigh): SHIP at 2e2025b
No blocking findings.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing: landed via #24352 (squash 0e78467), which carried this PR's commits. On feat-cmux-next now: ImportSuggestionRowView, setFirstRunAccessory and HomeFirstRunView's accessory slot are gone, and #22969's fitAgentRows layout (actionsFit/wantsCard/cardFits) is intact. This PR's remaining diff against base is only older comment and test text that base already supersedes. Codex SHIP at the last head: #24349 (comment)

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 2e2025b5 Deployed Oct 23, 2026 by teamleaderleo via namespace autofix #1746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant