Repository navigation
Revert #23969: a tab opened to the side starts its open on the right - #24292
Conversation
…ght, never in the left pane (#23969)" This reverts commit c8f5d31. A Codex xhigh review after the merge blocked it: - A tab marked outbound stays hidden even if the user selects it during the move. - The hold is released 2 s after the move acknowledges, with no check that the source pane dropped the tab. - Holds are keyed by raw tab ids, so a reused id is hidden too. It will be re-landed with those fixed and a different-model review before merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Owned by main-pane-mode on cosmic-gray · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on b5a78a8 to compare; do not merge until green; see lane-rules |
|
Review (subagent, correctness first): SHIP at 4caf7b2 Reviewer: Codex at xhigh, a different model from this lane's Claude. It is the same reviewer that blocked #23969.
The fleet |
|
Bead |
|
Found 11 test failures on Blacksmith runners: Failures
...and 1 more test failures. View all on Blacksmith
|
Picks up #24292, the revert that makes the CmuxNext test targets compile again (SideOpenStripTests broke the fast tier and daemon tests on base). Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=Air-Blue Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Shipped in:
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Reverts #23969 (squash c8f5d31). The tree is base with #23969's diff inverted exactly (7 files, +38/−348). Nothing else changes.
Why: #23969 merged on a same-model review. The different-model review that followed (Codex at xhigh) said BLOCK:
OutboundTab.hidesignoresshownByPaneonce a surface or name is marked.LinkOpener.movemarks the tab before it awaits the move, so if the user selects that tab in the gap, the selected tab disappears from the strip. Selection, Cmd-W and tab indexes can then go stale.finish(moved: true)releases the hold after 2 s regardless. IfTabMovesacknowledges before the source pane's snapshot drops the tab, the tab reappears in the left strip, the same race cmux NEXT: a tab opened to the side starts its open on the right, never in the left pane #23969 set out to fix.Before this PR: a tab opened to the side first shows on the right, with those edge cases. After: back to the behaviour before #23969, where the tab plays its open animation for about 100 ms in the left pane's strip and then moves right. A re-land with the fixes and a different-model review before merge follows.
Leo-ask: ask-f6988c508c
Leo-ask: ask-35d63f0002
Leo: "the animation for opening up a new tab starts off in the left pane, and it doesn't start off at the right"
No capture: an exact revert to the state before #23969; the before-and-after behaviour is described in #23969.
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Reverts #23969, restoring the previous behavior where a tab opened to the side plays its open animation in the left pane's strip for about 100 ms before moving right.
The revert is exact: #23969's diff inverted, so nothing else changes. It restores the state before that PR, which a different-model review blocked after merge for edge cases (
OutboundTabhiding a tab a user selected mid-move, a 2 s hold released without confirming the source pane dropped the tab, and holds keyed by raw ids that can hide a reused id). The feature will be re-landed with those fixed and re-reviewed.Written for commit 4caf7b2. Summary will update on new commits.