Repository navigation
cmux NEXT Home: the import suggestion's tooltip is themed (NativeTooltipGuardTests base red) - #24445
Conversation
…AppKit's stock bubble NativeTooltipGuardTests.noViewDrawsTheStockTooltip flagged ImportSuggestionRowView.swift:138 (raw toolTip =), added in #23940. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: |
|
Caution Review failedAn error occurred during the review process. Please try again later.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Owned by land-and-ci on huge-blue · session |
|
Found 8 test failures on Blacksmith runners: Failures
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red in the cmux-next Swift suite (run 39882563236 at 9c3ebbc, still red at 75673f9):
Cause: #23940 (d9b8caf), Home's import suggestion row, set
factsLabel.toolTip = first.benefit, which draws AppKit's stock tooltip bubble.Fix:
factsLabel.themedToolTip = first.benefit, the themed tooltip the guard asks for (CmuxNextDesign/Tooltip/ThemedToolTip.swift, already a dependency of CmuxNextImportCards). Same text on the same label; only the bubble's look changes to the themed one.Changelog
none
Observed / Not run
Observed (fleet,
cmux-ci run --class light --script scripts/ci/package-test-lane.sh --arg=suite --arg=Packages/macOS/CmuxNext --arg=NativeTooltipGuardTests --env CMUX_CI_XCODE_APP=/Applications/Xcode_26.6.app):noViewDrawsTheStockTooltip()fails with the offender above.Test run with 2 tests in 1 suite passed.python3 scripts/cmux-next/prepush-gate.py: no new violations.Not run: the hover in a running app (no capture).
Agent session: huge-blue
🤖 Generated with Claude Code