Skip to content

cmux NEXT Home: the import suggestion's tooltip is themed (NativeTooltipGuardTests base red) - #24445

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
land-and-ci/tooltip-import-row
Oct 23, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
land-and-ci/tooltip-import-row

Conversation

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Base red in the cmux-next Swift suite (run 39882563236 at 9c3ebbc, still red at 75673f9):

✘ Test noViewDrawsTheStockTooltip() recorded an issue at NativeTooltipGuardTests.swift:35:9: Expectation failed: (offenders → ["CmuxNextImportCards/ImportSuggestionRowView.swift:138: raw toolTip ="]).isEmpty → false

Cause: #23940 (d9b8caf), Home's import suggestion row, set factsLabel.toolTip = first.benefit, which draws AppKit's stock tooltip bubble.

Fix: factsLabel.themedToolTip = first.benefit, the themed tooltip the guard asks for (CmuxNextDesign/Tooltip/ThemedToolTip.swift, already a dependency of CmuxNextImportCards). Same text on the same label; only the bubble's look changes to the themed one.

Changelog

none

Observed / Not run

Observed (fleet, cmux-ci run --class light --script scripts/ci/package-test-lane.sh --arg=suite --arg=Packages/macOS/CmuxNext --arg=NativeTooltipGuardTests --env CMUX_CI_XCODE_APP=/Applications/Xcode_26.6.app):

  • Red at base 75673f9: step 2955adb8597b6cb9220c4307, noViewDrawsTheStockTooltip() fails with the offender above.
  • Green at head a458103: step 4d5ba0b5802cb89780038809, Test run with 2 tests in 1 suite passed.
  • python3 scripts/cmux-next/prepush-gate.py: no new violations.

Not run: the hover in a running app (no capture).

Agent session: huge-blue

🤖 Generated with Claude Code

…AppKit's stock bubble

NativeTooltipGuardTests.noViewDrawsTheStockTooltip flagged
ImportSuggestionRowView.swift:138 (raw toolTip =), added in #23940.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review a458103: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24445 -f ref=land-and-ci/tooltip-import-row -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: red check: Checks job structure (+1 more) is not red on the base c467f83; do not merge until green; see lane-rules

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by land-and-ci on huge-blue · session

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Oct 23, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Found 8 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp471e71_7/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmp91reexnn/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
test_base_passes (main.NoticesPairTests.test_base_passes)/
test_base_passes (main.NoticesPairTests.test_base_passes)
View Logs
test_targets_outside_the_app_go_to_the_mac_canary (main.SwiftCanaryFleetCoverage.te
st_targets_outside_the_app_go_to_the_mac_canary)/
test_targets_outside_the_app_go_to_the_mac_canary (main.SwiftCanaryFleetCoverage.te
st_targets_outside_the_app_go_to_the_mac_canary)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex review, high): SHIP at a458103
Fleet suite at this head: green (cmux-ci step 4d5ba0b5802cb89780038809); red at base in step 2955adb8597b6cb9220c4307.

Agent session: huge-blue

@teamleaderleo
teamleaderleo merged commit bb16c20 into feat-cmux-next Oct 23, 2026
151 of 159 checks passed
@teamleaderleo
teamleaderleo deleted the land-and-ci/tooltip-import-row branch October 23, 2026 04:09
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

1 inactive deployment
ci-routing-agent — a4581035 Deployed Oct 23, 2026 by teamleaderleo via namespace autofix #1663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant