Skip to content

cmux-next tests: RemoteChildSessionsTests' fake client states isReadOnly (base red: tests don't compile) - #23362

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
wn/remote-child-fakeclient-readonly
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
wn/remote-child-fakeclient-readonly

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Base red: CmuxNextAppTests doesn't compile on feat-cmux-next, so no Swift test suite of the CmuxNext package can run. The cause is a semantic merge break between two PRs:

The fake stands in for a writable daemon attachment, so it now declares let isReadOnly = false.

Testing

  • Red: a fleet run-swift-testing-suites.sh Packages/macOS/CmuxNext run on base 4a6ef5b fails to build: RemoteChildSessionsTests.swift:14:37: error: type 'RemoteChildSessionsTests.FakeClient' does not conform to protocol 'AgentSessionRemoteClient' (note: protocol requires property 'isReadOnly').
  • Green: the same fleet run on this head (46916d2) gets through build-and-list (233 s), compiles CmuxNextAppTests RemoteChildSessionsTests.swift with no error, and starts the suites.

Observed / Not run

Observed: the red and green fleet builds above. Review: an independent review subagent passed it. It confirmed isReadOnly was the only missing requirement, and that false changes no assertion: these tests only send _acpmux/watch, which never reads the flag. It also confirmed the other two conformers already declare it.

Not run: I merged before the fleet suite run finished, so the suites' results aren't in yet.

Red on this head that isn't this PR's: cmux-next checks fails on Companion workflows, because scripts/cmux-next/base-autofix-repair.sh doesn't exist in that job. That's a workflow-script problem; this PR changes one Swift test file.

Changelog

none

Agent session: cosmic-gray

🤖 Generated with Claude Code

#21258 made isReadOnly a requirement of AgentSessionRemoteClient, and
#23163, merged after it, added a FakeClient without it, so
CmuxNextAppTests stopped compiling on feat-cmux-next and no Swift suite
runs. The fake is a writable daemon attachment, so it says false.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba2-c7ad-7850-9e71-5b51f1c9ed9f&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by claude-sr2/gallery-loop on cosmic-gray · session

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 46916d2: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23362 -f ref=wn/remote-child-fakeclient-readonly -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 46916d21b0; ci-status is green without them.

CI passes on 46916d21b0 (run 39595132058 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on f90fbd9 to compare; do not merge until green; see lane-rules

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026

Copy link
Copy Markdown

Found 5 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp8t05f6kc/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpp0ds3x3_/summary-fail.json (live):/summary-fail.json (live): View Logs
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett
ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_
inputs_still_rewrites_them) (job='autofix')/
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett
ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_
inputs_still_rewrites_them) (job='autofix')
View Logs
test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeave
sTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='autofix'
)/
test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeave
sTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='autofix'
)
View Logs
test_settings_exports_alone (main.SettingsOnlyArtifactLeavesTheActionFollowers.test
_settings_exports_alone) (job='autofix')/
test_settings_exports_alone (main.SettingsOnlyArtifactLeavesTheActionFollowers.test
_settings_exports_alone) (job='autofix')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-bjjg5 created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit aebafa0 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the wn/remote-child-fakeclient-readonly branch October 21, 2026 12:11
teamleaderleo added a commit that referenced this pull request Oct 21, 2026
Picks up #23362 (RemoteChildSessionsTests builds again), which the Swift test
build and the settings export regeneration need.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=cosmic-gray
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant