Repository navigation
cmux-next: the app test target compiles again (RemoteChildSessionsTests fake gets isReadOnly) - #23363
teamleaderleo wants to merge 1 commit into
Conversation
… the test target compiles #23163 added a fake AgentSessionRemoteClient without isReadOnly, which #21258 made a requirement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba7-3152-78b2-bfdf-bb6eb0d5a053&host=cosmic-gray
|
Owned by claude-sr2/sidebar-drag-bugs on cosmic-gray · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on f90fbd9 to compare; do not merge until green; see lane-rules |
|
Found 5 test failures on Blacksmith runners: Failures
|
|
Bead |
|
Heads-up: three PRs are open for this same one-line base fix — #23362 (opened 11:51:53Z), #23363 (11:52:02Z) and #23369 (11:58:52Z). #23362 is the earliest, so landing that one and closing the other two keeps them from racing on the same line. For the record of how it broke: #21258 added Not touching this branch — just cross-linking. |
|
PASS (review on head 2548f63, correctness first; priority-view lane, session 6807b41c).
|
|
Duplicate of #23362, same fix. |
The CmuxNext test target on
feat-cmux-nextdoes not compile, so every Swift package test lane is red. #23163 added a fakeAgentSessionRemoteClientinRemoteChildSessionsTestswithoutisReadOnly, which #21258 made a protocol requirement:The fake now says it can prompt (
isReadOnly = false), as the chat it stands in for does.Changelog
none
Observed / Not run
RemoteChildSessionsTestspasses on this head (2548f63, fleet step 2b032a233468, 4 tests).🤖 Generated with Claude Code
Agent session: cosmic-gray