Repository navigation
cmux NEXT environment picker: a started chat offers Move to Cloud, or Bring Back Local - #23157
Conversation
… or Bring Back Local (red: a started chat's computer is a fixed label, and the pane may not run either action) environment-picker.test: a started local chat's picker shows this Mac and Move to Cloud; a started Cloud chat's shows its machine and Bring Back Local; Return on a search never moves a chat; an SSH chat or a host with no move keeps the fixed label. AgentPaneConnectActionTests: cloudMove and cloudBringBack run on the person's gesture; an action the app did not run is an unavailable failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c03-0c22-7660-ab5f-4cf259edf1c3&host=cosmic-gray
… Bring Back Local on a Cloud machine (environment-picker.test, AgentPaneConnectActionTests) A started chat's computer is fixed, so its picker lists only where it runs and its one move: Move to Cloud from this Mac (it reuses a Cloud machine or makes one, copies the folder and continues the chat there) and Bring Back Local from a Cloud machine. They run the tab menu's same actions (cloudMove, cloudBringBack) on this tab, on the person's gesture. An SSH machine's chat and the floating chat keep the fixed label. An action the app did not run is now an unavailable failure, and the page says the move isn't available for this chat; a move that ran and stopped reports itself in the app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c03-0c22-7660-ab5f-4cf259edf1c3&host=cosmic-gray
|
Owned by cloud-upsell-b0 on cosmic-gray · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Probably yours: CI failed on
Matched log linesNot re-run automatically: Written by red: web / Web status; base red: the same failure on the base ae42201; does not block
Agents: Tour of |
|
Found 7 test failures on Blacksmith runners: Failures
|
…s chat menu offers (red: it offers Bring Back Local on any Cloud chat, and tabState reports no moves) Review (#23157): a Cloud chat no move from this Mac put there, a chat on an SSH machine whose kind is not known yet, or a chat the app won't move got a row the app then refuses. The page now takes the moves from the app: pane.tabState reports the moves the chat's right-click menu offers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c03-0c22-7660-ab5f-4cf259edf1c3&host=cosmic-gray
… right-click menu offers (environment-picker.test, AgentPaneConnectActionTests) pane.tabState reports the Cloud moves the chat's right-click menu offers now (the App's CloudMove.hiddenMenuItems decides), and the picker offers only those, read again when the list opens. A Cloud chat no move from this Mac put there, or an SSH chat whose machine kind isn't known yet, keeps the fixed label. Bring Back Local's detail line sits under its name, as New Cloud Machine's does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c03-0c22-7660-ab5f-4cf259edf1c3&host=cosmic-gray
|
Bead |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c03-0c22-7660-ab5f-4cf259edf1c3&host=cosmic-gray
|
codex-review: SHIP at df38ec8
|
|
Fleet results for
Not this PR's reds:
|
…ud-offload-picker
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…ase order (only the five picker strings are new) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c03-0c22-7660-ab5f-4cf259edf1c3&host=cosmic-gray
|
Review (independent subagent review, re-review PASS at 51eefd0; later commits are test-only df38ec8, a clean base merge ab54851 with no other changes, and a4cbc68 which only restores base key order in the agent pane string catalog, JSON-identical to ab54851): SHIP at a4cbc68 Compile: Remaining reds at ab54851, all not this PR's:
|
|
Shipped in:
|
A started chat's computer picker now offers that chat's one move, the same action as the tab's right-click menu:
cloudMoveon this tab. With no arguments,CloudMovereuses a Cloud machine (a connected one, else any, else a new one), syncs the folder there (cmux link sync push), moves the chat (cmux link agent move) and opens it on that machine; this Mac's tab closes. Progress and failures are the app's existing toasts.cloudBringBackon this tab. A chat that wasn't moved from this Mac is refused by the action itself, with its own reason (the app's refusal notice).pane.tabStatenow replies withmoves: the Cloud moves the chat's own right-click menu offers now (AgentChatTabActions.menuItems, which hides rows withCloudMove.hiddenMenuItems). The picker offers only those and reads them again when it opens. So a Cloud chat that no move from this Mac put there, or an SSH chat whose machine kind isn't known yet, keeps the fixed label instead of offering a row the app refuses.AgentPaneModel.connectActionsgainscloudMoveandcloudBringBack, andCONNECT_ACTIONSgainsmoveandbringBack.action.runfrom the pane now reports a failure (unavailable) when the app did not run the action and no fallback ran. Before, it said success. On it, the page shows "Move to Cloud isn't available for this chat" (or Bring Back Local) through the existing notice. An action that ran and then stopped reports itself in the app, so there is no double notice.Row names reuse the catalog titles' translations; the two detail lines and the notice are new strings in all 21 locales (
needs_review).Gallery:
agent-pane.composer-contextvariantsstarted-move-to-cloudandstarted-bring-back.No capture: the change is the agent pane's web picker rows; the two gallery variants above render both states, and no native layout changed.
CmuxNextApp: no source growth (
check-app-size.sh --baseok).Testing
webviews/test/environment-picker.test.tsx:CONNECT_ACTIONShas no move.AgentPaneConnectActionTests(fleetpackage-test-lane.sh): green on df38ec8, where all 5 tests pass.cmux-ci compile-check --app: passed on 074afcc, 51eefd0 and df38ec8.Observed / Not run
prepush-gate.py(no new violations),check-app-size.sh --base origin/feat-cmux-next(ok). Inbun run check,vp checkexits 1 on 3 warnings in files this PR doesn't touch (IncomingMessageCard.tsx,HistoryPage.tsx,sidebar-rail-css.test.tsx); every step before it passed.acpmux-protocol:checkandscripts/web-lint.shlocally (bun runs are blocked on this Mac; CI's web lint covers them), and a live move in a DEV build.Changelog
Added: A started agent chat's computer picker offers Move to Cloud, or Bring Back Local for a chat on a Cloud machine.
Agent session: cosmic-gray
🤖 Generated with Claude Code