[teamleaderleo]

Leo, 2026-10-21: a link clicked in a chat opened its github.com tab in a split but left the focus in the chat. His Cmd-W then closed the chat instead of the tab.

Behavior, as in Chrome:

• A plain click focuses the opened tab. A Cmd-click opens it in the background.
• Cmd-W closes the focused tab.
• Closing a tab opened by a click gives the focus back to where the link was clicked. In the link's own pane, the close selects the tab the link was clicked in again, in every window that shows the pane.
• Everything a person clicks counts as theirs: a chat link, a file link, the hover card's Open, the chat header's Changes, Preview and Files (besideTakesFocus). Only an agent's own open stays in the background.
• A click while the agent is mid-turn is the person's: an agent's open still in flight lands unselected and does not take the focus.

The focused-pane cue itself (ring, dim) is window-focus-opacity's own PR. This PR does not touch ScreenContentView+Visibility.swift.

The race the click tests found

The window refuses an agent page's own makeFirstResponder (WebKit's, for the page's own focus()) for a page outside the focused pane (AgentPaneView.refusesSelfFocus). It read the focus before the focus coordinator's queued topology. So when a link's tab took the focus through a still-queued pane change, the chat page's own focus ask looked like the focused pane's. The queued change then landed the focus on the link's tab, and the page's report, reduced right after it, took it back: the tab showed selected with the keyboard still in the chat. The window now judges that ask against currentState() (pending topologies reduced), only for a page's own ask outside an input event and the focus model's moves.

Tests (red first)

• ClickedLinkFocusTests (same-tree daemon): a link in its own pane, in the pane on the right, the header's Preview, a file link, a click while an agent's open is in flight, an agent's open from a lone chat, and aPagesOwnFocusAskLosesToAQueuedLinkTabFocus (the race above, without timing).
• BrowserTabOpenersCloseFocusTests: the closed link tab's successor is its opener, in every window showing the pane.
• LinkRouterCmdClickTests.aCmdClickInAPageViewOpensInTheBackground.

Observed / Not run

• Red: cmux-ci run --class light --script scripts/ci/package-test-lane.sh --arg=suite --arg Packages/macOS/CmuxNext --arg ClickedLinkFocusTests,... --ref <sha>: aLinksTabInItsPaneTakesTheFocusAndItsCloseSelectsTheSourceAgain failed at line 46 on 3159e23 and on 281579e (before the close fix). aPagesOwnFocusAskLosesToAQueuedLinkTabFocus failed 3 of 3 on aeb526e (before the guard fix); before it, the click tests failed in 4 of 8 runs.
• Green: on a19911d, ClickedLinkFocusTests passed 8 of 8 runs, with AgentPaneSelfFocusTests, NewTabHoldFocusTests and BrowserTabOpenersCloseFocusTests. After the base merge (a1eb805) and the test changes for it, 8 of 8 runs pass on ffe26d8 plus the one-line RemoteChildSessionsTests fix the base needs to compile its tests (open as cmux-next tests: RemoteChildSessionsTests' fake client states isReadOnly (base red: tests don't compile) #23362/cmux-next: the app test target compiles again (RemoteChildSessionsTests fake gets isReadOnly) #23363/cmux-next tests: RemoteChildSessionsTests compiles again (FakeClient gets isReadOnly) #23369), with ChatDockLinkSplitMotionTests, AgentPaneSelfFocusTests and BrowserTabOpenersCloseFocusTests.
• Observed: the fleet app compile and link (cmux-ci compile-check --app) passes on a19911d and on a1eb805. prepush-gate.py: no new violations.
• Not run: CI's own Release compile and Debug scheme compile were still queued (fleet backlog). CI's cmux-next swift test on 3fecec9 failed only on base reds (settings schema exports, AgentPaneImageActionsTests.swift:72 and its crash, the same on cmux-next: right-side panels slide in without lag or overflow; directional enter and exit in the agent pane #22795).

No capture: the change is where keyboard focus goes after a click, not how anything looks; the click tests above drive it against a real daemon and window.

Changelog

• Fixed: A link clicked in an agent chat focuses its tab, Cmd-click opens it in the background, and closing the tab returns focus to the chat.

Agent session: huge-blue

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes link focus behavior in cmux-next so a clicked link takes focus in its new tab, Cmd-click opens it in the background, and closing it returns focus to where the link was clicked, matching Chrome.

• A plain click focuses the opened tab; Cmd-click opens it in the background; Shift-Command still picks the other browser.
• Closing a tab opened by a click returns focus to the source pane; in the source's own pane the close selects the source tab again rather than the adjacent one. Each pane controller records its own apply's tabs, so even a pane's first close — in any window showing it — finds the clicked tab's opener.
• The page a link was clicked in can no longer steal the keyboard back once the tab lands focused: the window judges the page's own focus ask against the queued pane changes, so a link tab whose focus was still queued no longer loses to the page.
• A link hover card's Open now opens any http(s) link in cmux via browser.openIn, where browser.open only worked for a local preview page.
• The chat header's Changes, Preview, and Files open where an agent's beside run would, but as a person's click (besideTakesFocus) the new tab takes focus and its close returns it to the chat; an agent's beside open still keeps focus in the chat.
• A person's click mid-turn wins over an agent's open in flight: the agent's tab still lands unselected, and the app's own refocus of a docked chat is now programmatic so a second open in flight doesn't read it as the person acting.
• Adds ClickedLinkFocusTests covering same-pane, split-pane, header, file-link, mid-turn, and page-focus-ask scenarios, plus LinkRouterCmdClickTests for background opening.

^{Written for commit ffe26d8. Summary will update on new commits.}

[teamleaderleo]

owner: 01a15cc2-04ea-7352-837a-21905d44c199 on huge-blue

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review ffe26d8: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22990 -f ref=fix/chat-link-focus -f platform=macos -f backend_mode=local

Gallery before/after for ffe26d8: 16 states rendered, 5 images differ, 1409 more touched states not rendered. Images are in the run's artifact, not on this public PR.

gh run download 39600825835 -R manaflow-ai/cmux -n gallery-advisory-22990-ffe26d85b245d484a3ebb61df5746af5965b0b38 (then read gallery-review.json)

States

State	Theme	Status	Diff	Picked by
agent-pane.url-chip/globe	Apple System Colors Light	unchanged	0%	own LinkHoverCard.tsx
agent-pane.url-chip/globe	Apple System Colors	unchanged	0%	own LinkHoverCard.tsx
agent-pane.url-chip/cached-favicon	Apple System Colors Light	changed	0%	own LinkHoverCard.tsx
agent-pane.url-chip/cached-favicon	Apple System Colors	changed	0%	own LinkHoverCard.tsx
agent-pane.url-chip/token-url	Apple System Colors	changed	0.91%	own LinkHoverCard.tsx
agent-pane.url-chip/token-url	Apple System Colors Light	changed	0.714%	own LinkHoverCard.tsx
agent-pane.url-chip/long-url	Apple System Colors Light	unchanged	0%	own LinkHoverCard.tsx
agent-pane.url-chip/long-url	Apple System Colors	unchanged	0%	own LinkHoverCard.tsx
agent-pane.narrow/controls	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/controls	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/permission	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/permission	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/model-menu	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/model-menu	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/access-menu	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/access-menu	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/summary	Apple System Colors	changed	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/summary	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/working	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/working	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/pull-requests	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/pull-requests	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/new-tab	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.narrow/new-tab	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.path-chip/file	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.path-chip/file	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.path-chip/folder	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.path-chip/folder	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.path-chip/outside-lock	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.path-chip/outside-lock	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.path-chip/outside-text	Apple System Colors Light	unchanged	0%	imports LinkHoverCard.tsx (1 hops)
agent-pane.path-chip/outside-text	Apple System Colors	unchanged	0%	imports LinkHoverCard.tsx (1 hops)

_{Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.}

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on ffe26d85b2 (run 39600826097 attempt 1): 1 code, 1 unknown.
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped.

Job	Verdict	Why
web / react-apps-check (1)	code	a web test failed
web / react-apps-check	unknown	no known signature; failed step: Check webview test shards

Failures:

• seen on other PRs chat-open-perf.test.ts opening chats with 120 in the list draws fast, with no shift and no blank frame: failed (job)

Matched log lines

web / react-apps-check (1): (fail) opening chats with 120 in the list draws fast, with no shift and no blank frame [13870.41ms]

Not re-run automatically: web / react-apps-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; NEW: green on the base 5c4e212; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 5c4e212 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (1); no finished base run on 5c4e212 to compare; do not merge until green; see lane-rules

CI fast guards failed on a1eb8057aa (https://github.com/manaflow-ai/cmux/actions/runs/39594195725). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally.

Tour of ffe26d85b2 (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output.

[teamleaderleo]

cmux-next guards / defaults-snapshot is red on 19 of 20 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

[teamleaderleo]

Bead cx-8ayqb created for this PR by the cmux coordinator.

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[blacksmith-sh]

Found 7 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmp4n13z6pc/summary-missing.json (live):/summary-missing.json (live):	View Logs
/tmp/tmp6avmgd1j/summary-fail.json (live):/summary-fail.json (live):	View Logs
test/agent-pane-scrollbar-full-height.test.ts/agent-pane-scrollbar-full-height.test	View Logs
test/agent-pane-scrollbar-full-height.test.ts/agent-pane-scrollbar-full-height.test	View Logs
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_ inputs_still_rewrites_them) (job='autofix')/ test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_ inputs_still_rewrites_them) (job='autofix')	View Logs
test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeave sTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='autofix' )/ test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeave sTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='autofix' )	View Logs
test_settings_exports_alone (main.SettingsOnlyArtifactLeavesTheActionFollowers.test _settings_exports_alone) (job='autofix')/ test_settings_exports_alone (main.SettingsOnlyArtifactLeavesTheActionFollowers.test _settings_exports_alone) (job='autofix')	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[github-actions]

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.3960833477001 (4482e41d31)
• cmux NEXT nightly 1.0.0-nightly.3960894798201 (0b1a93e9c0)
• cmux NEXT nightly 1.0.0-nightly.3961101575901 (101cc33db2)