Repository navigation
cmux NEXT: revert #22822, links and pages from a chat never open as a tab in its pane - #23886
Conversation
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: Tour of The path-selected recorder failed for core-after, core-before, new-tab-after, new-tab-before; see the run artifact and failed manifests. Path-selected interactions
agent-pane-before: the media could not be published (refused 3 file(s) that show private names: 23886/dcfe8de1/next-agent-pane-before/shots/02-open-agent-chat.png (fleet host name, fleet Mac mini name); 23886/dcfe8de1/next-agent-pane-before/shots/03-que)agent-pane-after: the media could not be published (refused 3 file(s) that show private names: 23886/dcfe8de1/next-agent-pane-after/shots/02-open-agent-chat.png (fleet host name, fleet Mac mini name); 23886/dcfe8de1/next-agent-pane-after/shots/03-queue)Core UI (before): FAILED — 16 ok, 3 failed, 1 unavailable
Failed steps: 5. Split right Screenshots (12)1. Launch
Failed steps: 5. Split right Screenshots (12)1. Launch
Failed steps: ### New Tab \(after\): FAILED — 2 ok, 2 failed
Failed steps: Tours are data in |
|
Found 11 test failures on Blacksmith runners: Failures
...and 1 more test failures. View all on Blacksmith
|
|
Bead |
|
Owned by main-pane-mode on cosmic-gray · session |
… pane Leo 2026-10-21: "HOW COULD ANYBODY HAVE POSSIBLY THOUGHT OPENING A NEW TAB IN HERE BY DEFAULT WAS ACCEPTABLE", about his agent pane, and "#22822 was SO STUPID": he had asked about the tab-open animation, not where links go. This reverts commit 7997e21. Every link and file a terminal, an agent chat, Home or a page opens goes where layout.linkPlacement says again (the pane on the right, else a new split); the cmdClick plumbing, the links.pagesFollowPlacement toggle, its settings text and release note go. The New Tab pick toggle is newTab.picksFollowLinks again (default off: a pick takes the page's place). Kept from later work: main pane layout (#23105) and the Chrome-style link focus. ClickedLinkFocusTests: the in-pane case sets Same Pane; the file link test waits for the daemon's tab, not the split's pending one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2d-622e-7433-aed6-f3c248542f5d&host=cosmic-gray
88b0282 to
56aee51
Compare
|
|
…click test Review of #23886: the schema export and its stamp still carried #22822's help text, and the revert deleted LinkRouterCmdClickTests with the Cmd-click-in-background test #22990 had added to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2d-622e-7433-aed6-f3c248542f5d&host=cosmic-gray
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2d-622e-7433-aed6-f3c248542f5d&host=cosmic-gray
Default changesNo defaults change at |
The generated-file merge driver kept this branch's older exports over the base's, which dropped sidebar.showLocalMachine and voiceInput from them; the string catalog gets only the revert's 21 strings on top of the base's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2d-622e-7433-aed6-f3c248542f5d&host=cosmic-gray
…evert-22822 # Conflicts: # Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/ClickedLinkFocusTests.swift
|
Review (subagent, correctness first): SHIP at db98c4e Reviewer: Codex at xhigh, a different model from this lane's Claude. It reviewed the source diff against base 80d19e4, with #22822's own diff (7997e21) for comparison.
An independent Claude subagent also said SHIP at this head. It checked that the generated settings exports equal base plus the The fleet
The fleet package suites are still queued. |
Generated settings files: base copies plus only this PR's layout.linkPlacement help text, stamp lines recomputed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
134c184 to
dcfe8de
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (subagent, correctness first): SHIP at dcfe8de This head only merges base a986daa, because the earlier head no longer merged cleanly. The PR's diff against base is the same as the diff reviewed at db98c4e: the source files match apart from hunk line offsets, and the generated settings files are base plus the The fleet |
|
base-red-watch: |
…nkOpener.open (removed by #23886), so CmuxNext tests compile
…revert (fix the base's test build)










































![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, 2026-10-21, about his agent pane: "HOW COULD ANYBODY HAVE POSSIBLY THOUGHT OPENING A NEW TAB IN HERE BY DEFAULT WAS ACCEPTABLE". Also: "#22822 was SO STUPID. I was saying the OPENING TAB ANIMATION starts on the LEFT then continues on the RIGHT." Earlier: "WHY THE FUCK DID THIS NOT OPEN TO TEH SIDE", and "BY DEFAULT THINGS GOING TO THE RIGHTMOST SPLIT IS THE THING TO TRY AS DEFAULT".
This reverts #22822 (7997e21) completely. #22822 made everything a chat, Home or a page opens become a tab in that page's own pane. After this PR:
layout.linkPlacementsays, as it did before cmux-next: what a page opens is a tab in its pane; Cmd-click still opens right #22822: the pane on the right, else a new split. Nothing opens as a tab over the chat.cmdClickplumbing throughLinkRouter,LinkOpener,TerminalHostDelegateandBrowserPageRequests, thelinks.pagesFollowPlacementDebug toggle, its settings help (in every locale and in the MDM docs), its release note andLinkRouterCmdClickTests.newTab.picksFollowLinksagain (default off: a pick takes the page's place, Leo 10-20).schemas/settingsexport and its source stamp carry the restored help text.LinkRouterBackgroundClickTestskeeps the Cmd-click-in-background test that cmux-next: a clicked link's tab takes the focus; closing it gives the focus back #22990 had added to the deleted file.ClickedLinkFocusTests' in-pane case now sets Same Pane explicitly. Its file-link test waits for the daemon's tab, not the split's pending one; it timed out on that pending id once links split right.Setting: the default for everyone is on the right (Leo: "DEFAULT ON THE RIGHT ... EVERYBODY IS SAYING OPEN DEFAULT ON THE RIGHT"). Opening in the agent pane is opt-in: Settings > Open Links and Files > Same Pane (
layout.linkPlacement: "same-pane"). Tabs can always be dragged into the main pane; showing the main pane's tab bar is its own PR. Cmd-T and + from an agent pane follow the same setting in #23882.The "rightmost split" refinement (more than one split on the right) comes in a follow-up PR on top of this, so the revert can land now. The animation half of Leo's complaint is its own PR.
Austin's #23032 also edits
LinkOpener.swiftand is untouched.Leo-ask: ask-643a61d42a
Leo-ask: ask-5cd21f70eb
No capture: a revert to the behaviour before #22822; the link tests pin where the tab lands.
Agent session: cosmic-gray
🤖 Generated with Claude Code