Repository navigation
webviews: base reds: label the Chief and channel sheet fields; gallery plays wait out a cold Vite - #20695
Conversation
cfaa899 left seven jsx-a11y(control-has-associated-label) warnings in react-apps-check: the fields sit inside labels oxlint does not count. Each now carries its label text as aria-label too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bead |
Gallery16 states changed: pages.home-channels/run-open, pages.home-channels/attachments-composer, pages.home-channels/composer, pages.home-channels/emoji, pages.home-channels/emoji-return, ... · 7 play checks failed Diff page and renders (the run's
10 more on the diff page. Live preview (follows this branch; start it with
Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):
32 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes. |
This comment has been minimized.
This comment has been minimized.
|
all web/size checks green |
|
Passes: CI passes on CI passes on Written by |
|
|
…-channels-a11y-labels
The first page of each composer play file waits on Vite compiling the gallery, which takes over 30 s on a busy runner: composer-search-files-key and composer-capture failed their first case on the readiness wait alone (the play passes once the frame is ready). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The same first-page readiness timeout as #20681's composer plays hit worktree-creating, instructions-notice and new-tab-add-project-layer (30 s Playwright default; their test timeout is already 120 s). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
teamleaderleo
changed the title
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/38614968020 at 0b83e73 failed: cmux-next Release compile (Xcode 26). |
No bead (base reds). This PR bundles the base-red repairs that were left, so one PR's
web / react-apps-checkcan go fully green under the feat gate (coordinator's call). #20688, the third repair, merged first.What
1. Chief and channel sheet lint.
cfaa8995left sevenjsx-a11y(control-has-associated-label)warnings, andvp checkfails on warnings. Every flagged field already sits inside a<label>with visible text, which this oxlint rule does not count. Each field now also has its label text asaria-label, using the same string keys:There are no new strings, and what a screen reader reads is unchanged.
2. Gallery plays on a cold Vite. The first page of a play file waits on Vite compiling the gallery. On a busy runner that takes over 30 s, which is Playwright's default timeout, so the first case failed on the readiness wait alone.
Testing
bun run check: passes, with no warnings in 1353 files.bun test test/theme-colors.test.ts: passes on the merged base, which includes webviews: composer surface lifts toward a theme token, not literal white (base red from #20561) #20688.Changelog
none
🤖 Generated with Claude Code