Repository navigation
acpmux: move the hub's startup into hub/startup.rs (move only; hub/mod.rs under 1000 lines) - #20686
Conversation
…d.rs under 1000 lines) begin_startup, finish_startup, after_login_env, startup_complete, wait_startup and verify_launchers move verbatim from hub/mod.rs into an impl Hub in hub/startup.rs. No logic changes: the only edit is wait_startup's visibility, pub(super) to pub(crate), which keeps the same reach from the new, deeper module. hub/mod.rs goes from 1003 to 888 lines, clearing the Rust god-file check for any PR that touches it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bead |
|
Hosted Rust verify on this head (c7cd706): lint (linux), which includes the god-file check, test (linux) and the aarch64-apple-darwin build all passed. The macOS lint and tests job was still queued (no runner) after about 90 min and was not run; this is a move-only change and it compiles on macOS. Run: https://github.com/manaflow-ai/cmux/actions/runs/38602056080. PR checks: 77/77 green. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/38614968020 at 0b83e73 failed: cmux-next Release compile (Xcode 26). |
No bead: base red, coordinator request.
cmux-tui/crates/acpmux/src/hub/mod.rshad grown to 1003 lines on feat-cmux-next, over the Rust god-file limit of 1000 and not in the baseline. Any PR that touched the file failed hostedlint (linux)on the Rust god-file check ("split it").Move only, no logic changes. The hub's startup group moves verbatim from
hub/mod.rsinto animpl Hubblock in the newhub/startup.rs:begin_startupfinish_startupafter_login_envstartup_completewait_startupverify_launchersThe only edit inside the moved code is
wait_startup's visibility,pub(super)→pub(crate). Inhub/mod.rs,pub(super)meant visible to the crate; from the deeperhub/startup.rsthe same reach needspub(crate). The new file adds only a module comment, fouruselines and theimpl Hub {}wrapper.hub/mod.rsgainsmod startup;.A line-multiset diff of the old file against the two new ones shows no other removed or added lines.
hub/mod.rs: 1003 → 888 lines.Testing
rustfmt --checkon both files; crash ratchet OK.verify-cmux-tui-hosted.sh(lint, build, tests, with thelogin_envfilter, which runs the startup tests): results below.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Refactors the hub module by moving the startup group into a new
hub/startup.rs, bringinghub/mod.rsfrom 1003 to 888 lines and clearing the 1000-line god-file lint check.This is a move-only change. The startup methods (
begin_startup,finish_startup,after_login_env,startup_complete,wait_startup,verify_launchers) move verbatim into animpl Hubblock in the new file. The only edit iswait_startup's visibility frompub(super)topub(crate), which preserves the same reach from the deeper module.Written for commit c7cd706. Summary will update on new commits.