Skip to content

acpmux: move the hub's startup into hub/startup.rs (move only; hub/mod.rs under 1000 lines) - #20686

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/acpmux-hub-mod-split
Oct 14, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/acpmux-hub-mod-split

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

No bead: base red, coordinator request.

cmux-tui/crates/acpmux/src/hub/mod.rs had grown to 1003 lines on feat-cmux-next, over the Rust god-file limit of 1000 and not in the baseline. Any PR that touched the file failed hosted lint (linux) on the Rust god-file check ("split it").

Move only, no logic changes. The hub's startup group moves verbatim from hub/mod.rs into an impl Hub block in the new hub/startup.rs:

  • begin_startup
  • finish_startup
  • after_login_env
  • startup_complete
  • wait_startup
  • verify_launchers

The only edit inside the moved code is wait_startup's visibility, pub(super) → pub(crate). In hub/mod.rs, pub(super) meant visible to the crate; from the deeper hub/startup.rs the same reach needs pub(crate). The new file adds only a module comment, four use lines and the impl Hub {} wrapper. hub/mod.rs gains mod startup;.

A line-multiset diff of the old file against the two new ones shows no other removed or added lines.

hub/mod.rs: 1003 → 888 lines.

Testing

  • rustfmt --check on both files; crash ratchet OK.
  • Hosted verify-cmux-tui-hosted.sh (lint, build, tests, with the login_env filter, which runs the startup tests): results below.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Refactors the hub module by moving the startup group into a new hub/startup.rs, bringing hub/mod.rs from 1003 to 888 lines and clearing the 1000-line god-file lint check.

This is a move-only change. The startup methods (begin_startup, finish_startup, after_login_env, startup_complete, wait_startup, verify_launchers) move verbatim into an impl Hub block in the new file. The only edit is wait_startup's visibility from pub(super) to pub(crate), which preserves the same reach from the deeper module.

Written for commit c7cd706. Summary will update on new commits.

View guided diff Turn on auto-fix

…d.rs under 1000 lines)

begin_startup, finish_startup, after_login_env, startup_complete,
wait_startup and verify_launchers move verbatim from hub/mod.rs into an
impl Hub in hub/startup.rs. No logic changes: the only edit is
wait_startup's visibility, pub(super) to pub(crate), which keeps the same
reach from the new, deeper module. hub/mod.rs goes from 1003 to 888 lines,
clearing the Rust god-file check for any PR that touches it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo temporarily deployed to cmux-tui-merge-tree October 14, 2026 16:54 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a8199b29-e369-4f25-9979-099822e59f94

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-lmnmc created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Hosted Rust verify on this head (c7cd706): lint (linux), which includes the god-file check, test (linux) and the aarch64-apple-darwin build all passed. The macOS lint and tests job was still queued (no runner) after about 90 min and was not run; this is a move-only change and it compiles on macOS. Run: https://github.com/manaflow-ai/cmux/actions/runs/38602056080. PR checks: 77/77 green.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/38614968020 at 0b83e73 failed: cmux-next Release compile (Xcode 26).
Those jobs last passed at 72e64ec. This pull request is one of 5 merged since: #20707, #20695, #20696, #20689, #20686.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

This branch was previously deployed

2 inactive deployments
artifacts — c7cd706e Deployed Oct 14, 2026 by teamleaderleo via publish tree-addressed cmux-tui #14188
cmux-tui-merge-tree — c7cd706e Deployed Oct 14, 2026 by teamleaderleo via publish the merge tree #866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant