Repository navigation
webviews: composer surface lifts toward a theme token, not literal white (base red from #20561) - #20688
Conversation
…ral white (fixes theme-colors base red from #20561) --cmux-tone-light names the tonal scale's light end, the one place that keeps white (theme-fixed), as native ThemeTokens.opaqueOverlayFill mixes a light page toward .white. Same pixels in light themes; the dark branch is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bead |
|
Found 3 test failures on Blacksmith runners: Failures
|
|
all web/size checks green |
|
Passes: CI passes on CI passes on Written by |
|
|
Fixes the base red that #20561 introduced:
webviews/test/theme-colors.test.ts"a migrated stylesheet takes its colors from the theme" failed at the feat tip, becausecomposerStates.css:28mixed the light composer surface toward a literalwhite.--cmux-tone-lightinpages/shared/desktop.css: the light end of the tonal scale. It is the one place that keeps white, markedtheme-fixed, matching nativeThemeTokens.opaqueOverlayFill, which mixes a light page toward.white.--acpmux-composer-surfacenow mixes towardvar(--cmux-tone-light). Light themes paint the same pixels; the dark branch is unchanged.Testing
bun test test/theme-colors.test.tsfails on feat tip (coordinator's base-red report at c331694,composerStates.css:28literal white).#fff→#fffthrough a variable), so no recording.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
theme-colorstest failure from #20561 by lifting the light composer surface toward a shared theme token instead of a literal white.--cmux-tone-lightindesktop.css, the single theme-fixed place that keeps white, matching nativeThemeTokens.opaqueOverlayFill.--acpmux-composer-surfacenow mixes toward that token; light themes paint identical pixels and the dark branch is unchanged.Written for commit d4f0529. Summary will update on new commits.