Skip to content

webviews: composer surface lifts toward a theme token, not literal white (base red from #20561) - #20688

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
op-next-theme/composer-light-end
Oct 14, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
op-next-theme/composer-light-end

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the base red that #20561 introduced: webviews/test/theme-colors.test.ts "a migrated stylesheet takes its colors from the theme" failed at the feat tip, because composerStates.css:28 mixed the light composer surface toward a literal white.

  • New shared token --cmux-tone-light in pages/shared/desktop.css: the light end of the tonal scale. It is the one place that keeps white, marked theme-fixed, matching native ThemeTokens.opaqueOverlayFill, which mixes a light page toward .white.
  • --acpmux-composer-surface now mixes toward var(--cmux-tone-light). Light themes paint the same pixels; the dark branch is unchanged.

Testing

  • Red: bun test test/theme-colors.test.ts fails on feat tip (coordinator's base-red report at c331694, composerStates.css:28 literal white).
  • Green: the same command on this head passes, 7 pass, 0 fail.
  • No visual change: the computed color is identical (#fff → #fff through a variable), so no recording.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the theme-colors test failure from #20561 by lifting the light composer surface toward a shared theme token instead of a literal white.

  • Adds --cmux-tone-light in desktop.css, the single theme-fixed place that keeps white, matching native ThemeTokens.opaqueOverlayFill.
  • --acpmux-composer-surface now mixes toward that token; light themes paint identical pixels and the dark branch is unchanged.

Written for commit d4f0529. Summary will update on new commits.

View guided diff Turn on auto-fix

…ral white (fixes theme-colors base red from #20561)

--cmux-tone-light names the tonal scale's light end, the one place that keeps
white (theme-fixed), as native ThemeTokens.opaqueOverlayFill mixes a light page
toward .white. Same pixels in light themes; the dark branch is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c0138648-0e6a-44ad-a30b-1c97f0b338e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-edrgf created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 14, 2026

Copy link
Copy Markdown

Found 3 test failures on Blacksmith runners:

Failures

Test View Logs
test/composer-capture.test.ts/composer-capture.test View Logs
test/composer-search-files-key.test.ts/composer-search-files-key.test View Logs
test/new-tab-add-project-layer.test.ts/new-tab-add-project-layer.test View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

all web/size checks green

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Passes: CI passes on d4f0529f06.

CI passes on d4f0529f06 (run 38602744855 attempt 2).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards passes on d4f0529f06 (https://github.com/manaflow-ai/cmux/actions/runs/38602744855). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

@teamleaderleo
teamleaderleo merged commit a942c76 into feat-cmux-next Oct 14, 2026
128 of 134 checks passed
@teamleaderleo
teamleaderleo deleted the op-next-theme/composer-light-end branch October 14, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant