webviews: base red: composer gallery plays wait out a cold Vite by teamleaderleo · Pull Request #20681 · manaflow-ai/cmux

teamleaderleo · 2026-10-14T16:23:15Z

web / react-apps-check is red on base: the first case of composer-search-files-key.test.ts and of composer-capture.test.ts times out after 30 s waiting for the gallery frame to say it is ready. It also fails locally on a clean base.

The frame is not broken. A probe of the same frame reached ready and its play passed after about 20 s. The wait is cold Vite compiling the gallery for the first page, which takes over 30 s on a busy runner. The other cases in those files pass on the same frame.

This raises that first readiness wait to 90 s in the five composer play tests that share it. The play assertions are unchanged.

Changelog

none

🤖 Generated with Claude Code

The first page of each composer play file waits on Vite compiling the gallery, which takes over 30 s on a busy runner: composer-search-files-key and composer-capture failed their first case on the readiness wait alone (the play passes once the frame is ready). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cursor · 2026-10-14T16:23:20Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

coderabbitai · 2026-10-14T16:23:25Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 798c098f-b7fd-463c-83a4-aa93085ec581

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

teamleaderleo · 2026-10-14T16:26:16Z

Bead cx-16x82 created for this PR by the cmux coordinator.

github-actions · 2026-10-14T16:42:41Z

all web/size checks green

github-actions · 2026-10-14T16:42:59Z

Passes: CI passes on 268fff642c.

CI passes on 268fff642c (run 38615314141 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

github-actions · 2026-10-14T16:44:26Z

CI fast guards passes on 268fff642c (https://github.com/manaflow-ai/cmux/actions/runs/38615314141). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

#20561 mixes the light composer surface toward a literal white on purpose (lighter than the page, from the theme's page color), which the theme-colors ratchet counts as a fresh literal color. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cursor · 2026-10-14T16:51:22Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

github-actions · 2026-10-14T17:17:04Z

Gallery

Review in feed

139 states changed: agent-pane.transcript/web-video-loaded, agent-pane.artifact-panel/html, agent-pane.transcript/long-code, agent-pane.edited-files/fourteen-files, agent-pane.transcript/copy-last-code-block, ... · 54 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State	Before · after
agent-pane.transcript/web-video-loaded (Apple System Colors, webkit)
agent-pane.artifact-panel/html (Apple System Colors, chromium)
agent-pane.transcript/long-code (Apple System Colors Light, chromium)
agent-pane.edited-files/fourteen-files (Apple System Colors Light, chromium)
agent-pane.transcript/copy-last-code-block (Apple System Colors Light, webkit)
agent-pane.transcript/archive-chat-key (Apple System Colors Light, chromium)

133 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

agent-pane.transcript/web-video-loaded: /wt/leo-composer-play-cold-vite/?entry=agent-pane.transcript#/agent-pane.transcript/web-video-loaded
agent-pane.artifact-panel/html: /wt/leo-composer-play-cold-vite/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/html
agent-pane.transcript/long-code: /wt/leo-composer-play-cold-vite/?entry=agent-pane.transcript#/agent-pane.transcript/long-code
agent-pane.edited-files/fourteen-files: /wt/leo-composer-play-cold-vite/?entry=agent-pane.edited-files#/agent-pane.edited-files/fourteen-files
agent-pane.transcript/copy-last-code-block: /wt/leo-composer-play-cold-vite/?entry=agent-pane.transcript#/agent-pane.transcript/copy-last-code-block
agent-pane.transcript/archive-chat-key: /wt/leo-composer-play-cold-vite/?entry=agent-pane.transcript#/agent-pane.transcript/archive-chat-key
76 more on the diff page

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

agent-pane.artifact-panel/html (Apple System Colors, chromium): play: no element for button "Open preview"
agent-pane.artifact-panel/versions (Apple System Colors, webkit): play: waitFor did not hold within 5000 ms
agent-pane.artifact-panel/versions (Apple System Colors Light, webkit): play: no element for button "Open preview"
agent-pane.artifact-panel/html (Apple System Colors Light, webkit): play: no element for button "Open preview"
agent-pane.thread-minimap/long-chat (Apple System Colors Light, webkit): play: waitFor did not hold within 5000 ms
agent-pane.new-chat-no-shift/send-to-streaming (Apple System Colors, chromium): step 2 press Enter: anchor .acpmux-model moved 53.4 px (limit 1); anchor .acpmux-context moved Infinity px (limit 1)
273 more on the diff page

334 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

_{1743 unchanged · base 1351a5c · head f79c943}

# Conflicts: # webviews/src/agent-session/acpmux/composerStates.css

The same first-page readiness timeout as #20681's composer plays hit worktree-creating, instructions-notice and new-tab-add-project-layer (30 s Playwright default; their test timeout is already 120 s). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo · 2026-10-14T18:02:37Z

#20695 now carries this PR's cold-Vite commit (ee90f94), cherry-picked, and extends the same 90 s first wait to three more play files that failed the same way. The coordinator asked for the bundle so that one PR's react-apps-check can go fully green under the feat gate. f79c943 (composer lift marked theme-fixed) was not carried, because #20688 already fixed that red on base. I'm leaving this PR open for its lane to close.

…y plays wait out a cold Vite (no bead) (#20695) Bundles the base-red repairs: Chief/channel sheet lint labels, and the cold-Vite gallery play waits (cherry-picked from #20681, extended to three more files). Co-authored-by: Leo Li <cheerleaderleo@outlook.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…6fbz) (#20733) * test: a webviews test file can declare a longer limit (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: editor-page declares a 240 s limit; the runner honors per-file limits (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: browser tests warm their Vite server before the first page load (cx-v6fbz) Vite prints its port before it has transformed a module, so a test's first goto paid for the whole module graph inside its 30 s navigation timeout. On a busy CI runner that failed chat-find and text-field-focus (#20697), and the gallery-frame and agent-pane browser warm-ups hit the same wait (#20681). warmDevServer requests the page and every module it imports first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: diff-virtualization clicks a tree row only while it is still under the pointer (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: react-apps-check job cap 30 -> 40 min (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: the composer browser tests new on base warm their Vite server too (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * check: a test that starts a Vite dev server must warm it (cx-v6fbz) The browser-lane check now fails a test file that starts a dev server (vite.listen() or a vp dev spawn) without warmViteServer/warmDevServer. On base it flags 80 of 240 test files; on this head none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: a declared webviews file limit never shortens the default (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: the longer of a declared and the default webviews file limit wins (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: review follow-ups: settings-scroll warms after its readiness poll; the diff row check climbs out of shadow roots (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: agent-pane-bottom-stack (new on base) warms its Vite server (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: text-field-focus declares a 240 s limit; its gallery warm-up and 22 loads took about 115 s (cx-v6fbz) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: move the react-apps-check cap raise to its own PR The ci-web.yml edit widens this PR's web scope to the web/ unit shards, which are red on base. The cap raise lands separately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: give dev-server files 240 s and settle abandoned warm-up visits Review follow-up: the spawned-server files and menu-focus warm the whole gallery graph before their browser warm-up, which can pass the default 120 s file limit on a loaded runner. A failed warm-up visit no longer leaves the other in-flight visits as unhandled rejections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This comment has been minimized.

Sign in to view

teamleaderleo changed the title ~~webviews: base red: composer gallery plays wait out a cold Vite~~ webviews: base reds: composer plays wait out a cold Vite; composer lift marked theme-fixed Oct 14, 2026

Merge feat-cmux-next into leo-composer-play-cold-vite

9751731

# Conflicts: # webviews/src/agent-session/acpmux/composerStates.css

teamleaderleo changed the title ~~webviews: base reds: composer plays wait out a cold Vite; composer lift marked theme-fixed~~ webviews: base red: composer gallery plays wait out a cold Vite Oct 14, 2026

teamleaderleo mentioned this pull request Oct 14, 2026

webviews: base reds: label the Chief and channel sheet fields; gallery plays wait out a cold Vite #20695

Merged

Merge feat-cmux-next into leo-composer-play-cold-vite

268fff6

teamleaderleo merged commit 15ae5c7 into feat-cmux-next Oct 14, 2026
67 checks passed

teamleaderleo deleted the leo-composer-play-cold-vite branch October 14, 2026 19:44

teamleaderleo mentioned this pull request Oct 14, 2026

ci: warm Vite before browser tests, per-file limits, 40 min cap (cx-v6fbz) #20733

Merged

Navigation Menu

Repository navigation

webviews: base red: composer gallery plays wait out a cold Vite - #20681

webviews: base red: composer gallery plays wait out a cold Vite#20681
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
leo-composer-play-cold-vite

teamleaderleo commented Oct 14, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Oct 14, 2026

Uh oh!

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading

Review skipped

Uh oh!

teamleaderleo commented Oct 14, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

teamleaderleo commented Oct 14, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Uh oh!

cursor Bot commented Oct 14, 2026

Bugbot needs on-demand usage enabled

Uh oh!

coderabbitai Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

teamleaderleo commented Oct 14, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Oct 14, 2026

Bugbot needs on-demand usage enabled

Uh oh!

github-actions Bot commented Oct 14, 2026

Gallery

Uh oh!

teamleaderleo commented Oct 14, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 14, 2026 •

edited

Loading

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading