Skip to content

webviews: composer surface lifts toward a theme token, not literal white (base red from #20561) #20688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Oct 14, 2026
Merged

webviews: composer surface lifts toward a theme token, not literal white (base red from #20561) #20688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webviews/src/agent-session/acpmux/composerStates.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
lighter than the page (near white, as Aside's and ChatGPT's are); in a dark theme one small step
toward the text, as the theme's elevated surface. Solid, so it sits as chrome over a wallpaper. */
--acpmux-composer-surface: light-dark(
color-mix(in srgb, var(--cmux-surface-solid, var(--acpmux-base)) 35%, white),
color-mix(in srgb, var(--cmux-surface-solid, var(--acpmux-base)) 35%, var(--cmux-tone-light)),
color-mix(in srgb, var(--agent-text) 7%, var(--cmux-surface-solid, var(--acpmux-base)))
);
/* The composer's shadow (cg-design-judge, 10-14): the shared --elevation-1 in a light theme;
Expand Down
3 changes: 3 additions & 0 deletions webviews/src/pages/shared/desktop.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@
page zoom; the media query below is the value before it runs. */
--cmux-hairline: 1px;
--cmux-hairline-ring: 1px;
/* The light end of the tonal scale: what a light theme's raised surfaces lift toward, as the
native opaque fill does (`ThemeTokens.opaqueOverlayFill` mixes a light page toward white). */
--cmux-tone-light: #fff; /* theme-fixed: the tonal scale's light end, as native ThemeTokens */
/* The highlighted row of a menu, list or palette (keyboard or pointer): a tint one step past
hover (the text at about 6%), never a ring and never the accent's selection tint. The left
bar in the theme accent is an option, 0 (off) by default. */
Expand Down
Loading