cmux NEXT: retire tabs.hiddenButtons; the pane's "…" lists every action by teamleaderleo · Pull Request #20144 · manaflow-ai/cmux

teamleaderleo · 2026-10-13T04:06:02Z

Summary

Since the pane's hover "…" replaced its buttons (#20119), nothing reads tabs.hiddenButtons (the action ids right-clicked off the old row). This retires it the way tabs.newTabKind was retired:

SettingsSchema.retiredKeys lists it. An old cmux.json still loads, with no diagnostic, and settings.set answers that it was removed.
Removed: PaneToolbarSetting, its schema row and parse, the agent-settable entry, and the two catalog strings.
Regenerated on the merged head: the settings schema, the MDM exports (docs/mdm/*) and the settings page strings. These changes only remove entries. Base's exports still listed tabs.newTabKind, which cx-39b5r: New Tab always lands on the New Tab page; drop the template dots #20127 retired in Swift, so those rows go too.

Verification

PaneToolbarHiddenButtonsRetiredTests (fleet run-swift-testing-suites.sh):

Red on 62c8440: all 4 expectations failed:
- a diagnostic was raised at tabs.hiddenButtons;
- retiredKeys was [];
- Settings still had the row;
- isRetired was false.
Green on e4ae910: the full package suite and a Release compile on that head (receipts in a comment).
Exports: fleet export-settings-artifacts.sh on the merged head, then bun run strings:settings. Compared with base, the only keys removed are tabs.hiddenButtons and tabs.newTabKind, and nothing is added.
Review: subagent review found no Swift issues. Its one finding: cmux-tui's hand-copied retired-key table (cmux-tui/crates/cmux-config/src/schema/retired.rs) lacks this key and tabs.newTabKind. That follows in a separate Rust PR.

Changelog

Removed: The tabs.hiddenButtons setting. The pane's "…" menu lists every action.

🤖 Generated with Claude Code

…s without a diagnostic Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Nothing has read it since the hover "…" replaced the pane's buttons (#20119). An old file loads without a diagnostic and settings.set says it was removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

) #20128 dropped Split Right/Down from a New Tab page pane's "…" and left this expectation red on base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Fleet export-settings-artifacts.sh at 324afbe, then strings:settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-13T04:06:13Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: ee028b27-0b69-4482-99fe-87bb68a2f71b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

blacksmith-sh · 2026-10-13T04:18:21Z

Found 2 test failures on Blacksmith runners:

Failures

Test	View Logs
`test/agent-pane-no-capsules.test.ts/agent-pane-no-capsules.test`	View Logs
`test/model-chip-fresh-chat.test.tsx/model-chip-fresh-chat.test.tsx`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

github-actions · 2026-10-13T04:18:35Z

Unclear: web / react-apps-check failed: no known signature; failed step: Verify webviews source checks.

CI failed on 861090f584 (run 38348060701 attempt 1): 1 unknown.
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped.

Job	Verdict	Why
web / react-apps-check	unknown	no known signature; failed step: `Verify webviews source checks`

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

github-actions · 2026-10-13T04:19:08Z

CI fast guards failed on 861090f584 (https://github.com/manaflow-ai/cmux/actions/runs/38348060701). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

…toolbar/drop-hidden-buttons # Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextSettings/ChromePlacementSetting.swift

Fleet export-settings-artifacts.sh at 0635e3f, then strings:settings. Also drops base's stale tabs.newTabKind rows (retired in Swift by #20127). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…New Tab page's "…" Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cursor · 2026-10-13T04:28:16Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

teamleaderleo · 2026-10-13T04:45:29Z

Receipts on e4ae910bd399: fleet run-swift-testing-suites.sh Packages/macOS/CmuxNext step 7fc0122986e8af6bf36acb2b exited 0, with all 254 suites passing, PaneToolbarHiddenButtonsRetiredTests included. Release compile (check-release-compile.sh) step bce3bd1288b7ecabbf61aba7 exited 0.

…toolbar/drop-hidden-buttons

github-actions · 2026-10-13T05:43:32Z

Gallery

Review in feed

213 states changed: agent-pane.artifact-panel/html, agent-pane.artifact-panel/versions, agent-pane.artifact-panel/markdown, gallery.visual-media-board/all-previews, pages.settings/curated-art, ... · 2 new states · 51 broken states · 100 play checks failed

Diff page and renders (the run's gallery-pr artifact)

State	Before · after
agent-pane.artifact-panel/html (Apple System Colors, webkit)
agent-pane.artifact-panel/versions (Apple System Colors, chromium)
agent-pane.artifact-panel/markdown (Apple System Colors, webkit)
gallery.visual-media-board/all-previews (Apple System Colors Light, chromium)
pages.settings/curated-art (Apple System Colors Light, chromium)
agent-pane.transcript/long-code (Apple System Colors, chromium)

207 more on the diff page.

Live preview (follows this branch; start it with scripts/gallery-live.sh up <branch> from an hq checkout):

agent-pane.artifact-panel/html: /wt/op-next-toolbar-drop-hidden-buttons/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/html
agent-pane.artifact-panel/versions: /wt/op-next-toolbar-drop-hidden-buttons/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/versions
agent-pane.artifact-panel/markdown: /wt/op-next-toolbar-drop-hidden-buttons/?entry=agent-pane.artifact-panel#/agent-pane.artifact-panel/markdown
gallery.visual-media-board/all-previews: /wt/op-next-toolbar-drop-hidden-buttons/?entry=gallery.visual-media-board#/gallery.visual-media-board/all-previews
pages.settings/curated-art: /wt/op-next-toolbar-drop-hidden-buttons/?entry=pages.settings#/pages.settings/curated-art
agent-pane.transcript/long-code: /wt/op-next-toolbar-drop-hidden-buttons/?entry=agent-pane.transcript#/agent-pane.transcript/long-code
134 more on the diff page

Play checks failed (0 px anchor movement, 0 layout shift, no frame over 33 ms unless the entry gives a reason):

agent-pane.artifact-panel/html (Apple System Colors, webkit): play: no element for button "Open preview"
agent-pane.artifact-panel/versions (Apple System Colors, chromium): play: no element for button "Open preview"
agent-pane.artifact-panel/markdown (Apple System Colors, webkit): play: no element for button "Open preview"
gallery.visual-media-board/all-previews (Apple System Colors Light, chromium): step 1 click button "Pause previews": layout shift 0.0002 (limit 0) · step 2 click button "Play previews": layout shift 0.0002 (limit 0) · play: waitFor did not hold within 5000 ms
agent-pane.artifact-panel/versions (Apple System Colors Light, chromium): play: no element for button "Open preview"
agent-pane.artifact-panel/markdown (Apple System Colors Light, webkit): play: no element for button "Open preview"
528 more on the diff page

566 nondeterministic states differed from a second render of the same head (a clock or fixture leak) and are not counted as changes.

_{6348 unchanged · base b392213 · head 861090f}

teamleaderleo and others added 4 commits October 12, 2026 20:57

test(settings): tabs.hiddenButtons is a retired key; an old list load…

62c8440

…s without a diagnostic Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

settings: retire tabs.hiddenButtons; the pane's "…" lists every action

324afbe

Nothing has read it since the hover "…" replaced the pane's buttons (#20119). An old file loads without a diagnostic and settings.set says it was removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(pane toolbar): the New Tab page's "…" leaves the splits out (#20128

eaa5d0c

) #20128 dropped Split Right/Down from a New Tab page pane's "…" and left this expectation red on base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

settings: regenerate the exports without tabs.hiddenButtons

344546c

Fleet export-settings-artifacts.sh at 324afbe, then strings:settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo temporarily deployed to cmux-tui-merge-tree October 13, 2026 04:06 — with GitHub Actions Inactive

Merge commit '9fdedb77a93b80a0457e0bada58e6b840601f2d2' into op-next-…

0635e3f

…toolbar/drop-hidden-buttons # Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextSettings/ChromePlacementSetting.swift

teamleaderleo temporarily deployed to cmux-tui-merge-tree October 13, 2026 04:20 — with GitHub Actions Inactive

settings: regenerate the exports on the merged head

d28e676

Fleet export-settings-artifacts.sh at 0635e3f, then strings:settings. Also drops base's stale tabs.newTabKind rows (retired in Swift by #20127). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo temporarily deployed to cmux-tui-merge-tree October 13, 2026 04:25 — with GitHub Actions Inactive

test(pane toolbar): follow base again; #20143 kept the splits in the …

e4ae910

…New Tab page's "…" Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo temporarily deployed to cmux-tui-merge-tree October 13, 2026 04:28 — with GitHub Actions Inactive

Merge commit 'b3922133e10415728362df09b34c03b5d59518ca' into op-next-…

861090f

…toolbar/drop-hidden-buttons

teamleaderleo temporarily deployed to cmux-tui-merge-tree October 13, 2026 04:46 — with GitHub Actions Inactive

teamleaderleo merged commit 0b87965 into feat-cmux-next Oct 13, 2026
100 of 102 checks passed

teamleaderleo deleted the op-next-toolbar/drop-hidden-buttons branch October 13, 2026 04:58

teamleaderleo temporarily deployed to artifacts October 13, 2026 05:08 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to artifacts October 13, 2026 05:18 — with GitHub Actions Inactive

teamleaderleo mentioned this pull request Oct 13, 2026

cmux-tui: refuse tabs.newTabKind and tabs.hiddenButtons as removed, and keep the retired keys in step with the app #20219

Closed

Navigation Menu

Repository navigation

cmux NEXT: retire tabs.hiddenButtons; the pane's "…" lists every action - #20144

cmux NEXT: retire tabs.hiddenButtons; the pane's "…" lists every action#20144
teamleaderleo merged 8 commits into
feat-cmux-nextfrom
op-next-toolbar/drop-hidden-buttons

teamleaderleo commented Oct 13, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading

Review skipped

Uh oh!

blacksmith-sh Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Oct 13, 2026

Uh oh!

teamleaderleo commented Oct 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Changelog

Uh oh!

coderabbitai Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

blacksmith-sh Bot commented Oct 13, 2026

Failures

Uh oh!

github-actions Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Oct 13, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

teamleaderleo commented Oct 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 13, 2026

Gallery

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 13, 2026 •

edited

Loading

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading

github-actions Bot commented Oct 13, 2026 •

edited

Loading

github-actions Bot commented Oct 13, 2026 •

edited

Loading