Skip to content

cmux-next: keep composer splits out of ellipsis menu - #20128

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
codex/cx-split-menu
Oct 13, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
codex/cx-split-menu

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The agent composer no longer puts Split Right or Split Down in its ellipsis menu. Their existing keyboard bindings and drag targets remain unchanged.

Changelog

Changed: keep the agent composer's Split Right and Split Down actions out of the ellipsis menu.

Verification

  • git diff --check
  • ./scripts/localize-changes --base origin/feat-cmux-next (blocked by existing catalog needs_review entries and base localization parity/default mismatches)
  • No new unit test added per cmux-next policy; hosted Swift CI is the landing gate.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Keeps the agent composer's Split Right and Split Down actions out of its ellipsis menu without changing their key bindings or drag targets.

Written for commit ed273bd. Summary will update on new commits.

View guided diff Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: cf4327a8-328d-4988-bdfa-827b197b6bad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on ed273bd2f6; ci-status is green without them.

CI passes on ed273bd2f6 (run 38341557373 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo
teamleaderleo merged commit 8779983 into feat-cmux-next Oct 13, 2026
87 checks passed
@teamleaderleo
teamleaderleo deleted the codex/cx-split-menu branch October 13, 2026 03:31
teamleaderleo added a commit that referenced this pull request Oct 13, 2026
)

#20128 dropped Split Right/Down from a New Tab page pane's "…" and left this expectation red on base.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Oct 13, 2026
…on (#20144)

* test(settings): tabs.hiddenButtons is a retired key; an old list loads without a diagnostic

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* settings: retire tabs.hiddenButtons; the pane's "…" lists every action

Nothing has read it since the hover "…" replaced the pane's buttons (#20119). An old file
loads without a diagnostic and settings.set says it was removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(pane toolbar): the New Tab page's "…" leaves the splits out (#20128)

#20128 dropped Split Right/Down from a New Tab page pane's "…" and left this expectation red on base.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* settings: regenerate the exports without tabs.hiddenButtons

Fleet export-settings-artifacts.sh at 324afbe, then strings:settings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* settings: regenerate the exports on the merged head

Fleet export-settings-artifacts.sh at 0635e3f, then strings:settings. Also drops base's stale
tabs.newTabKind rows (retired in Swift by #20127).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(pane toolbar): follow base again; #20143 kept the splits in the New Tab page's "…"

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant