Skip to content

fix: restore pane ellipsis split actions - #20143

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/cx-20128-base-red
Oct 13, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/cx-20128-base-red

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Restore Split Right and Split Down to the pane ellipsis menu. The agent composer header menu remains split-free; its split controls remain on the dedicated header actions, keyboard bindings, and drag targets.

Changelog

Fixed: restore pane ellipsis Split Right and Split Down actions.

Verification

  • git diff --check
  • Confirmed the composer ChatHeaderTools menu rows contain no split actions.
  • No new unit test added per cmux-next policy; hosted Swift CI is the landing gate.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Restores the Split Right and Split Down actions to the pane ellipsis menu.

  • Removes the filter that excluded these actions for new tabs.
  • The agent composer header menu is unchanged; its split controls remain on the dedicated header actions, keyboard bindings, and drag targets.

Written for commit 402c7e8. Summary will update on new commits.

View guided diff Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7245736f-ffde-475d-90bd-21235feb70f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on 402c7e8e89; ci-status is green without them.

CI passes on 402c7e8e89 (run 38344401208 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo
teamleaderleo merged commit 9208ab0 into feat-cmux-next Oct 13, 2026
87 checks passed
@teamleaderleo
teamleaderleo deleted the codex/cx-20128-base-red branch October 13, 2026 04:07
teamleaderleo added a commit that referenced this pull request Oct 13, 2026
…New Tab page's "…"

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Oct 13, 2026
…on (#20144)

* test(settings): tabs.hiddenButtons is a retired key; an old list loads without a diagnostic

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* settings: retire tabs.hiddenButtons; the pane's "…" lists every action

Nothing has read it since the hover "…" replaced the pane's buttons (#20119). An old file
loads without a diagnostic and settings.set says it was removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(pane toolbar): the New Tab page's "…" leaves the splits out (#20128)

#20128 dropped Split Right/Down from a New Tab page pane's "…" and left this expectation red on base.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* settings: regenerate the exports without tabs.hiddenButtons

Fleet export-settings-artifacts.sh at 324afbe, then strings:settings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* settings: regenerate the exports on the merged head

Fleet export-settings-artifacts.sh at 0635e3f, then strings:settings. Also drops base's stale
tabs.newTabKind rows (retired in Swift by #20127).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(pane toolbar): follow base again; #20143 kept the splits in the New Tab page's "…"

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant