Repository navigation
cmux-tui: refuse tabs.newTabKind and tabs.hiddenButtons as removed, and keep the retired keys in step with the app - #20219
teamleaderleo wants to merge 5 commits into
Conversation
… reason Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…toolbar/tui-retired-parity
…moved, as the app does Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…es; it fails on an entry it cannot read Adds SettingsSchema+Retired.swift (and base's missing design-tokens.json) to the cmux-tui tree key and the artifacts workflow paths (check_cmux_tui_tree_inputs.py), so a Swift-only retirement runs this test. Review finding on #20219. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Superseded by c07c598 (cx-d5b5d) on feat-cmux-next. |
Summary
The settings export leaves retired keys out, so cmux-tui keeps its own copy of the app's retired-key list (
cmux-config/src/schema/retired.rs). That copy had fallen behind.tabs.newTabKind(#20127) andtabs.hiddenButtons(#20144) were retired in the app but not here. With no schema row and no retired entry for them, a cmux-tuisettings seton either key went down the unknown-path branch, which can write a value nothing reads. The app refuses it as removed.tests/retired_parity.rsreads the app'sretiredKeysliteral (SettingsSchema+Retired.swift, viainclude_str!) and compares keys and reasons withRETIRED_KEYS, so the next key the app retires fails here until it is mirrored.Verification
every_key_the_app_retired_is_refused_here_with_its_reason, run withscripts/verify-cmux-tui-hosted.sh --filter:appearance.tabBarBackgroundandupdates.quietHours; the right side also hadtabs.hiddenButtonsandtabs.newTabKind.Changelog
Fixed: cmux-tui refuses
settings seton the removedtabs.newTabKindandtabs.hiddenButtonskeys, as the app does.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Makes
settings setreject removedtabs.newTabKindandtabs.hiddenButtonsas removed, matching the app instead of writing unused values.Written for commit 071607a. Summary will update on new commits.