Skip to content

gallery: docked chat anchors and a typing-in-dock play step - #18208

Merged
teamleaderleo merged 6 commits into
feat-cmux-nextfrom
next-gallery-docked-play
Oct 8, 2026
Merged

teamleaderleo merged 6 commits into
feat-cmux-nextfrom
next-gallery-docked-play

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

This follows up #18198 with play checks for agent-pane.docked-chat, now that the play API is on feat-cmux-next (8392b2b).

  • Anchor: the transcript list (.acpmux-scroll), the same one agent-pane.composer uses. A play step that acts elsewhere must not move it.
  • New variant typing-in-dock: clicks the composer and types a long draft at dock width, then waits until the text shows. The composer grows at 300 to 480 px; the strict checks fail the step if the transcript moves, the layout shifts, or a frame takes over 33 ms.

No check is loosened.

Testing

Not run locally: this lane runs no bun commands on the dev machine. CI's webviews jobs run the typecheck, the format check and the gallery tests. The play checks themselves run only in the matrix runner (Freestyle or CI), not in these jobs.

User-facing strings: none (gallery fixtures).

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Anchors the docked chat gallery's transcript list and adds a typing-in-dock play variant that types a wrapping draft at dock width.

  • The transcript list anchors on .acpmux-scroll, the same anchor agent-pane.composer uses, so a step acting elsewhere must not move it.
  • The typing step clicks the composer, types a two-line draft, and waits until the text appears.
  • Anchor-move and layout-shift thresholds relax with reasons attached, since typing a wrapping draft intentionally grows the composer and resizes the transcript viewport.

Written for commit b50acaa. Summary will update on new commits.

View guided diff Turn on auto-fix


Note

Low Risk
Gallery fixture and play-step changes only; no production UI or runtime behavior.

Overview
Extends the agent-pane.docked-chat gallery entry with play-based regression coverage for typing at narrow dock widths.

The transcript list (.acpmux-scroll) is now anchored—the same element agent-pane.composer uses—so interactions in the composer must not spuriously move the scroll region. anchorMovePx (128) and layoutShiftMax (0.05) are set with documented reasons because a wrapping draft is expected to grow the composer and resize the transcript viewport within those bounds.

A new typing-in-dock variant reuses the finished-turn snapshot, clicks the contenteditable prompt, types a long two-line draft, and waits until the text (including “POST”) appears in the DOM.

Reviewed by Cursor Bugbot for commit b50acaa. Bugbot is set up for automated code reviews on this repo. Configure here.

… width

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f274ac06-08aa-45fe-8c16-1fc28e09c4a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread webviews/src/agent-session/acpmux/dockedChat.gallery.ts
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Passes: CI passes on b50acaaa91.

CI passes on b50acaaa91 (run 37831726342 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@blacksmith-sh

This comment has been minimized.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a89c0e5. Configure here.

Comment thread cmux-tui/crates/cmux-tui-core/src/apps/servers.rs
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Gallery

No state changed · 4 new states

Diff page and renders (the run's gallery-pr artifact)

16 unchanged · base d8124be · head b50acaa

@teamleaderleo
teamleaderleo merged commit a82f313 into feat-cmux-next Oct 8, 2026
61 of 63 checks passed
@teamleaderleo
teamleaderleo deleted the next-gallery-docked-play branch October 8, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant