Repository navigation
gallery: docked chat anchors and a typing-in-dock play step - #18208
Conversation
… width Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Passes: CI passes on CI passes on Written by |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a89c0e5. Configure here.
GalleryNo state changed · 4 new states Diff page and renders (the run's |

Summary
This follows up #18198 with play checks for
agent-pane.docked-chat, now that the play API is onfeat-cmux-next(8392b2b)..acpmux-scroll), the same oneagent-pane.composeruses. A play step that acts elsewhere must not move it.typing-in-dock: clicks the composer and types a long draft at dock width, then waits until the text shows. The composer grows at 300 to 480 px; the strict checks fail the step if the transcript moves, the layout shifts, or a frame takes over 33 ms.No check is loosened.
Testing
Not run locally: this lane runs no bun commands on the dev machine. CI's webviews jobs run the typecheck, the format check and the gallery tests. The play checks themselves run only in the matrix runner (Freestyle or CI), not in these jobs.
User-facing strings: none (gallery fixtures).
Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Anchors the docked chat gallery's transcript list and adds a
typing-in-dockplay variant that types a wrapping draft at dock width..acpmux-scroll, the same anchoragent-pane.composeruses, so a step acting elsewhere must not move it.Written for commit b50acaa. Summary will update on new commits.
Note
Low Risk
Gallery fixture and play-step changes only; no production UI or runtime behavior.
Overview
Extends the agent-pane.docked-chat gallery entry with play-based regression coverage for typing at narrow dock widths.
The transcript list (
.acpmux-scroll) is now anchored—the same element agent-pane.composer uses—so interactions in the composer must not spuriously move the scroll region. anchorMovePx (128) and layoutShiftMax (0.05) are set with documented reasons because a wrapping draft is expected to grow the composer and resize the transcript viewport within those bounds.A new
typing-in-dockvariant reuses the finished-turn snapshot, clicks the contenteditable prompt, types a long two-line draft, and waits until the text (including “POST”) appears in the DOM.Reviewed by Cursor Bugbot for commit b50acaa. Bugbot is set up for automated code reviews on this repo. Configure here.