Repository navigation
Split the remaining quality guard critical path - #13500
Merged
Merged
Conversation
teamleaderleo
enabled auto-merge (squash)
September 21, 2026 23:34
|
Warning Review limit reachedNext included review available in 13 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This was referenced Sep 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the single
qualitygroup insideworkflow-guard-testswith three independent groups:quality-sharding: cmuxTests sharding + compilation-cache seeding;quality-runtime: bundled-resource incremental outputs + virtual-display lock;quality-determinism: determinism and shell/shortcut policy checks.The outer reusable-workflow job remains
workflow-guard-tests, soguard-statusstill receives one fail-closed aggregate.Measured current matrix wall times show
qualityis the slowest remaining mixed-guard group at ~92s (app-host ~79s, release ~57s). Historical step timings put the biggest quality costs at ~19s sharding, ~19s determinism, ~12s bundled resources, and ~9s virtual display. These checks are independent, so splitting them removes serialization without reducing coverage.The structural assertion lives in a Linux-owned guard contract file rather than the router self-test, avoiding the accidental all-area fanout found while validating #13496/#13497.
Related: #13095, #13325, #13439, #13496, #13497.
Summary by cubic
Splits the single
qualityguard group inworkflow-guard-testsinto three independent groups (quality-sharding,quality-runtime,quality-determinism) so their checks run in parallel instead of serially. The outer reusable-workflow job is unchanged, soguard-statusstill sees one fail-closed aggregate. Adds a structural test that pins each quality check to its group and rejects the oldqualitygroup from reappearing.Written for commit 8b39b9c. Summary will update on new commits.