Repository navigation
Run mixed CI guards as parallel ownership groups - #13439
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 19 seconds. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
teamleaderleo
enabled auto-merge (squash)
September 21, 2026 20:17
This was referenced Sep 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the 100+ step
workflow-guard-testsserial lane into five concurrent ownership groups while keeping the same reusable-workflow job ID and aggregate result.Groups:
preflight: repository/config/schema/skill contracts that run before the Python 3.9 guard environment;ci: trust, routing, cache, merge-queue, and workflow contracts;app-host: xcodebuild/app-host/cache/test-runner contracts;release: TestFlight, nightly, Ghostty/Zig, notarization, Sparkle, and packaging contracts;quality: sharding, bundled-resource, virtual-display, shell, shortcut, and determinism checks.The existing
workflow-guard-testsjob becomes a matrix, soguard-statusstill gets one fail-closed aggregate result and existing tests that inspect the job keep the same owner.On the measured #13431 run the old mixed job was 191s wall time. The slowest independent checks included sharding (19s), determinism (19s), bundled resources (12s), iOS lane identity (10s), app-host retry (9s), virtual display (9s), and notarization (9s); this lets those run in parallel instead of serially.
Routing cleanup is separate in #13436. Web parallelism is separate in #13437.
Related: #13095, #13325.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Splits the 100+ step
workflow-guard-testslane into five concurrent matrix groups instead of one serial job, cutting the measured wall time from ~191s to the slowest group. The job keeps the same reusable-workflow ID and the fail-closed aggregate resultguard-statusrelies on; each step is gated bymatrix.groupand a new test pins a representative step per group.Matrix groups
preflight: repository, config, schema, and skill contracts before the Python 3.9 setup.ci: trust, routing, cache, merge-queue, and workflow contracts.app-host: xcodebuild, app-host, cache, and test-runner contracts.release: TestFlight, nightly, Ghostty/Zig, notarization, Sparkle, and packaging contracts.quality: sharding, bundled-resource, virtual-display, shell, shortcut, and determinism checks.Bun setup now runs unconditionally so every group can cover contracts that need it.
Written for commit 99aebb9. Summary will update on new commits.