Fix nightly build after Cloud provider merge

[austinywang]

Problem

Nightly Release builds fail in build-nightly-app after Cloud provider compatibility restores were merged on top of the already-restored implementations. Swift reports duplicate terminal I/O and terminal-close declarations, which blocks signing and publication for #12510.

Fix

• Keep one terminal I/O implementation in CmuxTuiSurfaceProvider+TerminalIO.swift, including the current stdin-based text delivery path and timeout handling.
• Keep the dedicated CmuxTuiSurfaceProvider+CloseTerminal.swift implementation and remove both stale copies from CmuxTuiSurfaceProviders.swift.
• Import CmuxCloudMachines where the pane fallback constructs DefaultCloudMachineStore.

This preserves the existing environment/file-delivery/terminal behavior while restoring one protocol implementation per method.

Fixes #12510.

Validation

• python3 scripts/swift_file_length_budget.py
• git diff --check

Per request, no local Xcode or test build was run; the hosted Nightly/Release check is the production proof gate.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Fixes the nightly build failing after the Cloud provider merge by removing duplicate terminal I/O and terminal-close declarations that Swift rejected.

• Keeps the single implementations in CmuxTuiSurfaceProvider+TerminalIO.swift and CmuxTuiSurfaceProvider+CloseTerminal.swift and removes the stale copies from CmuxTuiSurfaceProviders.swift.
• Adds a CmuxCloudMachines import in RightSidebarToolPanel.swift for the pane fallback's DefaultCloudMachineStore.
• Environment, file delivery, and terminal behavior are unchanged. Fixes Nightly build is failing on main #12510.

^{Written for commit 488c19a. Summary will update on new commits.}

Summary by CodeRabbit

• New Features

  • Added support for cloud machine functionality in the right sidebar tools.

• Changes

  • Terminal input and screen interaction now use the current streamlined handling for text entry, key commands, screen reading, and wait operations.
  • Terminal-closing support was removed from this surface provider; users may no longer be able to close terminals through this interface.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
cmux166	Building	Preview	Sep 13, 2026 10:35pm UTC
cmux41	Building	Preview	Sep 13, 2026 10:35pm UTC

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 461b5f15-66a8-4957-b151-458db4b04db0

📥 Commits

Reviewing files that changed from the base of the PR and between b73b602 and 488c19a.

📒 Files selected for processing (3)

• Sources/RightSidebarToolPanel.swift
• Sources/Surfaces/CmuxTuiSurfaceProvider+TerminalIO.swift
• Sources/Surfaces/CmuxTuiSurfaceProviders.swift

---

📝 Walkthrough

Walkthrough

The changes remove duplicate terminal I/O and terminal-close implementations from surface providers and add the CmuxCloudMachines module import to the right sidebar tool panel.

Changes

Build cleanup

Layer / File(s)	Summary
Terminal I/O implementation cleanup Sources/Surfaces/CmuxTuiSurfaceProvider+TerminalIO.swift	The earlier sendText, sendKeys, readScreen, and waitForScreen implementations were removed. The retained implementations remain.
Terminal close implementation cleanup Sources/Surfaces/CmuxTuiSurfaceProviders.swift	Both duplicate closeTerminal overload sets and their closeLocalPanes helpers were removed. The provider no longer implements terminal closing.
Cloud machines module wiring Sources/RightSidebarToolPanel.swift	The CmuxCloudMachines module import was added.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: lawrencecchen

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-12510-nightly-build-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}