Repository navigation
Revert "Cloud: recover terminal creation through first visible frame" - #12559
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (38)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 14, 2026
97f8a15 Merge pull request manaflow-ai#12359 from manaflow-ai/fix/12355-cloud-hover-x bb519c9 Merge pull request manaflow-ai#12559 from manaflow-ai/issue-12505-revert-cloud-recovery 71fed10 Merge pull request manaflow-ai#12546 from manaflow-ai/issue-12532-agent-notification-flaky 03049fd Merge origin/main into issue-12505-revert-cloud-recovery 11e2ee0 Merge pull request manaflow-ai#12558 from manaflow-ai/issue-12547-nightly-provider-duplicates 2646f8d fix: preserve Cloud rename helper after full revert cd7fe4c fix: centralize Cloud hover ownership 4415352 test: cover Cloud hover transitions b6048d7 fix: keep CI diagnostics Python 3.9 compatible 419cf0a Merge pull request manaflow-ai#12549 from manaflow-ai/issue-12536-cloud-reconnect-overlay d22862e fix: remove stray Cloud provider brace 11e7507 fix: remove stale provider extension brace 4d38e75 Revert "Merge pull request manaflow-ai#12505 from manaflow-ai/issue-12469-cloud-terminal-recovery" 7b0499c fix: parse app-host diagnosis options safely d62e535 Merge remote-tracking branch 'origin/main' into issue-12532-agent-notification-flaky 1d51466 fix: always report pre-test failures 0eafa93 test(cloud): cover reconnect card dismissal 4a8908b fix: preserve nonzero app-host test exits 231698f test: keep clean app-host exits red 024a915 fix: classify app-host crash markers correctly 4ef3406 test: classify app-host crash output 688d55e fix: keep per-suite test result bundles isolated ebb9a9a test: distinguish app-host crashes from assertions 458bcdc fix(cloud): use one reconnect presentation owner 925c933 ci: report semantic app-host failure categories 3cbffd0 test: cover semantic app-host failure reporting # Conflicts: # .github/workflows/test-depot.yml
This was referenced Sep 14, 2026
Merged
1 task
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #12505, “Cloud: recover terminal creation through first visible frame.” The rollback restores the pre-#12505 Cloud terminal creation and attachment path so opening a terminal does not depend on the newly introduced first-visible-frame readiness gate or deferred surface resolution.
Why
#12505 introduced a readiness contract requiring attachment, replay, and a visible renderer frame before the connection overlay cleared. The reported Nightly behavior included very slow or indefinitely stuck Cloud creation/reconnect overlays. The evidence supports rolling back that lifecycle change; it does not establish a runtime-confirmed single root cause.
Exact rollback scope
CloudTerminalReadiness*, startup loading/trace, and Cloud creation recovery/resolution types introduced by Cloud: recover terminal creation through first visible frame #12505.CloudTuiManualMirrorSessionattachment, the pre-revert connection presentation semantics, and the prior input/attachment lifecycle.Conflict adaptations
CloudWorkspaceRenameService.remoteNamehelper required by the still-present Cloud rename authority keeps layout and sidebar names in sync #12504 rename caller after the full file rollback; this is a mechanical compile/naming compatibility fix, not a new connection behavior.usableAttachmentClearsTheCardWithoutRendererObservations, which covers the returned connection path and input after replay without requiring a renderer observation.Validation
git revert -m 1 4f7aca22c6a094998d552029d5ec52f9b66eb4adcompleted; revert commit4d38e75a34.python3 scripts/check-package-resolved-policy.pypassed.python3 scripts/swift_file_length_budget.pypassed.bash scripts/check-pbxproj.shpassed.python3 -m json.tool Resources/Localizable.xcstringspassed.CMUX_DEV_BACKEND_MODE=offon the shared Mac fleet. The first attempt exposed the existing missingremoteNamenaming dependency; the compatibility commit2646f8d269addresses it. A follow-up build is queued behind a full fleet and remains pending.Remaining risks
This is an intentional full rollback. It may restore earlier missing-terminal, duplicate-creation, and blank-before-ready limitations that #12505 attempted to address. The revert does not claim those limitations are fixed. A remote isolated connect/reconnect smoke test is still pending capacity; spinner disappearance alone will not be treated as proof that terminal input/output works.
Base synchronization
After opening the PR, this branch was merged with
origin/mainat11e2ee0035(including the incoming #12536 reconnect presentation and #12547 provider duplicate cleanup). The merge kept the single reconnect presentation owner and provider deduplication while removing the startup loading overlay and all obsolete #12505 readiness references.