Removed duplicate line and added comment on variable#16138
Closed
gelanivishal wants to merge 18 commits intomagento:2.1-developfrom
Closed
Removed duplicate line and added comment on variable#16138gelanivishal wants to merge 18 commits intomagento:2.1-developfrom
gelanivishal wants to merge 18 commits intomagento:2.1-developfrom
Conversation
[Backport] Fixed Purchased Order Form button should visible properly
[Backport] Fixed set template syntax issue
[Backport] Updated font-size variable and standardize #ToDo UI
[Backport] Moved css from media #TODO
[Backport] Fixed typo error
[Backport] magento#14063 - Wrong invoice prefix in multistore setup due to default stor…
[Backport] set correct annotation
[Backport] magento#12820 - Wrong annotation in _toOptionArray - magento/framework/Data/…
[Backport] Fixxes magento#15565
[Backport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
[Backport] ISSUE-11477 - fixed Swagger response for searchCriteria
[Backport] Adding support for variadic arguments' method in generated proxy c…
Contributor
|
@vgelani 18 commits? 4 files changed? Prior to creating PR please at least check that it corresponds to original one. Also, please use the tool for porting. |
Contributor
Author
|
@orlangur Porting tool gave me an error. Actually, I have changed this file only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15362
Description
Removed duplicate code and added comment on variable.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist