Skip to content

[Backport] ISSUE-11477 - fixed Swagger response for searchCriteria#28

Merged
gelanivishal merged 1 commit into2.1-developfrom
2.1-develop-PR-port-15322
Jun 8, 2018
Merged

[Backport] ISSUE-11477 - fixed Swagger response for searchCriteria#28
gelanivishal merged 1 commit into2.1-developfrom
2.1-develop-PR-port-15322

Conversation

@gelanivishal
Copy link
Copy Markdown
Owner

Original Pull Request

magento#15322
Added zero index to array signifier in searchCriteria parameters builder

Description

This fix allows to generate correct response when user want to test method with some search criteria parameters in Swagger.

Fixed Issues (if relevant)

  1. Magento REST API Schema (Swagger) is not compatible with Search Criteria magento/magento2#11477: Magento REST API Schema (Swagger) is not compatible with Search Criteria

Manual testing scenarios

  1. Open Swagger
  2. In method "catalogProductRepositoryV1" fill in "Parameters" tab values for searchCriteria which use "filterGroups" key
  3. Click "Try it out!"
  4. Check if Response Code is 200

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal merged commit 7ca71cc into 2.1-develop Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant