Skip to content

[Backport] set correct annotation#16

Merged
gelanivishal merged 1 commit into2.1-developfrom
2.1-develop-PR-port-15602
Jun 1, 2018
Merged

[Backport] set correct annotation#16
gelanivishal merged 1 commit into2.1-developfrom
2.1-develop-PR-port-15602

Conversation

@gelanivishal
Copy link
Copy Markdown
Owner

Original Pull Request

magento#15602

Description

Set correct annotation to formatDateTime function in lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php file

Fixed Issues (if relevant)

  1. magento/magento2#<15601>: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php

Manual testing scenarios

  1. Please review lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php
  2. Please review lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal merged commit 2d936be into 2.1-develop Jun 1, 2018
gelanivishal pushed a commit that referenced this pull request Aug 10, 2018
[Forwardport] Added 'title' attribute to 'img' tag in knockout template files.
gelanivishal pushed a commit that referenced this pull request Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants